[bluez/bluez] 0440ca: shared/util: Add strtoutf8 function

[bluez/bluez] 0440ca: shared/util: Add strtoutf8 function

[fdanis-oss]

  Branch: refs/heads/master
  Home:   https://github.com/bluez/bluez
  Commit: 0440ca68a8c4ca3a4c26500b521b362693a2e1ae
      https://github.com/bluez/bluez/commit/0440ca68a8c4ca3a4c26500b521b362693a2e1ae
  Author: Frédéric Danis <frederic.danis@collabora.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M src/shared/util.c
    M src/shared/util.h

  Log Message:
  -----------
  shared/util: Add strtoutf8 function

This adds the strtoutf8 function that truncate a string before the
first non UTF-8 character.
This truncation is done in place.


  Commit: 89079f2ca635601c1408f8318978c1bc75ca5efd
      https://github.com/bluez/bluez/commit/89079f2ca635601c1408f8318978c1bc75ca5efd
  Author: Frédéric Danis <frederic.danis@collabora.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M profiles/audio/avrcp.c

  Log Message:
  -----------
  audio/avrcp: Fix crash with invalid UTF-8 item name

As stated in AVRCP 1.6.2 chapter 6.10.2.3 Media element item, for the
Displayable Name Length property, the target device may truncate the
item name:

  Length of Displayable Name in octets. The name shall be limited such
  that a response to a GetFolderItems containing one media player item
  fits within the maximum size of PDU which can be received by the CT.

This truncatation may occur in the middle of a multi-byte character,
at least with Samsung Music app, which triggers a DBus assertion and
crashes bluetoothd:

  profiles/audio/player.c:media_folder_create_item() Din Dhal Jaye
      Haye with lyrics | "दिन ढल जाए
      हाय" गाने के बो� type audio uid 1
  profiles/audio/player.c:media_folder_create_item()
      /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1
  profiles/audio/player.c:media_player_set_metadata() Title: Din Dhal
      Jaye Haye with lyrics | "दिन ढल जाए हाय"
      गाने के बोल | Guide | Dev Anand, Waheeda Rehman
  …
  arguments to dbus_message_iter_append_basic() were incorrect,
      assertion "_dbus_check_is_valid_utf8 (*string_p)" failed in
      file dbus-message.c line 2775.
  This is normally a bug in some application using the D-Bus library.


  Commit: a8f59849253d6ef0900441dd2b0930945672725b
      https://github.com/bluez/bluez/commit/a8f59849253d6ef0900441dd2b0930945672725b
  Author: Frédéric Danis <frederic.danis@collabora.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M profiles/audio/mcp.c

  Log Message:
  -----------
  audio/mcp: Use strtoutf8 for player name and track title

Truncate the string to first character before invalid UTF-8 one
instead of replacing non ascii characters by spaces.


  Commit: a0387d66372beee3940c778031e94940acf10c63
      https://github.com/bluez/bluez/commit/a0387d66372beee3940c778031e94940acf10c63
  Author: Frédéric Danis <frederic.danis@collabora.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M profiles/gap/gas.c

  Log Message:
  -----------
  audio/gap: Use strtoutf8 for GAP device name

Truncate the string to first character before invalid UTF-8 one
instead of replacing non ascii characters by spaces.


  Commit: 218db700f49370bc07ce1e6d609d28d846470d99
      https://github.com/bluez/bluez/commit/218db700f49370bc07ce1e6d609d28d846470d99
  Author: Frédéric Danis <frederic.danis@collabora.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M src/eir.c

  Log Message:
  -----------
  eir: Use strtoutf8 for device names

Truncate the string to first character before invalid UTF-8 one
instead of replacing non ascii characters by spaces.


  Commit: 4cedd8d19ad5e416ca9f537d5129e548709287bc
      https://github.com/bluez/bluez/commit/4cedd8d19ad5e416ca9f537d5129e548709287bc
  Author: Frédéric Danis <frederic.danis@collabora.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M src/shared/ad.c

  Log Message:
  -----------
  shared/ad: Use strtoutf8 for name

Truncate the string to first character before invalid UTF-8 one
instead of replacing non ascii characters by spaces.


  Commit: 004518d061d4ecc1efc94a561e4050ac1928957e
      https://github.com/bluez/bluez/commit/004518d061d4ecc1efc94a561e4050ac1928957e
  Author: Frédéric Danis <frederic.danis@collabora.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M unit/test-eir.c

  Log Message:
  -----------
  unit/test-eir: Add name encoding tests

This ensures that device name encode with UTF-16, ISO-2022-JP or with
an incorrect character in UTF-8 string are truncated correctly.


Compare: https://github.com/bluez/bluez/compare/a7e0747e21de...004518d061d4

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications