From: Perale Thomas <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] b111b5: input: fix HID compilation w/o HoG
Date: Thu, 01 May 2025 12:08:27 -0700 [thread overview]
Message-ID: <bluez/bluez/push/refs/heads/master/bbfeef-9c5218@github.com> (raw)
Branch: refs/heads/master
Home: https://github.com/bluez/bluez
Commit: b111b5e15eb74e08b74cb3c7e91bcb21f54be4c7
https://github.com/bluez/bluez/commit/b111b5e15eb74e08b74cb3c7e91bcb21f54be4c7
Author: Thomas Perale <thomas.perale@mind.be>
Date: 2025-05-01 (Thu, 01 May 2025)
Changed paths:
M profiles/input/device.h
M profiles/input/hog.c
M profiles/input/manager.c
Log Message:
-----------
input: fix HID compilation w/o HoG
Commit [1] introduced a dependency with the HID plugin in the HoG code
As a result, building with --enable-hid --disable-hog caused linker
errors due to undefined references to HoG-related functions:
```
> ./configure --enable-hid --disable-hog
...
> make
...
CCLD src/bluetoothd
/usr/bin/ld: profiles/input/bluetoothd-manager.o: in function `input_init':
/home/../bluez/profiles/input/manager.c:122:(.text.input_init+0x1c8): undefined reference to `input_set_auto_sec'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:6376: src/bluetoothd] Error 1
```
This patch moves the reading of the HOG specific configuration of the
'input.conf' file: LEAutoSecurity, to the HoG plugin file.
[1] f2778f587 input: Add LEAutoSecurity setting to input.conf
Commit: 9c52188d753002a6afd6ae145f921a2ff52c1c81
https://github.com/bluez/bluez/commit/9c52188d753002a6afd6ae145f921a2ff52c1c81
Author: Thomas Perale <thomas.perale@mind.be>
Date: 2025-05-01 (Thu, 01 May 2025)
Changed paths:
M profiles/input/device.c
M profiles/input/device.h
M profiles/input/hog.c
Log Message:
-----------
input: fix HoG compilation w/o HID
Commit [1] introduced a dependency with the HID plugin in the HoG code
As a result, building with --disable-hid --enable-hog caused linker
errors due to undefined references to HID-related functions:
```
> ./configure --disable-hid --enable-hog
> make
/usr/bin/ld: profiles/input/bluetoothd-hog.o: in function `hog_accept':
/home/../bluez/profiles/input/hog.c:184:(.text.hog_accept+0xbb): undefined reference to `input_get_auto_sec'
/usr/bin/ld: profiles/input/bluetoothd-hog.o: in function `hog_disconnect':
/home/../bluez/profiles/input/hog.c:205:(.text.hog_disconnect+0x12): undefined reference to `input_get_userspace_hid'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:6344: src/bluetoothd] Error 1
make: *** [Makefile:4695: all] Error 2
```
This patch duplicate the read of the 'UserspaceHID=persist' config entry
in the HoG plugin file to remove the dependency on the HID plugin files.
[1] 1782bfd79 input: Add support for UserspaceHID=persist
Fixes: https://github.com/bluez/bluez/issues/1228
Compare: https://github.com/bluez/bluez/compare/bbfeef3a04b0...9c52188d7530
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
reply other threads:[~2025-05-01 19:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bluez/bluez/push/refs/heads/master/bbfeef-9c5218@github.com \
--to=noreply@github.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox