From: Pauli Virtanen <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] 9c9d6c: audio: Fix typos in A2DP error messages
Date: Mon, 15 Sep 2025 06:33:11 -0700 [thread overview]
Message-ID: <bluez/bluez/push/refs/heads/master/befdac-4d7d25@github.com> (raw)
Branch: refs/heads/master
Home: https://github.com/bluez/bluez
Commit: 9c9d6ca27bcb3deb3bc80a7aff2b990e39377dc9
https://github.com/bluez/bluez/commit/9c9d6ca27bcb3deb3bc80a7aff2b990e39377dc9
Author: Per Waagø <pwaago@cisco.com>
Date: 2025-09-15 (Mon, 15 Sep 2025)
Changed paths:
M doc/org.bluez.MediaEndpoint.rst
M profiles/audio/a2dp.c
M profiles/audio/a2dp.h
Log Message:
-----------
audio: Fix typos in A2DP error messages
Commit: 4d7d25b702454a7c5e4b88877d463860b10dbd69
https://github.com/bluez/bluez/commit/4d7d25b702454a7c5e4b88877d463860b10dbd69
Author: Pauli Virtanen <pav@iki.fi>
Date: 2025-09-15 (Mon, 15 Sep 2025)
Changed paths:
M profiles/audio/avdtp.c
Log Message:
-----------
avdtp: wait for L2CAP Disconnect Rsp before CLOSING->IDLE
Delay CLOSING->IDLE until remote acknowledges L2CAP channel closure.
It is not explicitly stated in AVDTP v1.3 Sec. 6.13, but some devices
refuse commands sent immediately after L2CAP Disconnect Req, so wait
until Rsp.
Fails:
> ACL Data RX: Handle 6 flags 0x02 dlen 6
Channel: 64 len 2 [PSM 25 mode Basic (0x00)] {chan 0}
AVDTP: Close (0x08) Response Accept (0x02) type 0x00 label 0 nosp 0
< ACL Data TX: Handle 6 flags 0x00 dlen 12
L2CAP: Disconnection Request (0x06) ident 16 len 4
Destination CID: 65
Source CID: 65
< ACL Data TX: Handle 6 flags 0x00 dlen 22
Channel: 64 len 18 [PSM 25 mode Basic (0x00)] {chan 0}
AVDTP: Set Configuration (0x03) Command (0x00) type 0x00 label 1 nosp 0
ACP SEID: 7
INT SEID: 1
Service Category: Media Transport (0x01)
Service Category: Media Codec (0x07)
Media Type: Audio (0x00)
Media Codec: MPEG-2,4 AAC (0x02)
Object Type: MPEG-4 AAC LC (0x40)
Frequency: 44100 (0x100)
Channels: 2 (0x04)
Bitrate: 220000bps
VBR: No
Service Category: Delay Reporting (0x08)
> ACL Data RX: Handle 6 flags 0x02 dlen 12
L2CAP: Disconnection Response (0x07) ident 16 len 4
Destination CID: 65
Source CID: 65
> ACL Data RX: Handle 6 flags 0x02 dlen 8
Channel: 64 len 4 [PSM 25 mode Basic (0x00)] {chan 0}
AVDTP: Set Configuration (0x03) Response Reject (0x03) type 0x00 label 1 nosp 0
Service Category: Reserved (0x29)
Error code: UNSUPPORTED_CONFIGURATION (0x29)
Works:
> ACL Data RX: Handle 4 flags 0x02 dlen 6
Channel: 64 len 2 [PSM 25 mode Basic (0x00)] {chan 0}
AVDTP: Close (0x08) Response Accept (0x02) type 0x00 label 12 nosp 0
< ACL Data TX: Handle 4 flags 0x00 dlen 12
L2CAP: Disconnection Request (0x06) ident 16 len 4
Destination CID: 65
Source CID: 65
> ACL Data RX: Handle 4 flags 0x02 dlen 12
L2CAP: Disconnection Response (0x07) ident 16 len 4
Destination CID: 65
Source CID: 65
< ACL Data TX: Handle 4 flags 0x00 dlen 22
Channel: 64 len 18 [PSM 25 mode Basic (0x00)] {chan 0}
AVDTP: Set Configuration (0x03) Command (0x00) type 0x00 label 13 nosp 0
ACP SEID: 9
INT SEID: 2
Service Category: Media Transport (0x01)
Service Category: Media Codec (0x07)
Media Type: Audio (0x00)
Media Codec: MPEG-2,4 AAC (0x02)
Object Type: MPEG-4 AAC LC (0x40)
Frequency: 44100 (0x100)
Channels: 2 (0x04)
Bitrate: 220000bps
VBR: No
Service Category: Delay Reporting (0x08)
> ACL Data RX: Handle 4 flags 0x02 dlen 6
Channel: 64 len 2 [PSM 25 mode Basic (0x00)] {chan 0}
AVDTP: Set Configuration (0x03) Response Accept (0x02) type 0x00 label 13 nosp 0
Fixes: https://github.com/bluez/bluez/issues/1471
Fixes: aa118e965b ("a2dp: Don't wait to reconfigure")
Compare: https://github.com/bluez/bluez/compare/befdacd236c3...4d7d25b70245
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
reply other threads:[~2025-09-15 13:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bluez/bluez/push/refs/heads/master/befdac-4d7d25@github.com \
--to=noreply@github.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox