[Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU)

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=215197

--- Comment #10 from Erhard F. (erhard_f@mailbox.org) ---
(In reply to rtl8821cerfe2 from comment #8)
> Hi!
> 
> Can you check if this 100% untested patch fixes the leak?
Checked it out today. Seems you nailed it with your 100% untested patch! :)

I needed to take a small modification however or else I get a
"drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5609:1: error: expected
statement" at building.

The ';' before the function end needs to stay as 'out:' expects a statement
next. Sure ugly as hell but so is the accompanying goto a few lines above.


--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c     2022-12-09
01:51:56.213989176 +0100
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.cn    2022-12-09
01:56:35.543654839 +0100
@@ -5601,10 +5601,12 @@
                default:
                        break;
                }
+
+               dev_kfree_skb(skb);
        }

 out:
-       dev_kfree_skb(skb);
+       ;
 }

 static void rtl8723bu_handle_c2h(struct rtl8xxxu_priv *priv,


Patch applies on v6.1-rc8 and with this small modification building succeeds.
With the patch applied I have not seen the memleak since, even when taking
actions provoking it faster (e.g. unplugging and re-plugging the USB adapter
while playing sound). Without the patch v6.1-rc8 still shows the leak.

And so far I have not noticed any side effects of the patch in kernel dmesg.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.