* [Bug 215197] Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
@ 2021-12-02 0:04 ` bugzilla-daemon
2021-12-02 0:04 ` bugzilla-daemon
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2021-12-02 0:04 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
--- Comment #1 from Erhard F. (erhard_f@mailbox.org) ---
Created attachment 299825
--> https://bugzilla.kernel.org/attachment.cgi?id=299825&action=edit
kernel -config (5.16-rc3, AMD FX-8370)
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
2021-12-02 0:04 ` [Bug 215197] " bugzilla-daemon
@ 2021-12-02 0:04 ` bugzilla-daemon
2021-12-02 0:07 ` bugzilla-daemon
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2021-12-02 0:04 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
Erhard F. (erhard_f@mailbox.org) changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #299825|kernel -config (5.16-rc3, |kernel .config (5.16-rc3,
description|AMD FX-8370) |AMD FX-8370)
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
2021-12-02 0:04 ` [Bug 215197] " bugzilla-daemon
2021-12-02 0:04 ` bugzilla-daemon
@ 2021-12-02 0:07 ` bugzilla-daemon
2021-12-02 0:08 ` bugzilla-daemon
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2021-12-02 0:07 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
--- Comment #2 from Erhard F. (erhard_f@mailbox.org) ---
Created attachment 299827
--> https://bugzilla.kernel.org/attachment.cgi?id=299827&action=edit
kernel dmesg (5.16-rc3, AMD FX-8370)
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
` (2 preceding siblings ...)
2021-12-02 0:07 ` bugzilla-daemon
@ 2021-12-02 0:08 ` bugzilla-daemon
2022-09-14 13:10 ` [Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU) bugzilla-daemon
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2021-12-02 0:08 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
--- Comment #3 from Erhard F. (erhard_f@mailbox.org) ---
Created attachment 299829
--> https://bugzilla.kernel.org/attachment.cgi?id=299829&action=edit
kernel netconsole.log (5.16-rc3, AMD FX-8370)
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
` (3 preceding siblings ...)
2021-12-02 0:08 ` bugzilla-daemon
@ 2022-09-14 13:10 ` bugzilla-daemon
2022-09-14 13:11 ` bugzilla-daemon
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2022-09-14 13:10 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
Erhard F. (erhard_f@mailbox.org) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Jes.Sorensen@gmail.com
Component|Bluetooth |network-wireless
Summary|Memory leaks show up a |Memory leaks show up when
|while after usung Edimax |using Edimax Wi-Fi N150
|Wi-Fi N150 Bluetooth4.0 USB |Bluetooth/Wireless USB
|Adapter (rtl8723be) |Adapter (RTL8XXXU)
--- Comment #4 from Erhard F. (erhard_f@mailbox.org) ---
Still a problem on v6.0-rc4:
# cat /sys/kernel/debug/kmemleak
unreferenced object 0xffff8b7b18611bc0 (size 216):
comm "iwd", pid 1992, jiffies 4294908755 (age 2333.527s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff9d294858>] kmem_cache_alloc+0x288/0x380
[<ffffffff9d7f161a>] __alloc_skb+0x8a/0x250
[<ffffffff9d7f18cc>] __netdev_alloc_skb+0xec/0x190
[<ffffffffc17f2f1f>] rtl8xxxu_submit_rx_urb+0x4f/0xf0 [rtl8xxxu]
[<ffffffffc17f0641>] rtl8xxxu_start+0x321/0x8b0 [rtl8xxxu]
[<ffffffffc16910dd>] drv_start+0x6d/0x120 [mac80211]
[<ffffffffc16af3e2>] ieee80211_do_open+0x142/0x9c0 [mac80211]
[<ffffffffc16b2279>] ieee80211_open+0x59/0x80 [mac80211]
[<ffffffff9d80ad72>] __dev_open+0x122/0x1f0
[<ffffffff9d815daa>] __dev_change_flags+0xaa/0x200
[<ffffffff9d81613c>] dev_change_flags+0x1c/0x60
[<ffffffff9d83575b>] do_setlink+0x4ab/0x10e0
[<ffffffff9d82f808>] rtnl_setlink+0x218/0x260
[<ffffffff9d834dbf>] rtnetlink_rcv_msg+0x32f/0x5e0
[<ffffffff9d880291>] netlink_rcv_skb+0x101/0x130
[<ffffffff9d87df33>] netlink_unicast+0x1d3/0x2d0
unreferenced object 0xffff8b7b18729a80 (size 216):
comm "iwd", pid 1992, jiffies 4294997204 (age 2038.757s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[...]
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
` (4 preceding siblings ...)
2022-09-14 13:10 ` [Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU) bugzilla-daemon
@ 2022-09-14 13:11 ` bugzilla-daemon
2022-09-14 13:12 ` bugzilla-daemon
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2022-09-14 13:11 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
--- Comment #5 from Erhard F. (erhard_f@mailbox.org) ---
Created attachment 301807
--> https://bugzilla.kernel.org/attachment.cgi?id=301807&action=edit
kmemleak output (6.0-rc4, AMD FX-8370)
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
` (5 preceding siblings ...)
2022-09-14 13:11 ` bugzilla-daemon
@ 2022-09-14 13:12 ` bugzilla-daemon
2022-09-14 13:13 ` bugzilla-daemon
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2022-09-14 13:12 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
Erhard F. (erhard_f@mailbox.org) changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #299825|0 |1
is obsolete| |
--- Comment #6 from Erhard F. (erhard_f@mailbox.org) ---
Created attachment 301808
--> https://bugzilla.kernel.org/attachment.cgi?id=301808&action=edit
kernel .config (6.0-rc4, AMD FX-8370)
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
` (6 preceding siblings ...)
2022-09-14 13:12 ` bugzilla-daemon
@ 2022-09-14 13:13 ` bugzilla-daemon
2022-11-17 21:22 ` bugzilla-daemon
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2022-09-14 13:13 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
Erhard F. (erhard_f@mailbox.org) changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #299829|0 |1
is obsolete| |
--- Comment #7 from Erhard F. (erhard_f@mailbox.org) ---
Created attachment 301809
--> https://bugzilla.kernel.org/attachment.cgi?id=301809&action=edit
kernel dmesg (6.0-r43, AMD FX-8370)
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
` (7 preceding siblings ...)
2022-09-14 13:13 ` bugzilla-daemon
@ 2022-11-17 21:22 ` bugzilla-daemon
2022-11-24 12:38 ` bugzilla-daemon
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2022-11-17 21:22 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
rtl8821cerfe2@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rtl8821cerfe2@gmail.com
--- Comment #8 from rtl8821cerfe2@gmail.com ---
Hi!
Can you check if this 100% untested patch fixes the leak?
diff --git a/rtl8xxxu_core.c b/rtl8xxxu_core.c
index 39f43c0..b60cc31 100644
--- a/rtl8xxxu_core.c
+++ b/rtl8xxxu_core.c
@@ -5805,10 +5805,11 @@ static void rtl8xxxu_c2hcmd_callback(struct work_struct
*work)
default:
break;
}
+
+ dev_kfree_skb(skb);
}
out:
- dev_kfree_skb(skb);
}
static void rtl8723bu_handle_c2h(struct rtl8xxxu_priv *priv,
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply related [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
` (8 preceding siblings ...)
2022-11-17 21:22 ` bugzilla-daemon
@ 2022-11-24 12:38 ` bugzilla-daemon
2022-12-09 1:17 ` bugzilla-daemon
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2022-11-24 12:38 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
--- Comment #9 from Erhard F. (erhard_f@mailbox.org) ---
Thanks! I can test in about 3 weeks and will report back. The machine & stick
in question are not at my place.
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
` (9 preceding siblings ...)
2022-11-24 12:38 ` bugzilla-daemon
@ 2022-12-09 1:17 ` bugzilla-daemon
2022-12-09 11:29 ` bugzilla-daemon
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2022-12-09 1:17 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
--- Comment #10 from Erhard F. (erhard_f@mailbox.org) ---
(In reply to rtl8821cerfe2 from comment #8)
> Hi!
>
> Can you check if this 100% untested patch fixes the leak?
Checked it out today. Seems you nailed it with your 100% untested patch! :)
I needed to take a small modification however or else I get a
"drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5609:1: error: expected
statement" at building.
The ';' before the function end needs to stay as 'out:' expects a statement
next. Sure ugly as hell but so is the accompanying goto a few lines above.
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c 2022-12-09
01:51:56.213989176 +0100
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.cn 2022-12-09
01:56:35.543654839 +0100
@@ -5601,10 +5601,12 @@
default:
break;
}
+
+ dev_kfree_skb(skb);
}
out:
- dev_kfree_skb(skb);
+ ;
}
static void rtl8723bu_handle_c2h(struct rtl8xxxu_priv *priv,
Patch applies on v6.1-rc8 and with this small modification building succeeds.
With the patch applied I have not seen the memleak since, even when taking
actions provoking it faster (e.g. unplugging and re-plugging the USB adapter
while playing sound). Without the patch v6.1-rc8 still shows the leak.
And so far I have not noticed any side effects of the patch in kernel dmesg.
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
` (10 preceding siblings ...)
2022-12-09 1:17 ` bugzilla-daemon
@ 2022-12-09 11:29 ` bugzilla-daemon
2022-12-09 11:32 ` bugzilla-daemon
2024-04-29 21:38 ` bugzilla-daemon
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2022-12-09 11:29 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
--- Comment #11 from rtl8821cerfe2@gmail.com ---
Thanks for testing. Can I say "Tested-by: Erhard F. <your email>" in the commit
message when I send the patch upstream? And also "Reported-by: ..."
I'll remove the goto because it causes memory leaks with the RTL8192EU.
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
` (11 preceding siblings ...)
2022-12-09 11:29 ` bugzilla-daemon
@ 2022-12-09 11:32 ` bugzilla-daemon
2024-04-29 21:38 ` bugzilla-daemon
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2022-12-09 11:32 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
--- Comment #12 from Erhard F. (erhard_f@mailbox.org) ---
Yes you can. And thanks for your work on the patch!
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug 215197] Memory leaks show up when using Edimax Wi-Fi N150 Bluetooth/Wireless USB Adapter (RTL8XXXU)
2021-12-02 0:03 [Bug 215197] New: Memory leaks show up a while after usung Edimax Wi-Fi N150 Bluetooth4.0 USB Adapter (rtl8723be) bugzilla-daemon
` (12 preceding siblings ...)
2022-12-09 11:32 ` bugzilla-daemon
@ 2024-04-29 21:38 ` bugzilla-daemon
13 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2024-04-29 21:38 UTC (permalink / raw)
To: linux-bluetooth
https://bugzilla.kernel.org/show_bug.cgi?id=215197
Erhard F. (erhard_f@mailbox.org) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |OBSOLETE
--- Comment #13 from Erhard F. (erhard_f@mailbox.org) ---
Seems the fix has found upstream meanwhile. At least I can no longer reproduce
the issue on current kernels.
Closing as obsolete.
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 15+ messages in thread