[Bug 216817] New: btusb device with ID 0489:e0d0 no longer working after v6.0

[Bug 216817] New: btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

            Bug ID: 216817
           Summary: btusb device with ID 0489:e0d0 no longer working after
                    v6.0
           Product: Drivers
           Version: 2.5
    Kernel Version: 6.0, 6.0.12
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Bluetooth
          Assignee: linux-bluetooth@vger.kernel.org
          Reporter: quantumphazor@gmail.com
        Regression: No

The internal USB Bluetooth device in my laptop no longer works since v6.0

Device in question:
ID 0489:e0d0 Foxconn / Hon Hai

Works fine in 5.19.x and fails after 6.0
I ran a bisect that resulted in it breaking after this commit:
26afbd826ee326e63a334c37fd45e82e50a615ec Bluetooth: Add initial implementation
of CIS connections

System: Lenovo ThinkPad T14 (AMD) Gen 2

dmesg output:

[    0.978396] usb 5-4: new full-speed USB device number 2 using xhci_hcd
[    1.142461] usb 5-4: New USB device found, idVendor=0489, idProduct=e0d0,
bcdDevice= 0.01
[    1.142467] usb 5-4: New USB device strings: Mfr=0, Product=0,
SerialNumber=0
[    4.591285] Bluetooth: Core ver 2.22
[    4.591304] Bluetooth: HCI device and connection manager initialized
[    4.591308] Bluetooth: HCI socket layer initialized
[    4.591309] Bluetooth: L2CAP socket layer initialized
[    4.591315] Bluetooth: SCO socket layer initialized
[    4.871972] usbcore: registered new interface driver btusb
[    4.883484] Bluetooth: hci0: HCI Enhanced Setup Synchronous Connection
command is advertised, but not supported.
[    4.973465] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[    4.973468] Bluetooth: BNEP filters: protocol multicast
[    4.973472] Bluetooth: BNEP socket layer initialized
[    4.975525] Bluetooth: hci0: unexpected cc 0x2060 length: 1 < 7
[    4.975537] Bluetooth: hci0: Opcode 0x2060 failed: -38
[    6.985714] Bluetooth: hci0: command tx timeout

Attached is output of lsusb -v -d 0489:e0d0

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

--- Comment #1 from Andrew M (quantumphazor@gmail.com) ---
Created attachment 303421
  --> https://bugzilla.kernel.org/attachment.cgi?id=303421&action=edit
output of lsusb -v -d 0489:e0d0

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

The Linux kernel's regression tracker (Thorsten Leemhuis) (regressions@leemhuis.info) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |regressions@leemhuis.info

--- Comment #2 from The Linux kernel's regression tracker (Thorsten Leemhuis) (regressions@leemhuis.info) ---
FWIW, there is a fix for that patch that might or might not be related to your
problem (I'm not a bluetooth developer):
https://lore.kernel.org/all/20221206012323.3684462-1-luiz.dentz@gmail.com/

You also might want to check if 6.1 works, as some fixes are not backported --
and 6.0 will likely be soon EOL anyway

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

--- Comment #3 from Andrew M (quantumphazor@gmail.com) ---
Unfortunately it sill fails with 6.1 from Arch testing and a latest git pull
(6.1.r13139.gf9ff5644bcc0) which both include that change.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

Luiz Von Dentz (luiz.dentz@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luiz.dentz@gmail.com

--- Comment #4 from Luiz Von Dentz (luiz.dentz@gmail.com) ---
Looks like the command that is failing is HCI_OP_LE_READ_BUFFER_SIZE_V2:

#define HCI_OP_LE_READ_BUFFER_SIZE_V2   0x2060

Looks like the controller is marking as supported but in fact it doesn't:

        /* Use Read LE Buffer Size V2 if supported */
        if (hdev->commands[41] & 0x20)
                return __hci_cmd_sync_status(hdev,
                                             HCI_OP_LE_READ_BUFFER_SIZE_V2,
                                             0, NULL, HCI_CMD_TIMEOUT);

So either we introduce a quirk that must be set by the driver or we fallback to
HCI_OP_LE_READ_BUFFER_SIZE if HCI_OP_LE_READ_BUFFER_SIZE_V2 is not supported,
the later perhaps save us more time detecting this broken behavior since some
manufacturers don't seem to even care to qualify their controllers.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

--- Comment #5 from Luiz Von Dentz (luiz.dentz@gmail.com) ---
(In reply to Andrew M from comment #3)
> Unfortunately it sill fails with 6.1 from Arch testing and a latest git pull
> (6.1.r13139.gf9ff5644bcc0) which both include that change.

Can you try with the following patch:

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 5220bfd75b00..b3676b899647 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -3572,7 +3572,7 @@ static const struct hci_init_stage hci_init2[] = {
 static int hci_le_read_buffer_size_sync(struct hci_dev *hdev)
 {
        /* Use Read LE Buffer Size V2 if supported */
-       if (hdev->commands[41] & 0x20)
+       if (iso_capable(hdev) && hdev->commands[41] & 0x20)
                return __hci_cmd_sync_status(hdev,
                                             HCI_OP_LE_READ_BUFFER_SIZE_V2,
                                             0, NULL, HCI_CMD_TIMEOUT);

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

RE: [Bug,216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----

error: patch failed: net/bluetooth/hci_sync.c:3572
error: net/bluetooth/hci_sync.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch

Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

--- Comment #6 from Andrew M (quantumphazor@gmail.com) ---
(In reply to Luiz Von Dentz from comment #5)
> Can you try with the following patch

Thanks for the quick response. Tried the patch and it has solved the problem
for me on both 6.1.0 and git.
I hope it makes it into 6.1.1

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

--- Comment #7 from Luiz Von Dentz (luiz.dentz@gmail.com) ---
(In reply to Andrew M from comment #6)
> (In reply to Luiz Von Dentz from comment #5)
> > Can you try with the following patch
> 
> Thanks for the quick response. Tried the patch and it has solved the problem
> for me on both 6.1.0 and git.
> I hope it makes it into 6.1.1

Please test with the latest version:

https://patchwork.kernel.org/project/bluetooth/patch/20221219234945.3733741-1-luiz.dentz@gmail.com/

It turns out the features are not ready if we don't change the command sequence
so iso_capable would always evaluate to false.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

--- Comment #8 from Andrew M (quantumphazor@gmail.com) ---
(In reply to Luiz Von Dentz from comment #7)
> (In reply to Andrew M from comment #6)
> > (In reply to Luiz Von Dentz from comment #5)
> > > Can you try with the following patch
> > 
> > Thanks for the quick response. Tried the patch and it has solved the
> problem
> > for me on both 6.1.0 and git.
> > I hope it makes it into 6.1.1
> 
> Please test with the latest version:
> 
> https://patchwork.kernel.org/project/bluetooth/patch/20221219234945.3733741-
> 1-luiz.dentz@gmail.com/
> 
> It turns out the features are not ready if we don't change the command
> sequence so iso_capable would always evaluate to false.

Still works. Tested v6.1 and 6.1.r13872.gb6bb9676f216

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.limonciello@amd.com

--- Comment #9 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
As this completely broke bluetooth for a number of people, can you please
consider this to be sent up to 6.2-rc in a fixes PR rather than waiting for 6.3
and

Cc: stable@vger.kernel.org # 6.1

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=2149136

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

--- Comment #10 from The Linux kernel's regression tracker (Thorsten Leemhuis) (regressions@leemhuis.info) ---
(In reply to Mario Limonciello (AMD) from comment #9)
> As this completely broke bluetooth for a number of people,

Did it? Ohh, interesting.

> can you please
> consider this to be sent up to 6.2-rc in a fixes PR rather than waiting for
> 6.3 and
> 
> Cc: stable@vger.kernel.org # 6.1

Luiz, that sounds like a reasonable request. Did you work on that front?
Doesn't look like it from here, but maybe I missed something.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

--- Comment #11 from Luiz Von Dentz (luiz.dentz@gmail.com) ---
Sorry for late reply, long weekend here, I will create a pull request for net
so hopefully this get in the next rc.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 216817] btusb device with ID 0489:e0d0 no longer working after v6.0

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216817

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #12 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
As this is upstreamed as of 6.2-rc5 (3a4d29b6d631b ("Bluetooth: hci_sync: Fix
use HCI_OP_LE_READ_BUFFER_SIZE_V2")) closing this issue.

The fix should trickle into 6.1.y as well.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.