Re: [BlueZ v3 0/6] Add helper for "cleanup" variable attribute

[Bastien Nocera <hadess@hadess.net>]

On Tue, 2026-05-12 at 15:38 -0400, Luiz Augusto von Dentz wrote:
> Hi Bastien,
> 
> On Tue, May 12, 2026 at 3:21 PM <patchwork-bot+bluetooth@kernel.org>
> wrote:
> > 
> > Hello:
> > 
> > This series was applied to bluetooth/bluez.git (master)
> > by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
> > 
> > On Mon, 11 May 2026 15:18:03 +0200 you wrote:
> > > As discussed in:
> > > https://lore.kernel.org/linux-bluetooth/ed949f2550f79a4bef19bd482bf8b069ad5b7e0c.camel@hadess.net/
> > > 
> > > Implement a cleanup helper.
> > > 
> > > The MIN/MAX fix is here because it touches the same hunk in
> > > src/main.c
> > > as the other patches. Feel free to pick it up straight away while
> > > the
> > > rest is discussed.
> > > 
> > > [...]
> > 
> > Here is the summary with links:
> >   - [BlueZ,v3,1/6] all: Remove more unneeded MIN/MAX macro
> > definition
> >    
> > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ca2b39b0c08e
> >   - [BlueZ,v3,2/6] shared/util: Add helper for "cleanup" variable
> > attribute
> >     (no matching commit)
> >   - [BlueZ,v3,3/6] doc: Recommend using _cleanup_ and friends
> >    
> > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9ba6c13df5fb
> >   - [BlueZ,v3,4/6] main: Use _cleanup_() to simplify configuration
> > parsing
> >    
> > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=140e3569295c
> >   - [BlueZ,v3,5/6] client: Use _cleanup_fd_ to simplify urandom
> > access
> >    
> > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=e33f5027b898
> >   - [BlueZ,v3,6/6] btattach: Use _cleanup_fd_ to simplify error
> > paths
> >    
> > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=02aa9a8cfe6a
> > 
> > You are awesome, thank you!
> > --
> > Deet-doot-dot, I am a bot.
> > https://korg.docs.kernel.org/patchwork/pwbot.html
> 
> We will probably need to revert the cleanup changes, they are causing
> crashes and other problems when run under Valgrind.

Please do, I've managed to reproduce some of the problems locally,
which I didn't see in my testing, even running under valgrind.

I'll send a v4 later.

Cheers