From: Markus Elfring <Markus.Elfring@web.de>
To: Sean Wang <sean.wang@mediatek.com>,
linux-bluetooth@vger.kernel.org,
linux-mediatek@lists.infradead.org,
kernel-janitors@vger.kernel.org,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Von Dentz <luiz.dentz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Sean Wang <sean.wang@kernel.org>,
Chris Lu <chris.lu@mediatek.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Deren Wu <deren.wu@mediatek.com>,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
Manish Mandlik <mmandlik@google.com>,
Miao-chen Chou <mcchou@chromium.org>,
Michael Sun <michaelfsun@google.com>,
shawnku@google.com, frankgor@google.com, jsiuda@google.com
Subject: Re: [PATCH RESEND] Bluetooth: btusb: medaitek: fix double free of skb in coredump
Date: Thu, 18 Apr 2024 11:40:26 +0200 [thread overview]
Message-ID: <cb593f2a-7dbe-44aa-b9ff-7fc57a4bd70a@web.de> (raw)
In-Reply-To: <da0859c4b24d314d9ff38179c26a58ee7e3f16d6.1713395895.git.sean.wang@kernel.org>
> hci_devcd_append() would free the skb on error so the caller don't
> have to free it again otherwise it would cause the double free of skb.
I hope that a typo will be avoided in the subsystem specification
for the final commit.
Regards,
Markus
next prev parent reply other threads:[~2024-04-18 9:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 23:27 [PATCH RESEND] Bluetooth: btusb: medaitek: fix double free of skb in coredump sean.wang
2024-04-17 23:57 ` [RESEND] " bluez.test.bot
2024-04-18 9:40 ` Markus Elfring [this message]
2024-04-19 19:42 ` [PATCH RESEND] " Luiz Augusto von Dentz
2024-04-19 19:56 ` Markus Elfring
2024-04-19 19:50 ` [PATCH RESEND] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb593f2a-7dbe-44aa-b9ff-7fc57a4bd70a@web.de \
--to=markus.elfring@web.de \
--cc=abhishekpandit@chromium.org \
--cc=chris.lu@mediatek.com \
--cc=dan.carpenter@linaro.org \
--cc=deren.wu@mediatek.com \
--cc=frankgor@google.com \
--cc=johan.hedberg@gmail.com \
--cc=jsiuda@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mcchou@chromium.org \
--cc=michaelfsun@google.com \
--cc=mmandlik@google.com \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=shawnku@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox