From: Biman Paul <biman.innovative@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Biman Paul <biman.paul@samsung.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
Biman Paul <biman.paul@samsung.com>
Subject: Re: [PATCH 1/1] parser/sdp: parse MAS Instance ID and Message Type
Date: Sun, 4 Sep 2016 12:32:12 +0530 [thread overview]
Message-ID: <cd0a223d-c8d7-f587-4106-9ff62813a36a@gmail.com> (raw)
In-Reply-To: <CABBYNZK2WcZOyUJ7E5bNHNXuZw+6Y2Nfar9bHn75ViVjt_MLdg@mail.gmail.com>
Hi Luiz
On Thursday 10 March 2016 02:42 PM, Luiz Augusto von Dentz wrote:
> Hi Paul,
>
> On Wed, Mar 9, 2016 at 11:36 PM, Biman Paul <bimanpaul@gmail.com> wrote:
>> From: Biman Paul <biman.paul@samsung.com>
>>
>> Parsing Support added in SDP record:
>> 1. MAS Instance ID in MAP
>> 2. Message Types supported by MAS
>
>
> Can you please add the output of these changes, btw these parses are
> deprecated in favor of monitor so perhaps you would want to add these
> changes there as well.
I shall update the patch with output details.
I shall consider the changes for monitor separately.
>
>> ---
>> tools/parser/sdp.c | 3 +++
>> tools/parser/sdp.h | 3 +++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/tools/parser/sdp.c b/tools/parser/sdp.c
>> index dba9a36..1f8d6c5 100644
>> --- a/tools/parser/sdp.c
>> +++ b/tools/parser/sdp.c
>> @@ -211,6 +211,9 @@ static sdp_attr_id_nam_lookup_table_t sdp_attr_id_nam_lookup_table[] = {
>> { SDP_ATTR_ID_SUPPORTED_FUNCTIONS, "SuppFunctions" }, /* Imaging */
>> { SDP_ATTR_ID_TOTAL_IMAGING_DATA_CAPACITY, "SuppTotalCapacity" }, /* Imaging */
>> { SDP_ATTR_ID_SUPPORTED_REPOSITORIES, "SuppRepositories" }, /* PBAP */
>> + { SDP_ATTR_ID_MAS_INSTANCE_ID, "MASInstanceID" }, /* MAS ID */
>> + { SDP_ATTR_ID_MAP_SUPPORTED_TYPES, "SupportedMessageTypes" }, /* Message Types */
>> };
>>
>> #define SDP_ATTR_ID_NAM_LOOKUP_TABLE_SIZE \
>> diff --git a/tools/parser/sdp.h b/tools/parser/sdp.h
>> index ed55a23..130da3f 100644
>> --- a/tools/parser/sdp.h
>> +++ b/tools/parser/sdp.h
>> @@ -157,5 +157,8 @@
>> #define SDP_ATTR_ID_SUPPORTED_FUNCTIONS 0x0312 /* Imaging */
>> #define SDP_ATTR_ID_TOTAL_IMAGING_DATA_CAPACITY 0x0313 /* Imaging */
>> #define SDP_ATTR_ID_SUPPORTED_REPOSITORIES 0x0314 /* PBAP */
>> +#define SDP_ATTR_ID_MAS_INSTANCE_ID 0x0315 /* MAS ID */
>> +#define SDP_ATTR_ID_MAP_SUPPORTED_TYPES 0x0316 /* Message Types */
>>
>> #endif /* __SDP_H */
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
Regards
Biman
prev parent reply other threads:[~2016-09-04 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 21:36 [PATCH 1/1] parser/sdp: parse MAS Instance ID and Message Type Biman Paul
2016-03-10 9:12 ` Luiz Augusto von Dentz
2016-09-04 7:02 ` Biman Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd0a223d-c8d7-f587-4106-9ff62813a36a@gmail.com \
--to=biman.innovative@gmail.com \
--cc=biman.paul@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).