linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] parser/sdp: parse MAS Instance ID and Message Type
@ 2016-03-09 21:36 Biman Paul
  2016-03-10  9:12 ` Luiz Augusto von Dentz
  0 siblings, 1 reply; 3+ messages in thread
From: Biman Paul @ 2016-03-09 21:36 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Biman Paul

From: Biman Paul <biman.paul@samsung.com>

Parsing Support added in SDP record:
1. MAS Instance ID in MAP
2. Message Types supported by MAS
---
 tools/parser/sdp.c |    3 +++
 tools/parser/sdp.h |    3 +++
 2 files changed, 6 insertions(+)

diff --git a/tools/parser/sdp.c b/tools/parser/sdp.c
index dba9a36..1f8d6c5 100644
--- a/tools/parser/sdp.c
+++ b/tools/parser/sdp.c
@@ -211,6 +211,9 @@ static sdp_attr_id_nam_lookup_table_t sdp_attr_id_nam_lookup_table[] = {
 	{ SDP_ATTR_ID_SUPPORTED_FUNCTIONS,               "SuppFunctions"      }, /* Imaging */
 	{ SDP_ATTR_ID_TOTAL_IMAGING_DATA_CAPACITY,       "SuppTotalCapacity"  }, /* Imaging */
 	{ SDP_ATTR_ID_SUPPORTED_REPOSITORIES,            "SuppRepositories"   }, /* PBAP */
+	{ SDP_ATTR_ID_MAS_INSTANCE_ID,                   "MASInstanceID"      }, /* MAS ID */
+	{ SDP_ATTR_ID_MAP_SUPPORTED_TYPES,               "SupportedMessageTypes" }, /* Message Types */
 };
 
 #define SDP_ATTR_ID_NAM_LOOKUP_TABLE_SIZE \
diff --git a/tools/parser/sdp.h b/tools/parser/sdp.h
index ed55a23..130da3f 100644
--- a/tools/parser/sdp.h
+++ b/tools/parser/sdp.h
@@ -157,5 +157,8 @@
 #define SDP_ATTR_ID_SUPPORTED_FUNCTIONS                0x0312 /* Imaging */
 #define SDP_ATTR_ID_TOTAL_IMAGING_DATA_CAPACITY        0x0313 /* Imaging */
 #define SDP_ATTR_ID_SUPPORTED_REPOSITORIES             0x0314 /* PBAP */
+#define SDP_ATTR_ID_MAS_INSTANCE_ID                    0x0315 /* MAS ID */
+#define SDP_ATTR_ID_MAP_SUPPORTED_TYPES                0x0316 /* Message Types */
 
 #endif /* __SDP_H */
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] parser/sdp: parse MAS Instance ID and Message Type
  2016-03-09 21:36 [PATCH 1/1] parser/sdp: parse MAS Instance ID and Message Type Biman Paul
@ 2016-03-10  9:12 ` Luiz Augusto von Dentz
  2016-09-04  7:02   ` Biman Paul
  0 siblings, 1 reply; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2016-03-10  9:12 UTC (permalink / raw)
  To: Biman Paul; +Cc: linux-bluetooth@vger.kernel.org, Biman Paul

Hi Paul,

On Wed, Mar 9, 2016 at 11:36 PM, Biman Paul <bimanpaul@gmail.com> wrote:
> From: Biman Paul <biman.paul@samsung.com>
>
> Parsing Support added in SDP record:
> 1. MAS Instance ID in MAP
> 2. Message Types supported by MAS


Can you please add the output of these changes, btw these parses are
deprecated in favor of monitor so perhaps you would want to add these
changes there as well.

> ---
>  tools/parser/sdp.c |    3 +++
>  tools/parser/sdp.h |    3 +++
>  2 files changed, 6 insertions(+)
>
> diff --git a/tools/parser/sdp.c b/tools/parser/sdp.c
> index dba9a36..1f8d6c5 100644
> --- a/tools/parser/sdp.c
> +++ b/tools/parser/sdp.c
> @@ -211,6 +211,9 @@ static sdp_attr_id_nam_lookup_table_t sdp_attr_id_nam_lookup_table[] = {
>         { SDP_ATTR_ID_SUPPORTED_FUNCTIONS,               "SuppFunctions"      }, /* Imaging */
>         { SDP_ATTR_ID_TOTAL_IMAGING_DATA_CAPACITY,       "SuppTotalCapacity"  }, /* Imaging */
>         { SDP_ATTR_ID_SUPPORTED_REPOSITORIES,            "SuppRepositories"   }, /* PBAP */
> +       { SDP_ATTR_ID_MAS_INSTANCE_ID,                   "MASInstanceID"      }, /* MAS ID */
> +       { SDP_ATTR_ID_MAP_SUPPORTED_TYPES,               "SupportedMessageTypes" }, /* Message Types */
>  };
>
>  #define SDP_ATTR_ID_NAM_LOOKUP_TABLE_SIZE \
> diff --git a/tools/parser/sdp.h b/tools/parser/sdp.h
> index ed55a23..130da3f 100644
> --- a/tools/parser/sdp.h
> +++ b/tools/parser/sdp.h
> @@ -157,5 +157,8 @@
>  #define SDP_ATTR_ID_SUPPORTED_FUNCTIONS                0x0312 /* Imaging */
>  #define SDP_ATTR_ID_TOTAL_IMAGING_DATA_CAPACITY        0x0313 /* Imaging */
>  #define SDP_ATTR_ID_SUPPORTED_REPOSITORIES             0x0314 /* PBAP */
> +#define SDP_ATTR_ID_MAS_INSTANCE_ID                    0x0315 /* MAS ID */
> +#define SDP_ATTR_ID_MAP_SUPPORTED_TYPES                0x0316 /* Message Types */
>
>  #endif /* __SDP_H */
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] parser/sdp: parse MAS Instance ID and Message Type
  2016-03-10  9:12 ` Luiz Augusto von Dentz
@ 2016-09-04  7:02   ` Biman Paul
  0 siblings, 0 replies; 3+ messages in thread
From: Biman Paul @ 2016-09-04  7:02 UTC (permalink / raw)
  To: Luiz Augusto von Dentz
  Cc: Biman Paul, linux-bluetooth@vger.kernel.org, Biman Paul

Hi Luiz

On Thursday 10 March 2016 02:42 PM, Luiz Augusto von Dentz wrote:
> Hi Paul,
>
> On Wed, Mar 9, 2016 at 11:36 PM, Biman Paul <bimanpaul@gmail.com> wrote:
>> From: Biman Paul <biman.paul@samsung.com>
>>
>> Parsing Support added in SDP record:
>> 1. MAS Instance ID in MAP
>> 2. Message Types supported by MAS
>
>
> Can you please add the output of these changes, btw these parses are
> deprecated in favor of monitor so perhaps you would want to add these
> changes there as well.

I shall update the patch with output details.
I shall consider the changes for monitor separately.
>
>> ---
>>  tools/parser/sdp.c |    3 +++
>>  tools/parser/sdp.h |    3 +++
>>  2 files changed, 6 insertions(+)
>>
>> diff --git a/tools/parser/sdp.c b/tools/parser/sdp.c
>> index dba9a36..1f8d6c5 100644
>> --- a/tools/parser/sdp.c
>> +++ b/tools/parser/sdp.c
>> @@ -211,6 +211,9 @@ static sdp_attr_id_nam_lookup_table_t sdp_attr_id_nam_lookup_table[] = {
>>         { SDP_ATTR_ID_SUPPORTED_FUNCTIONS,               "SuppFunctions"      }, /* Imaging */
>>         { SDP_ATTR_ID_TOTAL_IMAGING_DATA_CAPACITY,       "SuppTotalCapacity"  }, /* Imaging */
>>         { SDP_ATTR_ID_SUPPORTED_REPOSITORIES,            "SuppRepositories"   }, /* PBAP */
>> +       { SDP_ATTR_ID_MAS_INSTANCE_ID,                   "MASInstanceID"      }, /* MAS ID */
>> +       { SDP_ATTR_ID_MAP_SUPPORTED_TYPES,               "SupportedMessageTypes" }, /* Message Types */
>>  };
>>
>>  #define SDP_ATTR_ID_NAM_LOOKUP_TABLE_SIZE \
>> diff --git a/tools/parser/sdp.h b/tools/parser/sdp.h
>> index ed55a23..130da3f 100644
>> --- a/tools/parser/sdp.h
>> +++ b/tools/parser/sdp.h
>> @@ -157,5 +157,8 @@
>>  #define SDP_ATTR_ID_SUPPORTED_FUNCTIONS                0x0312 /* Imaging */
>>  #define SDP_ATTR_ID_TOTAL_IMAGING_DATA_CAPACITY        0x0313 /* Imaging */
>>  #define SDP_ATTR_ID_SUPPORTED_REPOSITORIES             0x0314 /* PBAP */
>> +#define SDP_ATTR_ID_MAS_INSTANCE_ID                    0x0315 /* MAS ID */
>> +#define SDP_ATTR_ID_MAP_SUPPORTED_TYPES                0x0316 /* Message Types */
>>
>>  #endif /* __SDP_H */
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
>


Regards
Biman

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-09-04  7:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-09 21:36 [PATCH 1/1] parser/sdp: parse MAS Instance ID and Message Type Biman Paul
2016-03-10  9:12 ` Luiz Augusto von Dentz
2016-09-04  7:02   ` Biman Paul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).