From: Andrew Lunn <andrew@lunn.ch>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-bluetooth@vger.kernel.org
Subject: Re: [RFC PATCH] net: skb: on zero-copy formatted output to skb
Date: Thu, 23 Apr 2026 18:46:38 +0200 [thread overview]
Message-ID: <cdcb241c-5c7c-4ce4-a628-0375ff2668b2@lunn.ch> (raw)
In-Reply-To: <65872064c2ab5fbf47a743f2dcd72182ea8296a7.camel@yandex.ru>
> > So please add some kerneldoc describing what it actually does.
>
> OK, some more neutral name like 'skb_fmt(...)' may be better indeed.
Sure. Just document what it actually does, what the return value
means, etc.
> > Please also annotate the const char *fmt, so the compiler can do
> > format string checks, parameter counting etc.
>
> Surely '__printf(2, 3)' should be used here.
Yep.
Thanks
Andrew
prev parent reply other threads:[~2026-04-23 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 7:36 [RFC PATCH] net: skb: on zero-copy formatted output to skb Dmitry Antipov
2026-04-23 9:47 ` [RFC] " bluez.test.bot
2026-04-23 12:24 ` [RFC PATCH] " Andrew Lunn
2026-04-23 12:40 ` Andrew Lunn
2026-04-23 16:03 ` Dmitry Antipov
2026-04-23 16:46 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdcb241c-5c7c-4ce4-a628-0375ff2668b2@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmantipov@yandex.ru \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox