linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Frederic Danis <frederic.danis.oss@gmail.com>,
	Loic Poulain <loic.poulain@linaro.org>,
	Hans de Goede <hdegoede@redhat.com>, Max Shavrick <mxms@me.com>,
	Leif Liddy <leif.liddy@gmail.com>,
	Daniel Roschka <danielroschka@phoenitydawn.de>,
	Ronald Tschalaer <ronald@innovation.ch>,
	"Peter Y. Chuang" <peteryuchuang@gmail.com>,
	linux-bluetooth@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>
Subject: [PATCH v2 00/10] Bluetooth on 2015+ MacBook (Pro)
Date: Tue, 2 Jan 2018 20:08:40 +0100	[thread overview]
Message-ID: <cover.1514916630.git.lukas@wunner.de> (raw)

Enable UART-attached Bluetooth on 2015+ MacBook (Pro), v2.

Changes since v1:

- New patch [1/10] to make Bluetooth drivers depend on rather than select
  GPIOLIB. (Andy, Linus)

- New patch [2/10] to enforce presence of shutdown and device wake GPIO.
  (Andy, Linus, Loic)

- Split off hunks:
  to enable runtime PM despite absence of IRQ into patch [3/10],
  to validate the IRQ before using it into patch [4/10],
  to add a helper to toggle device wake GPIO into patch [5/10]. (Marcel)

- In patch [5/10], I had previously forgotten to toggle the device wake
  GPIO in bcm_gpio_set_power() on Macs, this is now fixed.

- New patch [6/10] to silence an irritating IRQ printk.

- New patch [7/10] to clean up an unnecessary #ifdef.

- New patch [8/10] to add kerneldoc for struct bcm_device.

- New patch [9/10] to add proper error handling to the driver.

- In patch [10/10]:
  add DSDT excerpt to the commit message,
  drop ternary operators for readability,
  return -EIO instead of -EFAULT if ACPI method calls fail,
  return -EOPNOTSUPP in inline stubs,
  use network subsystem comment style. (Marcel, Hans, Andy)
  Also, to accommodate to mandatory presence of the two GPIOs as per
  patch [2/10], rename bcm_apple_probe() to bcm_apple_get_resources()
  and call it from bcm_get_resources() instead of bcm_acpi_probe().

Link to v1:

https://www.spinics.net/lists/linux-bluetooth/msg73527.html

Thanks,

Lukas


Lukas Wunner (9):
  Bluetooth: Depend on rather than select GPIOLIB
  Bluetooth: hci_bcm: Mandate presence of shutdown and device wake GPIO
  Bluetooth: hci_bcm: Enable runtime PM despite absence of IRQ
  Bluetooth: hci_bcm: Add helper to toggle device wake GPIO
  Bluetooth: hci_bcm: Silence IRQ printk
  Bluetooth: hci_bcm: Clean up unnecessary #ifdef
  Bluetooth: hci_bcm: Document struct bcm_device
  Bluetooth: hci_bcm: Handle errors properly
  Bluetooth: hci_bcm: Support Apple GPIO handling

Ronald Tschalär (1):
  Bluetooth: hci_bcm: Validate IRQ before using it

 drivers/bluetooth/Kconfig   |   6 +-
 drivers/bluetooth/hci_bcm.c | 230 ++++++++++++++++++++++++++++++++++++--------
 2 files changed, 192 insertions(+), 44 deletions(-)

-- 
2.15.1

             reply	other threads:[~2018-01-02 19:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-02 19:08 Lukas Wunner [this message]
2018-01-02 19:08 ` [PATCH v2 04/10] Bluetooth: hci_bcm: Validate IRQ before using it Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 07/10] Bluetooth: hci_bcm: Clean up unnecessary #ifdef Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 06/10] Bluetooth: hci_bcm: Silence IRQ printk Lukas Wunner
2018-01-03 13:08   ` Andy Shevchenko
2018-01-03 13:56     ` Lukas Wunner
2018-01-03 16:05       ` Andy Shevchenko
2018-01-02 19:08 ` [PATCH v2 03/10] Bluetooth: hci_bcm: Enable runtime PM despite absence of IRQ Lukas Wunner
2018-01-02 19:17   ` Hans de Goede
2018-01-02 23:36     ` Lukas Wunner
2018-01-03  8:07       ` Hans de Goede
2018-01-03 13:34         ` Lukas Wunner
2018-01-03 12:34       ` Marcel Holtmann
2018-01-03 13:22         ` Lukas Wunner
2018-01-03 13:29           ` Marcel Holtmann
2018-01-03 13:34             ` Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 10/10] Bluetooth: hci_bcm: Support Apple GPIO handling Lukas Wunner
2018-01-03 12:55   ` Marcel Holtmann
2018-01-03 16:12   ` Andy Shevchenko
2018-01-02 19:08 ` [PATCH v2 08/10] Bluetooth: hci_bcm: Document struct bcm_device Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 02/10] Bluetooth: hci_bcm: Mandate presence of shutdown and device wake GPIO Lukas Wunner
2018-01-03 12:55   ` Marcel Holtmann
2018-01-02 19:08 ` [PATCH v2 09/10] Bluetooth: hci_bcm: Handle errors properly Lukas Wunner
2018-01-03 16:08   ` Andy Shevchenko
2018-01-03 18:54     ` Lukas Wunner
2018-01-03 19:08       ` Andy Shevchenko
2018-01-02 19:08 ` [PATCH v2 01/10] Bluetooth: Depend on rather than select GPIOLIB Lukas Wunner
2018-01-03  7:52   ` Linus Walleij
2018-01-05 18:27   ` Marcel Holtmann
2018-01-02 19:08 ` [PATCH v2 05/10] Bluetooth: hci_bcm: Add helper to toggle device wake GPIO Lukas Wunner
2018-01-03 13:06   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1514916630.git.lukas@wunner.de \
    --to=lukas@wunner.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=danielroschka@phoenitydawn.de \
    --cc=frederic.danis.oss@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=johan.hedberg@gmail.com \
    --cc=leif.liddy@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=marcel@holtmann.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mxms@me.com \
    --cc=peteryuchuang@gmail.com \
    --cc=ronald@innovation.ch \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).