Linux bluetooth development
 help / color / mirror / Atom feed
From: Pauli Virtanen <pav@iki.fi>
To: linux-bluetooth@vger.kernel.org
Cc: Pauli Virtanen <pav@iki.fi>
Subject: [PATCH 0/2] Bluetooth: hci_sync: fix mesh adv timeout units
Date: Mon,  5 Oct 2026 21:13:53 +0300	[thread overview]
Message-ID: <cover.1791223958.git.pav@iki.fi> (raw)

For mesh advertisements = adv_info::mesh nonzero, the time units are
milliseconds instead of seconds like normally.

This was forgotten in hci_schedule_adv_instance_sync() and
hci_enable_ext_advertising_sync() which scheduled 1000x too large
timeouts.

Fix that. This is the cause for the mesh-tester "Mesh - Send cancel"
failures.

Since the timeout units depend on the adv type, make
hdev->adv_instance_timeout to just bool indicating if timeout is active
or not.

Triaged via LLM. I wrote the patches.

Assisted-by: opencode:qwen3.8-flash-next

Pauli Virtanen (2):
  Bluetooth: hci_sync: fix mesh adv timeout units
  Bluetooth: make hdev->adv_instance_timeout a boolean

 include/net/bluetooth/hci_core.h |  2 +-
 net/bluetooth/hci_core.c         |  6 +++---
 net/bluetooth/hci_sync.c         | 14 ++++++++------
 net/bluetooth/mgmt.c             |  2 +-
 4 files changed, 13 insertions(+), 11 deletions(-)

-- 
2.55.0


             reply	other threads:[~2026-10-05 18:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 18:13 Pauli Virtanen [this message]
2026-10-05 18:13 ` [PATCH 1/2] Bluetooth: hci_sync: fix mesh adv timeout units Pauli Virtanen
2026-10-06  2:18   ` bluez.test.bot
2026-10-05 18:13 ` [PATCH 2/2] Bluetooth: make hdev->adv_instance_timeout a boolean Pauli Virtanen
2026-10-06 14:30 ` [PATCH 0/2] Bluetooth: hci_sync: fix mesh adv timeout units patchwork-bot+bluetooth
2026-10-06 15:00 ` patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1791223958.git.pav@iki.fi \
    --to=pav@iki.fi \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox