From: Tedd Ho-Jeong An <tedd.an@linux.intel.com>
To: Brian Gix <brian.gix@intel.com>, linux-bluetooth@vger.kernel.org
Cc: inga.stotland@intel.com
Subject: Re: [PATCH BlueZ v2 1/5] mesh: Fix delivery of PB-ACK to acceptors
Date: Wed, 19 May 2021 11:30:44 -0700 [thread overview]
Message-ID: <d09fc978849b33606d169a24f7405b31e334b066.camel@linux.intel.com> (raw)
In-Reply-To: <20210519182150.1680987-2-brian.gix@intel.com>
Hi Brian,
On Wed, 2021-05-19 at 11:21 -0700, Brian Gix wrote:
> Rwmove unneeded initialization that prevented the Acceptor roll of ever
Normally checkpatch.pl is good at catching a typo but it couldn't catch "Rwmove".
> recognizing a valid PB-ACK.
> ---
> mesh/pb-adv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c
> index c74dae79f..83f922aa8 100644
> --- a/mesh/pb-adv.c
> +++ b/mesh/pb-adv.c
> @@ -358,7 +358,6 @@ static void pb_adv_packet(void *user_data, const uint8_t *pkt, uint16_t len)
> first = !session->link_id;
> session->link_id = link_id;
> session->last_peer_trans_num = 0xFF;
> - session->local_acked = 0xFF;
> session->peer_trans_num = 0x00;
> session->local_trans_num = 0x7F;
> session->opened = true;
Regards,
Tedd
next prev parent reply other threads:[~2021-05-19 18:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 18:21 [PATCH BlueZ v2 0/5] OOB Authentication improvements Brian Gix
2021-05-19 18:21 ` [PATCH BlueZ v2 1/5] mesh: Fix delivery of PB-ACK to acceptors Brian Gix
2021-05-19 18:30 ` Tedd Ho-Jeong An [this message]
2021-05-19 18:33 ` Gix, Brian
2021-05-19 19:01 ` OOB Authentication improvements bluez.test.bot
2021-05-19 18:21 ` [PATCH BlueZ v2 2/5] nesh: Normalize endian of public/private ECC keys Brian Gix
2021-05-19 18:21 ` [PATCH BlueZ v2 3/5] tools/mesh: Add all supported OOB methods to cfgclient Brian Gix
2021-05-19 18:21 ` [PATCH BlueZ v2 4/5] test/mesh: Add support for testing more OOB auth Brian Gix
2021-05-19 18:21 ` [PATCH BlueZ v2 5/5] mesh: Add single threading to prov-acp ob messaging Brian Gix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d09fc978849b33606d169a24f7405b31e334b066.camel@linux.intel.com \
--to=tedd.an@linux.intel.com \
--cc=brian.gix@intel.com \
--cc=inga.stotland@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).