Re: [PATCH v2] Bluetooth: btusb: Add support for Intel Otter Peak2 (OrP2)

[Paul Menzel <pmenzel@molgen.mpg.de>]

Dear Catherine,


Thank you for v2. In the summary, I’d add a space in *Otter Peak 2* 
before the 2.

Am 02.09.26 um 21:00 schrieb Catherine L:
> $ lsusb
> Bus 003 Device 003: ID 8087:0043 Intel Corp.
> 
> $ cat /sys/kernel/debug/usb/devices
> T:  Bus=03 Lev=01 Prnt=01 Port=09 Cnt=02 Dev#=  3 Spd=12   MxCh= 0
> D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=8087 ProdID=0043 Rev= 0.00
> C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
> I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=81(I) Atr=03(Int.) MxPS=  64 Ivl=1ms
> E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
> E:  Ad=82(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> 
> Signed-off-by: Catherine L <catherine.l@intel.com>
> ---
> Changes in v2:
>   - Fixed review comments of v1 and changed name format.
> ---
>   drivers/bluetooth/btusb.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 03039ceaa77d..3e9db818a740 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -488,6 +488,7 @@ static const struct usb_device_id quirks_table[] = {
>   	{ USB_DEVICE(0x8087, 0x0037), .driver_info = BTUSB_INTEL_COMBINED },
>   	{ USB_DEVICE(0x8087, 0x0038), .driver_info = BTUSB_INTEL_COMBINED },
>   	{ USB_DEVICE(0x8087, 0x0039), .driver_info = BTUSB_INTEL_COMBINED },
> +	{ USB_DEVICE(0x8087, 0x0043), .driver_info = BTUSB_INTEL_COMBINED }, /* Otter Peak 2 */
>   	{ USB_DEVICE(0x8087, 0x0040), .driver_info = BTUSB_INTEL_COMBINED }, /* Lizard Peak 2 */

It’s still note sorted. 0x0043 should go after 0x0040.

Regarding the line length, the CI test passed, so the line length wasn’t 
complained about. Luiz needs to decide as maintainer. Maybe wait with 
sending v3 until his verdict.

>   	{ USB_DEVICE(0x8087, 0x07da), .driver_info = BTUSB_CSR },
>   	{ USB_DEVICE(0x8087, 0x07dc), .driver_info = BTUSB_INTEL_COMBINED |


Kind regards,

Paul


PS: It’s too many iterations for such a simple patch. What could have 
been done, that sorting would have been right from the beginning?