public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>,
	Kiran K <kiran.k@intel.com>
Cc: linux-bluetooth@vger.kernel.org,
	Ravishankar Srivatsa <ravishankar.srivatsa@intel.com>,
	"Tumkur Narayan, Chethan" <chethan.tumkur.narayan@intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v1] Bluetooth: btintel_pcie: Device suspend-resume support added
Date: Mon, 4 Nov 2024 10:44:08 +0100	[thread overview]
Message-ID: <d4561a55-1568-4290-aede-2e5f69009e5d@molgen.mpg.de> (raw)
In-Reply-To: <PH0PR11MB595244C38429E3AF6CAD73F6FC512@PH0PR11MB5952.namprd11.prod.outlook.com>


Dear Chandrashekar,


Am 04.11.24 um 10:18 schrieb Devegowda, Chandrashekar:

>       Thank you for the comments

Thank you for taking the time to address them.

>> -----Original Message-----
>> From: Paul Menzel <pmenzel@molgen.mpg.de>
>> Sent: Wednesday, October 23, 2024 12:49 PM

>> [Cc: +Bjorn, +linux-pci]

[…]

>> Am 23.10.24 um 13:46 schrieb ChandraShekar:
>>> This patch contains the changes in driver to support the suspend and
>>> resume i.e move the controller to D3 state when the platform is
>>> entering into suspend and move the controller to D0 on resume.
>>
>> It’d be great if you elaborated. Please start by the history, since when Intel
>> Bluetooth PCIe have been there, and why until now this support was missing.
> 
> The initial Intel bluetooth firmware supported only the FW download
> and Bluetooth Tx and Rx data flows ,further now the firmware has
> added support for vendor specific handshake during enter of D3 and
> D0 exit. So corresponding to FW changes this is the incremental
> changes from driver.

Interesting. Please also add the firmware versions to the commit message.

[…]

>> Is it also possible to use Bluetooth as a wakeup source from
>> suspend?
> 
> Yes BT device initiated wake up of the platform from suspend is
> possible, which will be enabled in the next patch

Great.

[…]

I am looking forward to the next iteration.


Kind regards,

Paul

  reply	other threads:[~2024-11-04  9:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 11:46 [PATCH v1] Bluetooth: btintel_pcie: Device suspend-resume support added ChandraShekar
2024-10-23  7:18 ` Paul Menzel
2024-10-23 19:19   ` Luiz Augusto von Dentz
2024-10-24  9:06   ` Ilpo Järvinen
2024-11-04  9:18   ` Devegowda, Chandrashekar
2024-11-04  9:44     ` Paul Menzel [this message]
2024-10-23 19:13 ` Bjorn Helgaas
2024-11-04  9:18   ` Devegowda, Chandrashekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4561a55-1568-4290-aede-2e5f69009e5d@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=bhelgaas@google.com \
    --cc=chandrashekar.devegowda@intel.com \
    --cc=chethan.tumkur.narayan@intel.com \
    --cc=kiran.k@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=ravishankar.srivatsa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox