public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: "Brad Midgley" <bmidgley@gmail.com>
To: "Siarhei Siamashka" <siarhei.siamashka@nokia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: SBC big endian issues?
Date: Mon, 5 Jan 2009 09:25:24 -0700	[thread overview]
Message-ID: <d89ddf300901050825h1654c869l22563783beeee7a8@mail.gmail.com> (raw)
In-Reply-To: <200901051755.29164.siarhei.siamashka@nokia.com>

Siarhei

> The logic is that the first line contains a portable endian neutral read of
> big endian data into native format:
>>                               s = (ptr[0] & 0xff) << 8 | (ptr[1] & 0xff);

the intent is to swap bytes using this first statement if either

- host order is little endian and the ptr array is stored big endian
- host order is big endian and the ptr array is stored little endian

the second case could be done with a cast to a 16-bit int rather than
bit arithmetic.

We don't exercise all the various cases.

-- 
Brad Midgley

  reply	other threads:[~2009-01-05 16:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-05  8:15 SBC big endian issues? Siarhei Siamashka
2009-01-05 15:36 ` Brad Midgley
2009-01-05 15:55   ` Siarhei Siamashka
2009-01-05 16:25     ` Brad Midgley [this message]
2009-01-05 16:29       ` Brad Midgley
2009-01-05 18:19       ` Siarhei Siamashka
2009-01-05 19:26         ` Brad Midgley
2009-01-07 12:40           ` Siarhei Siamashka
2009-01-07 13:43             ` Marcel Holtmann
2009-01-16 17:23               ` Siarhei Siamashka
2009-01-16 22:02                 ` Luiz Augusto von Dentz
2009-01-17 18:10                   ` Siarhei Siamashka
2009-01-19 11:26                     ` Siarhei Siamashka
2009-01-19 12:05                       ` Marcel Holtmann
2009-01-20  6:22                         ` [Patch] SAP client plugin framework Liu, Raymond
2009-01-22  5:05                           ` Liu, Raymond
2009-01-19 15:02                       ` SBC big endian issues? Brad Midgley
2009-01-20 10:20                         ` Siarhei Siamashka
2009-01-20 11:13             ` Siarhei Siamashka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d89ddf300901050825h1654c869l22563783beeee7a8@mail.gmail.com \
    --to=bmidgley@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=siarhei.siamashka@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox