linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian W MORRISON <ianwmorrison@gmail.com>
To: marcel@holtmann.org, gustavo@padovan.org,
	johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org
Cc: hdegoede@redhat.com, frederic.danis.oss@gmail.com
Subject: [PATCH] Bluetooth: hci_bcm: Correct context of IRQ polarity message
Date: Fri, 6 Oct 2017 18:34:30 +1100	[thread overview]
Message-ID: <d9ad3bdc-2f94-b3b1-1ec1-786999c1e529@gmail.com> (raw)

As the overwriting of IRQ polarity to active low occurs during the driver
probe using 'bt_dev_warn' to display the warning results in '(null)' 
being displayed for the device. This patch uses the underlying 'BT_INFO'
to directly display the warning instead.

Signed-off-by: ianwmorrison <ianwmorrison@gmail.com>
---
 drivers/bluetooth/hci_bcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 77326eeb6146..17c036599407 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -839,7 +839,7 @@ static int bcm_acpi_probe(struct bcm_device *dev)
 
 	dmi_id = dmi_first_match(bcm_active_low_irq_dmi_table);
 	if (dmi_id) {
-		bt_dev_warn(dev, "%s: Overwriting IRQ polarity to active low",
+		BT_INFO("%s: Overwriting IRQ polarity to active low",
 			    dmi_id->ident);
 		dev->irq_active_low = true;
 	}
-- 
2.11.0

             reply	other threads:[~2017-10-06  7:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06  7:34 Ian W MORRISON [this message]
2017-10-06 18:15 ` [PATCH] Bluetooth: hci_bcm: Correct context of IRQ polarity message Frédéric Danis
2017-10-06 18:26   ` Marcel Holtmann
2017-10-07  6:16     ` Ian W MORRISON

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9ad3bdc-2f94-b3b1-1ec1-786999c1e529@gmail.com \
    --to=ianwmorrison@gmail.com \
    --cc=frederic.danis.oss@gmail.com \
    --cc=gustavo@padovan.org \
    --cc=hdegoede@redhat.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).