From: Ian W MORRISON <ianwmorrison@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "Frédéric Danis" <frederic.danis.oss@gmail.com>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
"bluez mailin list (linux-bluetooth@vger.kernel.org)"
<linux-bluetooth@vger.kernel.org>,
hdegoede@redhat.com
Subject: Re: [PATCH] Bluetooth: hci_bcm: Correct context of IRQ polarity message
Date: Sat, 7 Oct 2017 17:16:15 +1100 [thread overview]
Message-ID: <e042f9f1-87c9-944c-3a79-f14b69347823@gmail.com> (raw)
In-Reply-To: <FDC710E6-4D82-487C-98AE-230DFD1F4032@holtmann.org>
On 10/7/17 5:26 AM, Marcel Holtmann wrote:
<snip>
>
> This should have been a dev_warn(dev->dev, ..) call actually.
>
> Regards
>
> Marcel
>
Hi Marcel,
I've changed the call to 'dev_warn' and issued as a revised patch.
Testing shows the following improvements using an extract from dmesg of the affected message:
Without patch:
[ 5.512175] Bluetooth: (null): MINIX Z83-4: Overwriting IRQ polarity to active low
v1 (superseded) patch:
[ 5.592238] Bluetooth: MINIX Z83-4: Overwriting IRQ polarity to active low
v2 patch (with a kernel excluding serdev ACPI support patches):
[ 6.112265] hci_bcm BCM2EA4:00: MINIX Z83-4: Overwriting IRQ polarity to active low
v2 patch (with a kernel including serdev ACPI support patches):
[ 6.367829] hci_uart_bcm serial1-0: MINIX Z83-4: Overwriting IRQ polarity to active low
Regards,
Ian
prev parent reply other threads:[~2017-10-07 6:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 7:34 [PATCH] Bluetooth: hci_bcm: Correct context of IRQ polarity message Ian W MORRISON
2017-10-06 18:15 ` Frédéric Danis
2017-10-06 18:26 ` Marcel Holtmann
2017-10-07 6:16 ` Ian W MORRISON [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e042f9f1-87c9-944c-3a79-f14b69347823@gmail.com \
--to=ianwmorrison@gmail.com \
--cc=frederic.danis.oss@gmail.com \
--cc=gustavo@padovan.org \
--cc=hdegoede@redhat.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).