linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stotland, Inga" <inga.stotland@intel.com>
To: "michal.lowas-rzechonek@silvair.com" 
	<michal.lowas-rzechonek@silvair.com>,
	"Gix, Brian" <brian.gix@intel.com>
Cc: "jakub.witowski@silvair.com" <jakub.witowski@silvair.com>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>
Subject: Re: Was: mesh: Added ImportLocalNode call with its API --> Multiple Methods?
Date: Tue, 2 Jul 2019 05:43:44 +0000	[thread overview]
Message-ID: <ee594d462e6ca16ef9a0f5f0f46b614316afa86d.camel@intel.com> (raw)
In-Reply-To: <DEBB0CAA2616974FAE35E4B560B9A4376CBB4F18@ORSMSX103.amr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

Hi Brian, Michal, Jakub,

On Mon, 2019-07-01 at 08:57 -0700, Gix, Brian wrote:
> Hi Michal.
> 
> > > We can perhaps "Overload" this functionality by allowing a
> > > minimal
> > > JSON with only Prov Data parts, if we are looking for a
> > > Provisioning
> > > shortcut, and always requiring the ObjectManager calls fetch the
> > > Composition (if the JSON was minimal) and to Sanity check the
> > > Composition (if the JSON contains a fully developed/configured
> > > Migrated node).
> > 
> > Ok, that sounds better. We could start by implementing the
> > "Provisoining
> > shortcut" variant, and add full-blown migration when it's needed.
> > 
> > Would that be OK from your POV?
> 
> This would be OK for me.  How about Inga?
> 
> BR, 
> Brian


So what is the final versionof the ImportLocalNode() will look like?

uint64 token ImportLocalNode(object app_path, array{byte} uuid, string
config_data)

or

uint64 token ImportLocalNode(object app_path, array{byte} uuid, byte
config_data_type, string config_data)

where config_data_type indicates the format of config_data (json, xml,
etc)

A bit clunky, but, if we want to keep everything wrapped in one method
call, I don't see a way around this.

Also, my feeling is that app_path = NULL shuold be allowed. In this
case node/app configuration is incurred solely from config_data, daemon
will check for the presence of all the mandatory settings.
In case both app_path and fully fleshed config_data are provided, a
series of checks will need to be performed to validate the coherncy of
the configuration.

Best regards,
Inga
 


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3265 bytes --]

      reply	other threads:[~2019-07-02  5:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 14:38 [PATCH v2] mesh: Added ImportLocalNode call with its API Jakub Witowski
2019-06-26 17:01 ` Gix, Brian
2019-06-26 17:53   ` Stotland, Inga
2019-06-26 18:37     ` Jakub Witowski
     [not found]     ` <CAMCw4t3pXTbtt05RD694jzF_MNT_J9dcFMtA7iuD4ujZT9FDbg@mail.gmail.com>
     [not found]       ` <1561660267.7802.29.camel@intel.com>
2019-06-27 19:51         ` Was: mesh: Added ImportLocalNode call with its API --> Multiple Methods? michal.lowas-rzechonek
2019-06-28 14:29           ` Gix, Brian
2019-07-01  9:20             ` michal.lowas-rzechonek
2019-07-01 15:57               ` Gix, Brian
2019-07-02  5:43                 ` Stotland, Inga [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee594d462e6ca16ef9a0f5f0f46b614316afa86d.camel@intel.com \
    --to=inga.stotland@intel.com \
    --cc=brian.gix@intel.com \
    --cc=jakub.witowski@silvair.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=michal.lowas-rzechonek@silvair.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).