From: Bastien Nocera <hadess@hadess.net>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 1/2] adapter: Fix not using the correct setting
Date: Fri, 05 Mar 2021 08:34:50 +0100 [thread overview]
Message-ID: <eeb0cffb975efea34b4db00dcf92dd08c635dc8d.camel@hadess.net> (raw)
In-Reply-To: <20210304222448.3769100-1-luiz.dentz@gmail.com>
On Thu, 2021-03-04 at 14:24 -0800, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> set_mode shall use opcode to identify what setting are being changed
> rather then the mode.
What was the symptom of this bug?
> ---
> src/adapter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index 051c32753..f483cc827 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -631,7 +631,7 @@ static bool set_mode(struct btd_adapter *adapter,
> uint16_t opcode,
> memset(&cp, 0, sizeof(cp));
> cp.val = mode;
>
> - switch (mode) {
> + switch (opcode) {
> case MGMT_OP_SET_POWERED:
> setting = MGMT_SETTING_POWERED;
> break;
prev parent reply other threads:[~2021-03-05 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 22:24 [PATCH BlueZ 1/2] adapter: Fix not using the correct setting Luiz Augusto von Dentz
2021-03-04 22:24 ` [PATCH BlueZ 2/2] adapter: Return Busy error when setting is pending Luiz Augusto von Dentz
2021-03-04 22:38 ` [BlueZ,1/2] adapter: Fix not using the correct setting bluez.test.bot
2021-03-06 1:17 ` Luiz Augusto von Dentz
2021-03-06 10:10 ` Bastien Nocera
2021-03-05 7:34 ` Bastien Nocera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeb0cffb975efea34b4db00dcf92dd08c635dc8d.camel@hadess.net \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox