Linux bluetooth development
 help / color / mirror / Atom feed
From: angelab@codeaurora.org
To: "Marcel Holtmann" <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 0/4] Fix error reporting for SDP Requests
Date: Tue, 24 Aug 2010 15:55:47 -0700 (PDT)	[thread overview]
Message-ID: <f5a72626c821919cb059a7efc6e7fb9f.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <1282688488.6841.34.camel@localhost.localdomain>

Hi Marcel,

Section 4.4 of the Bluetooth Corev2.1 spec, states that the error code
shall be 0x04 when an invalid PDU size is received. BlueZ is returning
error code 0x03 for the following:
TP/SERVER/SS/BI-01-C  [PATCH 1/4]
TP/SERVER/SA/BI-03-C  [PATCH 2/4]
TP/SERVER/SSA/BI-02-C [PATCH 3/4]

For this test case I sent a bad search attribute request where the max
amount Of Attribute Data to return is 0, but blueZ fails to respond with
an error code. The "max amount of attribute data" field has to be set to a
minimum size of 0x0007 for the request to be valid.
TP/SERVER/SA/BI-02-C [PATCH 4/4]

Sincerely,
Angela Bartholomaus
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.




> Hi Angela,
>
>> Fixed the following issues revealed while performing bluez
>> qualification:
>> - Incorrect error code was being reported for requests with invalid PDU
>> size;
>> - No error was being reported if a request less than 0x07 was received.
>
> I never needed any of these fixes when doing qualification. So why do
> you? Please mention the test case numbers.
>
> Regards
>
> Marcel
>
>
>

  reply	other threads:[~2010-08-24 22:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-24 22:14 [PATCH 0/4] Fix error reporting for SDP Requests Angela Bartholomaus
2010-08-24 22:14 ` [PATCH 1/4] Send an Invalid PDU Size Error Response for Service Search Req Angela Bartholomaus
2010-08-24 22:14 ` [PATCH 2/4] Send an Invalid PDU Size Error Response for Service Attr Req Angela Bartholomaus
2010-08-24 22:14 ` [PATCH 3/4] Send an Invalid PDU Size Error Resp for Service Attr Search Req Angela Bartholomaus
2010-08-24 22:14 ` [PATCH 4/4] Send Invalid Syntax Error if Resp Size Less Than 0x07 Angela Bartholomaus
2010-08-24 22:21 ` [PATCH 0/4] Fix error reporting for SDP Requests Marcel Holtmann
2010-08-24 22:55   ` angelab [this message]
2010-08-24 23:15     ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5a72626c821919cb059a7efc6e7fb9f.squirrel@www.codeaurora.org \
    --to=angelab@codeaurora.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox