From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Vinicius Gomes <vinicius.gomes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org, ofono@ofono.org
Subject: Re: [PATCH 2/2] Implement HandsfreeGateway Interface
Date: Thu, 21 Jan 2010 19:25:19 -0200 [thread overview]
Message-ID: <fbf08281001211325g33b2828cve6dcd9201d83f558@mail.gmail.com> (raw)
In-Reply-To: <2a9506371001211320r6dc7958h5b0040cec6f79e4b@mail.gmail.com>
On Thu, Jan 21, 2010 at 7:20 PM, Vinicius Gomes
<vinicius.gomes@openbossa.org> wrote:
> Hi Gustavo,
>
> On Thu, Jan 21, 2010 at 5:31 PM, Gustavo F. Padovan
> <padovan@profusion.mobi> wrote:
>> + gw->sco = chan;
>> + g_io_channel_ref(chan);
>> +
>
> You must have forgotten to change this.
>
>> @@ -307,17 +565,15 @@ struct gateway *gateway_init(struct audio_device *dev)
>> {
>> struct gateway *gw;
>>
>> + gw = g_new0(struct gateway, 1);
>> +
>> if (!g_dbus_register_interface(dev->conn, dev->path,
>> AUDIO_GATEWAY_INTERFACE,
>> gateway_methods, gateway_signals,
>> NULL, dev, NULL))
>> return NULL;
>>
>
> Seems like gw is leaking if registration fails. Move it down a little, perhaps?
Sounds good. Thanks. :)
>
>> - debug("in gateway_init, dev is %p", dev);
>> - gw = g_new0(struct gateway, 1);
>> - gw->state = GATEWAY_STATE_DISCONNECTED;
>> return gw;
>> -
>> }
>>
>
>
> Cheers,
> --
> Vinicius Gomes
> INdT - Instituto Nokia de Tecnologia
>
--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
next prev parent reply other threads:[~2010-01-21 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 20:31 [PATCH 1/2] clean up audio/gateway.c Gustavo F. Padovan
2010-01-21 20:31 ` [PATCH 2/2] Implement HandsfreeGateway Interface Gustavo F. Padovan
2010-01-21 21:20 ` Vinicius Gomes
2010-01-21 21:25 ` Gustavo F. Padovan [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-02 21:41 [PATCH 1/2] clean up audio/gateway.c Gustavo F. Padovan
2010-02-02 21:41 ` [PATCH 2/2] Implement HandsfreeGateway Interface Gustavo F. Padovan
2010-01-20 19:58 [RFC] HFP support into oFono and BlueZ Gustavo F. Padovan
2010-01-27 19:12 ` HFP support into BlueZ and oFono Gustavo F. Padovan
2010-01-27 19:12 ` [PATCH 1/2] clean up audio/gateway.c Gustavo F. Padovan
2010-01-27 19:12 ` [PATCH 2/2] Implement HandsfreeGateway Interface Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbf08281001211325g33b2828cve6dcd9201d83f558@mail.gmail.com \
--to=padovan@profusion.mobi \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ofono@ofono.org \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).