From: Schspa Shi <schspa@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
syzbot <syzbot+243b7d89777f90f7613b@syzkaller.appspotmail.com>,
syzkaller-bugs@googlegroups.com,
Lai Jiangshan <jiangshanlai@gmail.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: use hdev->workqueue when queuing hdev->{cmd,ncmd}_timer works
Date: Mon, 05 Sep 2022 16:24:06 +0800 [thread overview]
Message-ID: <m2wnaixlwy.fsf@gmail.com> (raw)
In-Reply-To: <YxQLig28YbtjCVH+@slm.duckdns.org>
Tejun Heo <tj@kernel.org> writes:
> Hello,
>
> On Sat, Sep 03, 2022 at 07:11:18PM -0700, Luiz Augusto von Dentz wrote:
>> And we can check for __WQ_DRAINING? Anyway checking
>
> Please don't do that. That's an internal flag. It shouldn't be *that*
> difficult to avoid this without peeking into wq internal state.
>
> Thanks.
It seems we only need to change hdev->{cmd,ncmd}_timer to
hdev->workqueue, there will be no race because drain_workqueue will
flush all pending work internally.
Any new timeout work will see HCI_CMD_DRAIN_WORKQUEUE flags after we
cancel and flushed all the delayed work.
--
BRs
Schspa Shi
next prev parent reply other threads:[~2022-09-05 8:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <00000000000016512d05e76bd837@google.com>
2022-08-30 14:08 ` [syzbot] upstream test error: WARNING in __queue_work Lai Jiangshan
2022-08-30 17:37 ` Luiz Augusto von Dentz
2022-09-02 12:28 ` Aleksandr Nogikh
2022-09-02 11:23 ` [PATCH] Bluetooth: use hdev->workqueue when queuing hdev->{cmd,ncmd}_timer works Tetsuo Handa
2022-09-02 12:00 ` bluez.test.bot
2022-09-02 18:45 ` [PATCH] " Luiz Augusto von Dentz
2022-09-02 21:31 ` Luiz Augusto von Dentz
2022-09-03 6:49 ` Tetsuo Handa
2022-09-04 2:11 ` Luiz Augusto von Dentz
2022-09-04 2:20 ` Tejun Heo
2022-09-05 8:24 ` Schspa Shi [this message]
2022-09-05 11:23 ` Tetsuo Handa
2022-09-05 12:26 ` Schspa Shi
2022-09-19 17:30 ` patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wnaixlwy.fsf@gmail.com \
--to=schspa@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=syzbot+243b7d89777f90f7613b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox