* [PATCH 10/17] Net: irda: irlan: Makefile: Remove deprecated kbuild goal definitions
From: Tracey Dent @ 2010-11-22 1:03 UTC (permalink / raw)
To: davem
Cc: marcel, padovan, linux-bluetooth, netdev, sjur.brandeland,
socketcan, urs.thuermann, socketcan-core, sage, ceph-devel,
wang840925, jlayton, kaber, pekkas, linux-kernel, netfilter-devel,
netfilter, samuel, Tracey Dent
In-Reply-To: <1290387808-2239-1-git-send-email-tdent48227@gmail.com>
Changed Makefile to use <modules>-y instead of <modules>-objs
because -objs is deprecated and not mentioned in
Documentation/kbuild/makefiles.txt.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
net/irda/irlan/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/irda/irlan/Makefile b/net/irda/irlan/Makefile
index 77549bc..94eefbc 100644
--- a/net/irda/irlan/Makefile
+++ b/net/irda/irlan/Makefile
@@ -4,4 +4,4 @@
obj-$(CONFIG_IRLAN) += irlan.o
-irlan-objs := irlan_common.o irlan_eth.o irlan_event.o irlan_client.o irlan_provider.o irlan_filter.o irlan_provider_event.o irlan_client_event.o
+irlan-y := irlan_common.o irlan_eth.o irlan_event.o irlan_client.o irlan_provider.o irlan_filter.o irlan_provider_event.o irlan_client_event.o
--
1.7.3.2.245.g03276
^ permalink raw reply related
* [PATCH 09/17] Net: irda: ircomm: Makefile: Remove deprecated kbuild goal defintions
From: Tracey Dent @ 2010-11-22 1:03 UTC (permalink / raw)
To: davem
Cc: marcel, padovan, linux-bluetooth, netdev, sjur.brandeland,
socketcan, urs.thuermann, socketcan-core, sage, ceph-devel,
wang840925, jlayton, kaber, pekkas, linux-kernel, netfilter-devel,
netfilter, samuel, Tracey Dent
In-Reply-To: <1290387808-2239-1-git-send-email-tdent48227@gmail.com>
Changed Makefile to use <modules>-y instead of <modules>-objs
because -objs is deprecated and not mentioned in
Documentation/kbuild/makefiles.txt.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
net/irda/ircomm/Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/irda/ircomm/Makefile b/net/irda/ircomm/Makefile
index 4868945..ab23b5b 100644
--- a/net/irda/ircomm/Makefile
+++ b/net/irda/ircomm/Makefile
@@ -4,5 +4,5 @@
obj-$(CONFIG_IRCOMM) += ircomm.o ircomm-tty.o
-ircomm-objs := ircomm_core.o ircomm_event.o ircomm_lmp.o ircomm_ttp.o
-ircomm-tty-objs := ircomm_tty.o ircomm_tty_attach.o ircomm_tty_ioctl.o ircomm_param.o
+ircomm-y := ircomm_core.o ircomm_event.o ircomm_lmp.o ircomm_ttp.o
+ircomm-tty-y := ircomm_tty.o ircomm_tty_attach.o ircomm_tty_ioctl.o ircomm_param.o
--
1.7.3.2.245.g03276
^ permalink raw reply related
* [PATCH 08/17] Net: ipv6: netfiliter: Makefile: Remove deprecated kbuild goal definitions
From: Tracey Dent @ 2010-11-22 1:03 UTC (permalink / raw)
To: davem
Cc: marcel, padovan, linux-bluetooth, netdev, sjur.brandeland,
socketcan, urs.thuermann, socketcan-core, sage, ceph-devel,
wang840925, jlayton, kaber, pekkas, linux-kernel, netfilter-devel,
netfilter, samuel, Tracey Dent
In-Reply-To: <1290387808-2239-1-git-send-email-tdent48227@gmail.com>
Changed Makefile to use <modules>-y instead of <modules>-objs
because -objs is deprecated and not mentioned in
Documentation/kbuild/makefiles.txt.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
net/ipv6/netfilter/Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/netfilter/Makefile b/net/ipv6/netfilter/Makefile
index 0a432c9..abfee91 100644
--- a/net/ipv6/netfilter/Makefile
+++ b/net/ipv6/netfilter/Makefile
@@ -11,13 +11,13 @@ obj-$(CONFIG_IP6_NF_RAW) += ip6table_raw.o
obj-$(CONFIG_IP6_NF_SECURITY) += ip6table_security.o
# objects for l3 independent conntrack
-nf_conntrack_ipv6-objs := nf_conntrack_l3proto_ipv6.o nf_conntrack_proto_icmpv6.o
+nf_conntrack_ipv6-y := nf_conntrack_l3proto_ipv6.o nf_conntrack_proto_icmpv6.o
# l3 independent conntrack
obj-$(CONFIG_NF_CONNTRACK_IPV6) += nf_conntrack_ipv6.o nf_defrag_ipv6.o
# defrag
-nf_defrag_ipv6-objs := nf_defrag_ipv6_hooks.o nf_conntrack_reasm.o
+nf_defrag_ipv6-y := nf_defrag_ipv6_hooks.o nf_conntrack_reasm.o
obj-$(CONFIG_NF_DEFRAG_IPV6) += nf_defrag_ipv6.o
# matches
--
1.7.3.2.245.g03276
^ permalink raw reply related
* [PATCH 07/17] Net: ipv4: netfilter: Makefile: Remove deprecated kbuild goal definitions
From: Tracey Dent @ 2010-11-22 1:03 UTC (permalink / raw)
To: davem
Cc: marcel, padovan, linux-bluetooth, netdev, sjur.brandeland,
socketcan, urs.thuermann, socketcan-core, sage, ceph-devel,
wang840925, jlayton, kaber, pekkas, linux-kernel, netfilter-devel,
netfilter, samuel, Tracey Dent
In-Reply-To: <1290387808-2239-1-git-send-email-tdent48227@gmail.com>
Changed Makefile to use <modules>-y instead of <modules>-objs
because -objs is deprecated and not mentioned in
Documentation/kbuild/makefiles.txt.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
net/ipv4/netfilter/Makefile | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/netfilter/Makefile b/net/ipv4/netfilter/Makefile
index 4811159..19eb59d 100644
--- a/net/ipv4/netfilter/Makefile
+++ b/net/ipv4/netfilter/Makefile
@@ -3,15 +3,15 @@
#
# objects for l3 independent conntrack
-nf_conntrack_ipv4-objs := nf_conntrack_l3proto_ipv4.o nf_conntrack_proto_icmp.o
+nf_conntrack_ipv4-y := nf_conntrack_l3proto_ipv4.o nf_conntrack_proto_icmp.o
ifeq ($(CONFIG_NF_CONNTRACK_PROC_COMPAT),y)
ifeq ($(CONFIG_PROC_FS),y)
nf_conntrack_ipv4-objs += nf_conntrack_l3proto_ipv4_compat.o
endif
endif
-nf_nat-objs := nf_nat_core.o nf_nat_helper.o nf_nat_proto_unknown.o nf_nat_proto_common.o nf_nat_proto_tcp.o nf_nat_proto_udp.o nf_nat_proto_icmp.o
-iptable_nat-objs := nf_nat_rule.o nf_nat_standalone.o
+nf_nat-y := nf_nat_core.o nf_nat_helper.o nf_nat_proto_unknown.o nf_nat_proto_common.o nf_nat_proto_tcp.o nf_nat_proto_udp.o nf_nat_proto_icmp.o
+iptable_nat-y := nf_nat_rule.o nf_nat_standalone.o
# connection tracking
obj-$(CONFIG_NF_CONNTRACK_IPV4) += nf_conntrack_ipv4.o
--
1.7.3.2.245.g03276
^ permalink raw reply related
* [PATCH 06/17] Net: econet: Makefile: Remove deprecated kbuild goal definitions
From: Tracey Dent @ 2010-11-22 1:03 UTC (permalink / raw)
To: davem
Cc: marcel, padovan, linux-bluetooth, netdev, sjur.brandeland,
socketcan, urs.thuermann, socketcan-core, sage, ceph-devel,
wang840925, jlayton, kaber, pekkas, linux-kernel, netfilter-devel,
netfilter, samuel, Tracey Dent
In-Reply-To: <1290387808-2239-1-git-send-email-tdent48227@gmail.com>
Changed Makefile to use <modules>-y instead of <modules>-objs
because -objs is deprecated and not mentioned in
Documentation/kbuild/makefiles.txt.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
net/econet/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/econet/Makefile b/net/econet/Makefile
index 39f0a77..05fae8b 100644
--- a/net/econet/Makefile
+++ b/net/econet/Makefile
@@ -4,4 +4,4 @@
obj-$(CONFIG_ECONET) += econet.o
-econet-objs := af_econet.o
+econet-y := af_econet.o
--
1.7.3.2.245.g03276
^ permalink raw reply related
* [PATCH 05/17] Net: dns_resolver: Makefile: Remove deprecated kbuild goal definitions
From: Tracey Dent @ 2010-11-22 1:03 UTC (permalink / raw)
To: davem
Cc: marcel, padovan, linux-bluetooth, netdev, sjur.brandeland,
socketcan, urs.thuermann, socketcan-core, sage, ceph-devel,
wang840925, jlayton, kaber, pekkas, linux-kernel, netfilter-devel,
netfilter, samuel, Tracey Dent
In-Reply-To: <1290387808-2239-1-git-send-email-tdent48227@gmail.com>
Changed Makefile to use <modules>-y instead of <modules>-objs
because -objs is deprecated and not mentioned in
Documentation/kbuild/makefiles.txt.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
net/dns_resolver/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/dns_resolver/Makefile b/net/dns_resolver/Makefile
index c0ef4e7..d5c13c2 100644
--- a/net/dns_resolver/Makefile
+++ b/net/dns_resolver/Makefile
@@ -4,4 +4,4 @@
obj-$(CONFIG_DNS_RESOLVER) += dns_resolver.o
-dns_resolver-objs := dns_key.o dns_query.o
+dns_resolver-y := dns_key.o dns_query.o
--
1.7.3.2.245.g03276
^ permalink raw reply related
* [PATCH 04/17] Net: ceph: Makefile: remove deprecated kbuild goal definitions
From: Tracey Dent @ 2010-11-22 1:03 UTC (permalink / raw)
To: davem
Cc: marcel, padovan, linux-bluetooth, netdev, sjur.brandeland,
socketcan, urs.thuermann, socketcan-core, sage, ceph-devel,
wang840925, jlayton, kaber, pekkas, linux-kernel, netfilter-devel,
netfilter, samuel, Tracey Dent
In-Reply-To: <1290387808-2239-1-git-send-email-tdent48227@gmail.com>
Changed Makefile to use <modules>-y instead of <modules>-objs
because -objs is deprecated and not mentioned in
Documentation/kbuild/makefiles.txt.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
net/ceph/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ceph/Makefile b/net/ceph/Makefile
index aab1cab..153bdec 100644
--- a/net/ceph/Makefile
+++ b/net/ceph/Makefile
@@ -6,7 +6,7 @@ ifneq ($(KERNELRELEASE),)
obj-$(CONFIG_CEPH_LIB) += libceph.o
-libceph-objs := ceph_common.o messenger.o msgpool.o buffer.o pagelist.o \
+libceph-y := ceph_common.o messenger.o msgpool.o buffer.o pagelist.o \
mon_client.o \
osd_client.o osdmap.o crush/crush.o crush/mapper.o crush/hash.o \
debugfs.o \
--
1.7.3.2.245.g03276
^ permalink raw reply related
* [PATCH 03/17] Net: can: Makefile: Remove deprecated kbuild goal definitions
From: Tracey Dent @ 2010-11-22 1:03 UTC (permalink / raw)
To: davem
Cc: marcel, padovan, linux-bluetooth, netdev, sjur.brandeland,
socketcan, urs.thuermann, socketcan-core, sage, ceph-devel,
wang840925, jlayton, kaber, pekkas, linux-kernel, netfilter-devel,
netfilter, samuel, Tracey Dent
In-Reply-To: <1290387808-2239-1-git-send-email-tdent48227@gmail.com>
Changed Makefile to use <modules>-y instead of <modules>-objs
because -objs is deprecated and not mentioned in
Documentation/kbuild/makefiles.txt.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
net/can/Makefile | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/can/Makefile b/net/can/Makefile
index 9cd3c4b..2d3894b 100644
--- a/net/can/Makefile
+++ b/net/can/Makefile
@@ -3,10 +3,10 @@
#
obj-$(CONFIG_CAN) += can.o
-can-objs := af_can.o proc.o
+can-y := af_can.o proc.o
obj-$(CONFIG_CAN_RAW) += can-raw.o
-can-raw-objs := raw.o
+can-raw-y := raw.o
obj-$(CONFIG_CAN_BCM) += can-bcm.o
-can-bcm-objs := bcm.o
+can-bcm-y := bcm.o
--
1.7.3.2.245.g03276
^ permalink raw reply related
* [PATCH 02/17] Net: caif: Makefile: Remove deprecated items
From: Tracey Dent @ 2010-11-22 1:03 UTC (permalink / raw)
To: davem
Cc: marcel, padovan, linux-bluetooth, netdev, sjur.brandeland,
socketcan, urs.thuermann, socketcan-core, sage, ceph-devel,
wang840925, jlayton, kaber, pekkas, linux-kernel, netfilter-devel,
netfilter, samuel, Tracey Dent
In-Reply-To: <1290387808-2239-1-git-send-email-tdent48227@gmail.com>
Changed Makefile to use <modules>-y instead of <modules>-objs
because -objs is deprecated and not mentioned in
Documentation/kbuild/makefiles.txt.
Also, use the ccflags-$ flag instead of EXTRA_CFLAGS because EXTRA_CFLAGS is
deprecated and should now be switched.
Last but not least, took out if-conditionals.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
net/caif/Makefile | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/net/caif/Makefile b/net/caif/Makefile
index f87481f..9d38e40 100644
--- a/net/caif/Makefile
+++ b/net/caif/Makefile
@@ -1,8 +1,6 @@
-ifeq ($(CONFIG_CAIF_DEBUG),y)
-EXTRA_CFLAGS += -DDEBUG
-endif
+ccflags-$(CONFIG_CAIF_DEBUG) := -DDEBUG
-caif-objs := caif_dev.o \
+caif-y := caif_dev.o \
cfcnfg.o cfmuxl.o cfctrl.o \
cffrml.o cfveil.o cfdbgl.o\
cfserl.o cfdgml.o \
@@ -13,4 +11,4 @@ obj-$(CONFIG_CAIF) += caif.o
obj-$(CONFIG_CAIF_NETDEV) += chnl_net.o
obj-$(CONFIG_CAIF) += caif_socket.o
-export-objs := caif.o
+export-y := caif.o
--
1.7.3.2.245.g03276
^ permalink raw reply related
* [PATCH 01/17] Net: bluetooth: Makefile: Remove deprecated kbuild goal definitions
From: Tracey Dent @ 2010-11-22 1:03 UTC (permalink / raw)
To: davem
Cc: marcel, padovan, linux-bluetooth, netdev, sjur.brandeland,
socketcan, urs.thuermann, socketcan-core, sage, ceph-devel,
wang840925, jlayton, kaber, pekkas, linux-kernel, netfilter-devel,
netfilter, samuel, Tracey Dent
In-Reply-To: <1290387808-2239-1-git-send-email-tdent48227@gmail.com>
Changed Makefile to use <modules>-y instead of <modules>-objs
because -objs is deprecated and not mentioned in
Documentation/kbuild/makefiles.txt.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
net/bluetooth/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/Makefile b/net/bluetooth/Makefile
index d1e433f..7ca1f46 100644
--- a/net/bluetooth/Makefile
+++ b/net/bluetooth/Makefile
@@ -10,4 +10,4 @@ obj-$(CONFIG_BT_BNEP) += bnep/
obj-$(CONFIG_BT_CMTP) += cmtp/
obj-$(CONFIG_BT_HIDP) += hidp/
-bluetooth-objs := af_bluetooth.o hci_core.o hci_conn.o hci_event.o hci_sock.o hci_sysfs.o lib.o
+bluetooth-y := af_bluetooth.o hci_core.o hci_conn.o hci_event.o hci_sock.o hci_sysfs.o lib.o
--
1.7.3.2.245.g03276
^ permalink raw reply related
* [PATCH 00/00] Remove deprecated items from Makefiles
From: Tracey Dent @ 2010-11-22 1:03 UTC (permalink / raw)
To: davem
Cc: marcel, padovan, linux-bluetooth, netdev, sjur.brandeland,
socketcan, urs.thuermann, socketcan-core, sage, ceph-devel,
wang840925, jlayton, kaber, pekkas, linux-kernel, netfilter-devel,
netfilter, samuel
I changed Makefiles to use <modules>-y instead of <modules>-objs because -objs
is deprecated and not even mentioned in Documentation/kbuild/makefiles.txt.
Also, remove some if-conditional statments because I used the ccflags-$ flag
instead of EXTRA_CFLAGS because EXTRA_CFLAGS.
regards,
Tracey Dent
^ permalink raw reply
* Re: [PATCH] Remove parameter entered from the DisplayPasskey agent method
From: Jose Antonio Santos Cadenas @ 2010-11-21 19:38 UTC (permalink / raw)
To: Jose Antonio Santos Cadenas, linux-bluetooth
In-Reply-To: <20101121192538.GA12163@jh-x301>
Hi Johan,
2010/11/21 Johan Hedberg <johan.hedberg@gmail.com>:
> Hi Jose,
>
> On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote:
>> > On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote:
>> >> In the current method implementation the parameter is not used.
>> >> ---
>> >> doc/agent-api.txt | 5 +----
>> >> 1 files changed, 1 insertions(+), 4 deletions(-)
>> >
>> > Do you actually have a BT 2.1 keyboard to test this with?
>>
>> I'm lost, why do I need a BT keyboard?
>
> Because DisplayPasskey will only happen if the other side has
> KeyboardOnly as its SSP IO capability.
>
>> > The right fix
>> > is to fix the code and not the spec since we do want the UI to get the
>> > hints about entered characters.
>>
>> I also think that an other way to correct this is to change the code
>> to follow the specification, but as I see that the specification
>> didn't have changes since 2008 I thought that was an obsolete
>> documentation, because in the source code there is no reference to the
>> entered parameter. Have you got any suggestions about the better way
>> to add this parameter in order to follow the API in the documentation?
>> Nevertheless I'll have a deeper look to the code looking for hints.
>
> The third parameter is supposed to be bound to the Keypress Notification
> HCI event which should come when the remote side does a
> HCI_Send_Keypress_Notification HCI command (again only a keyboard would
> do something like this).
Thanks for the explanation now I understand the use of the method.
Unfortunately right now I don't have a 2.1 keyboard so I can't test
it.
>
> Johan
>
Jose.
^ permalink raw reply
* Re: [PATCH] Remove parameter entered from the DisplayPasskey agent method
From: Johan Hedberg @ 2010-11-21 19:25 UTC (permalink / raw)
To: Jose Antonio Santos Cadenas; +Cc: linux-bluetooth
In-Reply-To: <AANLkTi=_BVKOptuGTz8eoHPaTQrkr6-3oCK8mzJq4oea@mail.gmail.com>
Hi Jose,
On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote:
> > On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote:
> >> In the current method implementation the parameter is not used.
> >> ---
> >> doc/agent-api.txt | 5 +----
> >> 1 files changed, 1 insertions(+), 4 deletions(-)
> >
> > Do you actually have a BT 2.1 keyboard to test this with?
>
> I'm lost, why do I need a BT keyboard?
Because DisplayPasskey will only happen if the other side has
KeyboardOnly as its SSP IO capability.
> > The right fix
> > is to fix the code and not the spec since we do want the UI to get the
> > hints about entered characters.
>
> I also think that an other way to correct this is to change the code
> to follow the specification, but as I see that the specification
> didn't have changes since 2008 I thought that was an obsolete
> documentation, because in the source code there is no reference to the
> entered parameter. Have you got any suggestions about the better way
> to add this parameter in order to follow the API in the documentation?
> Nevertheless I'll have a deeper look to the code looking for hints.
The third parameter is supposed to be bound to the Keypress Notification
HCI event which should come when the remote side does a
HCI_Send_Keypress_Notification HCI command (again only a keyboard would
do something like this).
Johan
^ permalink raw reply
* Re: [PATCH] Remove parameter entered from the DisplayPasskey agent method
From: Jose Antonio Santos Cadenas @ 2010-11-21 16:07 UTC (permalink / raw)
To: Jose Antonio Santos Cadenas, linux-bluetooth
In-Reply-To: <20101121131442.GA22320@jh-x301>
Hi Johan,
2010/11/21 Johan Hedberg <johan.hedberg@gmail.com>:
> Hi Jose,
>
> On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote:
>> In the current method implementation the parameter is not used.
>> ---
>> doc/agent-api.txt | 5 +----
>> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> Do you actually have a BT 2.1 keyboard to test this with?
I'm lost, why do I need a BT keyboard?
> The right fix
> is to fix the code and not the spec since we do want the UI to get the
> hints about entered characters.
I also think that an other way to correct this is to change the code
to follow the specification, but as I see that the specification
didn't have changes since 2008 I thought that was an obsolete
documentation, because in the source code there is no reference to the
entered parameter. Have you got any suggestions about the better way
to add this parameter in order to follow the API in the documentation?
Nevertheless I'll have a deeper look to the code looking for hints.
>
> Johan
>
Regards.
Jose.
^ permalink raw reply
* [PATCH] Fix error handling for l2cap_init()
From: Anderson Lizardo @ 2010-11-21 15:13 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Anderson Lizardo
create_singlethread_workqueue() may fail with errors such as -ENOMEM. If
this happens, the return value is not set to a negative value and the
module load will succeed. It will then crash on module unload because of
a destroy_workqueue() call on a NULL pointer.
Additionally, the _busy_wq workqueue is not being destroyed if any
errors happen on l2cap_init().
Signed-off-by: Anderson Lizardo <anderson.lizardo@openbossa.org>
---
net/bluetooth/l2cap.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
index 18a802c..7980e24 100644
--- a/net/bluetooth/l2cap.c
+++ b/net/bluetooth/l2cap.c
@@ -4875,8 +4875,10 @@ static int __init l2cap_init(void)
return err;
_busy_wq = create_singlethread_workqueue("l2cap");
- if (!_busy_wq)
- goto error;
+ if (!_busy_wq) {
+ err = -ENOMEM;
+ goto error_busy_wq;
+ }
err = bt_sock_register(BTPROTO_L2CAP, &l2cap_sock_family_ops);
if (err < 0) {
@@ -4904,6 +4906,8 @@ static int __init l2cap_init(void)
return 0;
error:
+ destroy_workqueue(_busy_wq);
+error_busy_wq:
proto_unregister(&l2cap_proto);
return err;
}
--
1.7.0.4
^ permalink raw reply related
* Re: [PATCH] Remove parameter entered from the DisplayPasskey agent method
From: Johan Hedberg @ 2010-11-21 13:14 UTC (permalink / raw)
To: Jose Antonio Santos Cadenas; +Cc: linux-bluetooth
In-Reply-To: <1290343578-986-1-git-send-email-santoscadenas@gmail.com>
Hi Jose,
On Sun, Nov 21, 2010, Jose Antonio Santos Cadenas wrote:
> In the current method implementation the parameter is not used.
> ---
> doc/agent-api.txt | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
Do you actually have a BT 2.1 keyboard to test this with? The right fix
is to fix the code and not the spec since we do want the UI to get the
hints about entered characters.
Johan
^ permalink raw reply
* [PATCH] Remove parameter entered from the DisplayPasskey agent method
From: Jose Antonio Santos Cadenas @ 2010-11-21 12:46 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Jose Antonio Santos Cadenas
In the current method implementation the parameter is not used.
---
doc/agent-api.txt | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/doc/agent-api.txt b/doc/agent-api.txt
index d8d35c0..1ddd290 100644
--- a/doc/agent-api.txt
+++ b/doc/agent-api.txt
@@ -42,14 +42,11 @@ Methods void Release()
Possible errors: org.bluez.Error.Rejected
org.bluez.Error.Canceled
- void DisplayPasskey(object device, uint32 passkey, uint8 entered)
+ void DisplayPasskey(object device, uint32 passkey)
This method gets called when the service daemon
needs to display a passkey for an authentication.
- The entered parameter indicates the number of already
- typed keys on the remote side.
-
An empty reply should be returned. When the passkey
needs no longer to be displayed, the Cancel method
of the agent will be called.
--
1.7.1
^ permalink raw reply related
* RE: [PATCH v2] Implement Characteristic Value Read using UUID in the gatttool
From: Mike Tsai @ 2010-11-20 1:36 UTC (permalink / raw)
To: Sheldon Demario, linux-bluetooth@vger.kernel.org
In-Reply-To: <1290173697-20097-1-git-send-email-sheldon.demario@openbossa.org>
Hi Sheldon,
-----Original Message-----
From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-owner@vger.kernel.org] On Behalf Of Sheldon Demario
Sent: Friday, November 19, 2010 5:35 AM
To: linux-bluetooth@vger.kernel.org
Cc: Sheldon Demario
Subject: [PATCH v2] Implement Characteristic Value Read using UUID in the gatttool
Sub-procedure used to read a Characteristic Value when the client
only knows the characteristic UUID and doesn't know the handle.
More than one handle and attribute value pair can be returned,
it is up to the user define the handles range based on the service
handles range.
Usage example:
$gatttool --char-read --uuid=2a00 -i hcix -b xx:xx:xx:xx:xx:xx
---
attrib/gatt.c | 15 ++++++++++++---
attrib/gatt.h | 4 ++++
attrib/gatttool.c | 39 +++++++++++++++++++++++++++++++++++++++
3 files changed, 55 insertions(+), 3 deletions(-)
diff --git a/attrib/gatt.c b/attrib/gatt.c
index 2c87daf..bca8b49 100644
--- a/attrib/gatt.c
+++ b/attrib/gatt.c
@@ -74,13 +74,22 @@ guint gatt_discover_primary(GAttrib *attrib, uint16_t start, uint16_t end,
guint gatt_discover_char(GAttrib *attrib, uint16_t start, uint16_t end,
GAttribResultFunc func, gpointer user_data)
{
- uint8_t pdu[ATT_DEFAULT_MTU];
uuid_t uuid;
- guint16 plen;
sdp_uuid16_create(&uuid, GATT_CHARAC_UUID);
- plen = enc_read_by_type_req(start, end, &uuid, pdu, sizeof(pdu));
+ return gatt_read_char_by_uuid(attrib, start, end, &uuid, func,
+ user_data);
+}
+
+guint gatt_read_char_by_uuid(GAttrib *attrib, uint16_t start, uint16_t end,
+ uuid_t *uuid, GAttribResultFunc func,
+ gpointer user_data)
+{
+ uint8_t pdu[ATT_DEFAULT_MTU];
+ guint16 plen;
+
+ plen = enc_read_by_type_req(start, end, uuid, pdu, sizeof(pdu));
if (plen == 0)
return 0;
diff --git a/attrib/gatt.h b/attrib/gatt.h
index 4e7d88b..1e1e628 100644
--- a/attrib/gatt.h
+++ b/attrib/gatt.h
@@ -41,3 +41,7 @@ guint gatt_find_info(GAttrib *attrib, uint16_t start, uint16_t end,
guint gatt_write_cmd(GAttrib *attrib, uint16_t handle, uint8_t *value, int vlen,
GDestroyNotify notify, gpointer user_data);
+
+guint gatt_read_char_by_uuid(GAttrib *attrib, uint16_t start, uint16_t end,
+ uuid_t *uuid, GAttribResultFunc func,
+ gpointer user_data);
diff --git a/attrib/gatttool.c b/attrib/gatttool.c
index e961431..d0ef6d3 100644
--- a/attrib/gatttool.c
+++ b/attrib/gatttool.c
@@ -398,10 +398,49 @@ done:
g_main_loop_quit(event_loop);
}
+static void char_read_by_uuid_cb(guint8 status, const guint8 *pdu,
+ guint16 plen, gpointer user_data)
+{
+ struct att_data_list *list;
+ int i;
+
+ if (status != 0) {
+ g_printerr("Read characteristics by UUID failed: %s\n",
+ att_ecode2str(status));
+ goto done;
+ }
+
+ list = dec_read_by_type_resp(pdu, plen);
+ if (list == NULL)
+ goto done;
+
+ for (i = 0; i < list->num; i++) {
+ uint8_t *value = list->data[i];
+ int j;
+
+ g_print("handle: 0x%04x \t value: ", att_get_u16(value));
+ value += 2;
+ for (j = 0; j < list->len - 2; j++, value++)
+ g_print("%02x ", *value);
+ g_print("\n");
+ }
+
+ att_data_list_free(list);
+
+done:
+ g_main_loop_quit(event_loop);
+}
+
[MTsai] in your call back function here, you assume that "read_by_type_request" operation has completed. In the case of example with uuid=0x2a00 (device name), this is probably true. However, if there are multiple characteristics with same UUID within the database, then server probably has not sent all the characteristic value back yet, shall you check to see if the reading is really completed (comparing the handle), otherwise, issue another read_by_type_request with starting handle = attribute handle+1?
static gboolean characteristics_read(gpointer user_data)
{
GAttrib *attrib = user_data;
+ if (opt_uuid != NULL) {
+ gatt_read_char_by_uuid(attrib, opt_start, opt_end, opt_uuid,
+ char_read_by_uuid_cb, attrib);
+ return FALSE;
+ }
+
if (opt_handle <= 0) {
g_printerr("A valid handle is required\n");
g_main_loop_quit(event_loop);
--
1.7.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* RE: [PATCH v2] Implement Characteristic Value Read using UUID in the gatttool
From: Mike Tsai @ 2010-11-20 0:49 UTC (permalink / raw)
To: Sheldon Demario, linux-bluetooth@vger.kernel.org
In-Reply-To: <1290173697-20097-1-git-send-email-sheldon.demario@openbossa.org>
Hi Sheldon,
-----Original Message-----
From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-owner@vger.kernel.org] On Behalf Of Sheldon Demario
Sent: Friday, November 19, 2010 5:35 AM
To: linux-bluetooth@vger.kernel.org
Cc: Sheldon Demario
Subject: [PATCH v2] Implement Characteristic Value Read using UUID in the gatttool
Sub-procedure used to read a Characteristic Value when the client
only knows the characteristic UUID and doesn't know the handle.
More than one handle and attribute value pair can be returned,
it is up to the user define the handles range based on the service
handles range.
Usage example:
$gatttool --char-read --uuid=2a00 -i hcix -b xx:xx:xx:xx:xx:xx
---
attrib/gatt.c | 15 ++++++++++++---
attrib/gatt.h | 4 ++++
attrib/gatttool.c | 39 +++++++++++++++++++++++++++++++++++++++
3 files changed, 55 insertions(+), 3 deletions(-)
diff --git a/attrib/gatt.c b/attrib/gatt.c
index 2c87daf..bca8b49 100644
--- a/attrib/gatt.c
+++ b/attrib/gatt.c
@@ -74,13 +74,22 @@ guint gatt_discover_primary(GAttrib *attrib, uint16_t start, uint16_t end,
guint gatt_discover_char(GAttrib *attrib, uint16_t start, uint16_t end,
GAttribResultFunc func, gpointer user_data)
{
- uint8_t pdu[ATT_DEFAULT_MTU];
uuid_t uuid;
- guint16 plen;
sdp_uuid16_create(&uuid, GATT_CHARAC_UUID);
- plen = enc_read_by_type_req(start, end, &uuid, pdu, sizeof(pdu));
+ return gatt_read_char_by_uuid(attrib, start, end, &uuid, func,
+ user_data);
+}
+
+guint gatt_read_char_by_uuid(GAttrib *attrib, uint16_t start, uint16_t end,
+ uuid_t *uuid, GAttribResultFunc func,
+ gpointer user_data)
+{
+ uint8_t pdu[ATT_DEFAULT_MTU];
+ guint16 plen;
+
+ plen = enc_read_by_type_req(start, end, uuid, pdu, sizeof(pdu));
if (plen == 0)
return 0;
diff --git a/attrib/gatt.h b/attrib/gatt.h
index 4e7d88b..1e1e628 100644
--- a/attrib/gatt.h
+++ b/attrib/gatt.h
@@ -41,3 +41,7 @@ guint gatt_find_info(GAttrib *attrib, uint16_t start, uint16_t end,
guint gatt_write_cmd(GAttrib *attrib, uint16_t handle, uint8_t *value, int vlen,
GDestroyNotify notify, gpointer user_data);
+
+guint gatt_read_char_by_uuid(GAttrib *attrib, uint16_t start, uint16_t end,
+ uuid_t *uuid, GAttribResultFunc func,
+ gpointer user_data);
diff --git a/attrib/gatttool.c b/attrib/gatttool.c
index e961431..d0ef6d3 100644
--- a/attrib/gatttool.c
+++ b/attrib/gatttool.c
@@ -398,10 +398,49 @@ done:
g_main_loop_quit(event_loop);
}
+static void char_read_by_uuid_cb(guint8 status, const guint8 *pdu,
+ guint16 plen, gpointer user_data)
+{
+ struct att_data_list *list;
+ int i;
+
+ if (status != 0) {
+ g_printerr("Read characteristics by UUID failed: %s\n",
+ att_ecode2str(status));
+ goto done;
+ }
+
+ list = dec_read_by_type_resp(pdu, plen);
+ if (list == NULL)
+ goto done;
+
+ for (i = 0; i < list->num; i++) {
+ uint8_t *value = list->data[i];
+ int j;
+
+ g_print("handle: 0x%04x \t value: ", att_get_u16(value));
+ value += 2;
+ for (j = 0; j < list->len - 2; j++, value++)
+ g_print("%02x ", *value);
+ g_print("\n");
+ }
+
+ att_data_list_free(list);
+
+done:
+ g_main_loop_quit(event_loop);
+}
+
[MTsai] in your call back function here, you assume that "read_by_type_request" operation has completed. In the case of example with uuid=0x2a00 (device name), this is probably true. However, if there are multiple characteristics with same UUID within the database, then server probably has not sent all the characteristic value back yet, shall you check to see if the reading is really completed (comparing the handle), otherwise, issue another read_by_type_request with starting handle = attribute handle+1?
static gboolean characteristics_read(gpointer user_data)
{
GAttrib *attrib = user_data;
+ if (opt_uuid != NULL) {
+ gatt_read_char_by_uuid(attrib, opt_start, opt_end, opt_uuid,
+ char_read_by_uuid_cb, attrib);
+ return FALSE;
+ }
+
if (opt_handle <= 0) {
g_printerr("A valid handle is required\n");
g_main_loop_quit(event_loop);
--
1.7.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* Re: [PATCH] Add command line option to change BCSP rate
From: Johan Hedberg @ 2010-11-19 19:44 UTC (permalink / raw)
To: Wade Brown; +Cc: linux-bluetooth@vger.kernel.org
In-Reply-To: <6EBC2ED6C3CFDC428167C1FF4764F0710A96D8BEB33E@SJEXBEC1.research.us.panasonic.com>
Hi Wade,
Btw, please don't top-post on this list.
On Fri, Nov 19, 2010, Wade Brown wrote:
> Sorry about that, I seem to be a bit behind the times. My git version
> is missing that feature, and evolution as a mail client seems to love
> attaching other bits. If this fails I'll work on updating my system
> and mail clients.
You need to send something I can give to git am, i.e. something formated
using git format-patch.
Johan
^ permalink raw reply
* RE: [PATCH] Add command line option to change BCSP rate
From: Wade Brown @ 2010-11-19 19:26 UTC (permalink / raw)
To: Johan Hedberg; +Cc: linux-bluetooth@vger.kernel.org
In-Reply-To: <20101119152346.GA28815@jh-x301>
[-- Attachment #1: Type: text/plain, Size: 1540 bytes --]
Johan,
Sorry about that, I seem to be a bit behind the times. My git version is missing that feature, and evolution as a mail client seems to love attaching other bits. If this fails I'll work on updating my system and mail clients.
--
Wade Brown
________________________________________
From: Johan Hedberg [johan.hedberg@gmail.com]
Sent: Friday, November 19, 2010 7:23 AM
To: Wade Brown
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Add command line option to change BCSP rate
Hi,
On Thu, Nov 18, 2010, Wade Brown wrote:
> Currently when using bccmd to do any communication, the UART is always
> opened at 38.4kbps. Once the CSR has been initialized to any other
> speed, bccmd can no longer communicate with with the radio (unless by
> resetting it through rfkill). This patch adds a -b option allowing a
> user to manually set a different speed, with the default 38400 still in
> place.
>
> Usage example:
> $bccmd -t BCSP -b 921600 -d /dev/ttyHS1 chiprev
>
> ---
> tools/bccmd.c | 45 ++++++++++++++++++++++++++++++++++++++++-----
> tools/csr.h | 3 ++-
> tools/csr_bcsp.c | 4 ++--
> 3 files changed, 44 insertions(+), 8 deletions(-)
The patch seems fine to me but I can't figure out how to apply it either
due to your mail client or your mail server. It's not sent inline and
the attachment isn't a complete git patch as such. Additionally there's
some strange winmail.dat attachment in the mail. Could you try resending
e.g. using git send-email?
Johan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: bccmd-set-bcsp-rate.patch --]
[-- Type: text/x-patch; name="bccmd-set-bcsp-rate.patch", Size: 4615 bytes --]
tools/bccmd.c | 45 ++++++++++++++++++++++++++++++++++++++++-----
tools/csr.h | 3 ++-
tools/csr_bcsp.c | 4 ++--
3 files changed, 44 insertions(+), 8 deletions(-)
diff --git a/tools/bccmd.c b/tools/bccmd.c
index 686e858..5cb9255 100644
--- a/tools/bccmd.c
+++ b/tools/bccmd.c
@@ -59,7 +59,7 @@
#define CSR_TYPE_ARRAY CSR_TYPE_COMPLEX
#define CSR_TYPE_BDADDR CSR_TYPE_COMPLEX
-static inline int transport_open(int transport, char *device)
+static inline int transport_open(int transport, char *device, speed_t bcsp_rate)
{
switch (transport) {
case CSR_TRANSPORT_HCI:
@@ -69,7 +69,7 @@ static inline int transport_open(int transport, char *device)
return csr_open_usb(device);
#endif
case CSR_TRANSPORT_BCSP:
- return csr_open_bcsp(device);
+ return csr_open_bcsp(device, bcsp_rate);
case CSR_TRANSPORT_H4:
return csr_open_h4(device);
case CSR_TRANSPORT_3WIRE:
@@ -1109,6 +1109,7 @@ static void usage(void)
printf("Options:\n"
"\t-t <transport> Select the transport\n"
"\t-d <device> Select the device\n"
+ "\t-b <bcsp rate> Select the bcsp transfer rate\n"
"\t-h, --help Display help\n"
"\n");
@@ -1137,6 +1138,7 @@ static void usage(void)
static struct option main_options[] = {
{ "transport", 1, 0, 't' },
{ "device", 1, 0, 'd' },
+ { "bcsprate", 1, 0, 'b'},
{ "help", 0, 0, 'h' },
{ 0, 0, 0, 0 }
};
@@ -1145,8 +1147,9 @@ int main(int argc, char *argv[])
{
char *device = NULL;
int i, err, opt, transport = CSR_TRANSPORT_HCI;
+ speed_t bcsp_rate = B38400;
- while ((opt=getopt_long(argc, argv, "+t:d:i:h", main_options, NULL)) != EOF) {
+ while ((opt=getopt_long(argc, argv, "+t:d:i:b:h", main_options, NULL)) != EOF) {
switch (opt) {
case 't':
if (!strcasecmp(optarg, "hci"))
@@ -1171,7 +1174,39 @@ int main(int argc, char *argv[])
case 'i':
device = strdup(optarg);
break;
-
+ case 'b':
+ switch (atoi(optarg)) {
+ case 9600: bcsp_rate = B9600; break;
+ case 19200: bcsp_rate = B19200; break;
+ case 38400: bcsp_rate = B38400; break;
+ case 57600: bcsp_rate = B57600; break;
+ case 115200: bcsp_rate = B115200; break;
+ case 230400: bcsp_rate = B230400; break;
+ case 460800: bcsp_rate = B460800; break;
+ case 500000: bcsp_rate = B500000; break;
+ case 576000: bcsp_rate = B576000; break;
+ case 921600: bcsp_rate = B921600; break;
+ case 1000000: bcsp_rate = B1000000; break;
+ case 1152000: bcsp_rate = B1152000; break;
+ case 1500000: bcsp_rate = B1500000; break;
+ case 2000000: bcsp_rate = B2000000; break;
+#ifdef B2500000
+ case 2500000: bcsp_rate = B2500000; break;
+#endif
+#ifdef B3000000
+ case 3000000: bcsp_rate = B3000000; break;
+#endif
+#ifdef B3500000
+ case 3500000: bcsp_rate = B3500000; break;
+#endif
+#ifdef B4000000
+ case 4000000: bcsp_rate = B4000000; break;
+#endif
+ default:
+ printf("Unknown BCSP baud rate specified, defaulting to 38400bps\n");
+ bcsp_rate = B38400;
+ }
+ break;
case 'h':
default:
usage();
@@ -1188,7 +1223,7 @@ int main(int argc, char *argv[])
exit(1);
}
- if (transport_open(transport, device) < 0)
+ if (transport_open(transport, device, bcsp_rate) < 0)
exit(1);
if (device)
diff --git a/tools/csr.h b/tools/csr.h
index 1d70491..8b94d7b 100644
--- a/tools/csr.h
+++ b/tools/csr.h
@@ -22,6 +22,7 @@
*/
#include <stdint.h>
+#include <termios.h>
#define CSR_VARID_PS_CLR_ALL 0x000b /* valueless */
#define CSR_VARID_PS_FACTORY_SET 0x000c /* valueless */
@@ -519,7 +520,7 @@ int csr_read_usb(uint16_t varid, uint8_t *value, uint16_t length);
int csr_write_usb(uint16_t varid, uint8_t *value, uint16_t length);
void csr_close_usb(void);
-int csr_open_bcsp(char *device);
+int csr_open_bcsp(char *device, speed_t bcsp_rate);
int csr_read_bcsp(uint16_t varid, uint8_t *value, uint16_t length);
int csr_write_bcsp(uint16_t varid, uint8_t *value, uint16_t length);
void csr_close_bcsp(void);
diff --git a/tools/csr_bcsp.c b/tools/csr_bcsp.c
index e551311..df247a2 100644
--- a/tools/csr_bcsp.c
+++ b/tools/csr_bcsp.c
@@ -46,7 +46,7 @@ static uint8_t send_buffer[512];
static struct ubcsp_packet receive_packet;
static uint8_t receive_buffer[512];
-int csr_open_bcsp(char *device)
+int csr_open_bcsp(char *device, speed_t bcsp_rate)
{
struct termios ti;
uint8_t delay, activity = 0x00;
@@ -84,7 +84,7 @@ int csr_open_bcsp(char *device)
ti.c_cc[VMIN] = 1;
ti.c_cc[VTIME] = 0;
- cfsetospeed(&ti, B38400);
+ cfsetospeed(&ti, bcsp_rate);
if (tcsetattr(fd, TCSANOW, &ti) < 0) {
fprintf(stderr, "Can't change port settings: %s (%d)\n",
^ permalink raw reply related
* Re: Pull request git://gitorious.org/~vudentz/bluez/vudentzs-clone.git for-upstream
From: Johan Hedberg @ 2010-11-19 16:50 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
In-Reply-To: <AANLkTimQB+-odX2Yw+gxrdd2SBajxZ3nswtffW+L-g9_@mail.gmail.com>
Hi Luiz,
On Fri, Nov 19, 2010, Luiz Augusto von Dentz wrote:
> Those changes fixes several issues when doing a Device.Disconnect
> while some audio profile is still connecting. I did some cleanups to
> make it easier to track references and reuse more code, and also did a
> lot o testing to make sure it doesn't cause any regression for cases
> where the client is using Media API or unix socket.
>
> The following changes since commit 55685d2037d33ed29ed7365150fd14b5326690fb:
>
> Fix minor typo (2010-11-19 17:39:15 +0200)
>
> are available in the git repository at:
> git://gitorious.org/~vudentz/bluez/vudentzs-clone.git for-upstream
>
> Luiz Augusto von Dentz (9):
> Cleanup a2dp setup code
> Cleanup a2dp_cancel code
> Fix not removing all timers when user request to disconnect audio
> Fix abort not being send when the state is idle
> Fix reference count of a2dp stream setup
> Add debug logs for state changes on sink
> Fix possible crashes when attempting to connect avdtp
> Fix not dropping avdtp session reference when cancelling stream setup
> Fix not indicating disconnected state when connecting to avdtp
>
> audio/a2dp.c | 258 +++++++++++++++++++++++++------------------------------
> audio/avdtp.c | 26 +++---
> audio/device.c | 36 ++++----
> audio/sink.c | 13 +++
> 4 files changed, 163 insertions(+), 170 deletions(-)
Thanks! The patches have been pushed upstream.
Johan
^ permalink raw reply
* Pull request git://gitorious.org/~vudentz/bluez/vudentzs-clone.git for-upstream
From: Luiz Augusto von Dentz @ 2010-11-19 16:31 UTC (permalink / raw)
To: linux-bluetooth
Hi,
Those changes fixes several issues when doing a Device.Disconnect
while some audio profile is still connecting. I did some cleanups to
make it easier to track references and reuse more code, and also did a
lot o testing to make sure it doesn't cause any regression for cases
where the client is using Media API or unix socket.
The following changes since commit 55685d2037d33ed29ed7365150fd14b5326690fb:
Fix minor typo (2010-11-19 17:39:15 +0200)
are available in the git repository at:
git://gitorious.org/~vudentz/bluez/vudentzs-clone.git for-upstream
Luiz Augusto von Dentz (9):
Cleanup a2dp setup code
Cleanup a2dp_cancel code
Fix not removing all timers when user request to disconnect audio
Fix abort not being send when the state is idle
Fix reference count of a2dp stream setup
Add debug logs for state changes on sink
Fix possible crashes when attempting to connect avdtp
Fix not dropping avdtp session reference when cancelling stream setup
Fix not indicating disconnected state when connecting to avdtp
audio/a2dp.c | 258 +++++++++++++++++++++++++------------------------------
audio/avdtp.c | 26 +++---
audio/device.c | 36 ++++----
audio/sink.c | 13 +++
4 files changed, 163 insertions(+), 170 deletions(-)
--
Luiz Augusto von Dentz
Computer Engineer
^ permalink raw reply
* Re: [PATCH v2 2/2] Avoid reallocations of services UUID array
From: Johan Hedberg @ 2010-11-19 15:30 UTC (permalink / raw)
To: Anderson Lizardo; +Cc: linux-bluetooth
In-Reply-To: <1290178759-9270-1-git-send-email-anderson.lizardo@openbossa.org>
Hi Anderson,
On Fri, Nov 19, 2010, Anderson Lizardo wrote:
> The array of service UUIDs used by the DeviceFound signal contains the
> same information from the GSList of services. Instead of reallocating
> this array on each signal, store it on the remote_dev_info structure and
> only reallocate it if there are new UUIDs.
> ---
> src/adapter.c | 18 +++++++++---------
> src/adapter.h | 3 ++-
> 2 files changed, 11 insertions(+), 10 deletions(-)
This one has also been pushed upstream. Thanks.
Johan
^ permalink raw reply
* Re: [PATCH 1/2] Merge service UUIDs from different BR/EDR EIR data
From: Johan Hedberg @ 2010-11-19 15:29 UTC (permalink / raw)
To: Anderson Lizardo; +Cc: linux-bluetooth
In-Reply-To: <1290178241-8358-1-git-send-email-anderson.lizardo@openbossa.org>
Hi Anderson,
On Fri, Nov 19, 2010, Anderson Lizardo wrote:
> For LE devices, service UUIDs present in advertising data are merged
> into a single list. This change makes the same thing for BR/EDR devices.
> ---
> src/adapter.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
Pushed upstream. Thanks.
Johan
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox