* [PATCH BlueZ v2 2/3] device: Rename start_discovery function
From: Simon Mikuda @ 2026-06-08 10:59 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
In-Reply-To: <20260608105952.3683040-1-simon.mikuda@streamunlimited.com>
Rename it to start_discovery_cb to indicate that it is callback function
from timer.
---
src/device.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/device.c b/src/device.c
index 0c2ee7d8d..da70f9cc0 100644
--- a/src/device.c
+++ b/src/device.c
@@ -7185,7 +7185,7 @@ bool device_is_connectable(struct btd_device *device)
return state->connectable;
}
-static bool start_discovery(gpointer user_data)
+static bool start_discovery_cb(gpointer user_data)
{
struct btd_device *device = user_data;
@@ -7364,7 +7364,7 @@ void device_bonding_complete(struct btd_device *device, uint8_t bdaddr_type,
DBG("setting timer for reverse service discovery");
device->discov_timer = timeout_add_seconds(
DISCOVERY_TIMER,
- start_discovery,
+ start_discovery_cb,
device, NULL);
}
}
@@ -7409,7 +7409,7 @@ unsigned int device_wait_for_svc_complete(struct btd_device *dev,
dev->discov_timer = timeout_add_seconds(
0,
- start_discovery,
+ start_discovery_cb,
dev, NULL);
}
--
2.43.0
^ permalink raw reply related
* [PATCH BlueZ v2 3/3] device: Fix returning discovery error for Device.Pair
From: Simon Mikuda @ 2026-06-08 10:59 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
In-Reply-To: <20260608105952.3683040-1-simon.mikuda@streamunlimited.com>
If discovery was requesed from pair request we will report successfull
pairing even if there was an error during discovery.
---
src/device.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/device.c b/src/device.c
index da70f9cc0..429fc5e6d 100644
--- a/src/device.c
+++ b/src/device.c
@@ -7294,6 +7294,7 @@ void device_bonding_complete(struct btd_device *device, uint8_t bdaddr_type,
struct bonding_req *bonding = device->bonding;
struct authentication_req *auth = device->authr;
struct bearer_state *state = get_state(device, bdaddr_type);
+ int err;
DBG("bonding %p status 0x%02x", bonding, status);
@@ -7352,8 +7353,16 @@ void device_bonding_complete(struct btd_device *device, uint8_t bdaddr_type,
DBG("Proceeding with service discovery");
/* If we are initiators remove any discovery timer and just
* start discovering services directly */
- device_discover_services(device, bdaddr_type, bonding->msg);
-
+ err = device_discover_services(device, bdaddr_type, bonding->msg);
+ if (err) {
+ if (device->pending_paired) {
+ g_dbus_emit_property_changed(dbus_conn, device->path,
+ DEVICE_INTERFACE, "Paired");
+ device->pending_paired = false;
+ }
+ /* Disregard browse errors in case of Pair */
+ g_dbus_send_reply(dbus_conn, bonding->msg, DBUS_TYPE_INVALID);
+ }
bonding_request_free(bonding);
} else if (!state->svc_resolved) {
if (!device->browse && !device->discov_timer &&
--
2.43.0
^ permalink raw reply related
* [PATCH BlueZ v3 1/3] device: Refactor device_discover_services function
From: Simon Mikuda @ 2026-06-08 11:07 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
In-Reply-To: <20260608103905.3614057-1-simon.mikuda@streamunlimited.com>
After refactoring we can reuse function once more in function
void device_bonding_complete(...)
---
profiles/input/server.c | 2 +-
src/adapter.c | 2 +-
src/device.c | 26 ++++++++------------------
src/device.h | 3 ++-
4 files changed, 12 insertions(+), 21 deletions(-)
diff --git a/profiles/input/server.c b/profiles/input/server.c
index 97579152e..93c73f8d2 100644
--- a/profiles/input/server.c
+++ b/profiles/input/server.c
@@ -102,7 +102,7 @@ static void sixaxis_browse_sdp(const bdaddr_t *src, const bdaddr_t *dst,
data->psm = psm;
if (psm == L2CAP_PSM_HIDP_CTRL)
- device_discover_services(device);
+ device_discover_services(device, BDADDR_BREDR, NULL);
device_wait_for_svc_complete(device, sixaxis_sdp_cb, data);
}
diff --git a/src/adapter.c b/src/adapter.c
index 03593d962..cc753fbd6 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -3717,7 +3717,7 @@ static void device_connect_cb(GIOChannel *io, GError *gerr, gpointer user_data)
device_attach_att(device, io);
}
- device_discover_services(device);
+ device_discover_services(device, data->dst_type, NULL);
g_io_channel_unref(io);
dbus_message_unref(data->msg);
diff --git a/src/device.c b/src/device.c
index bea893301..223e25102 100644
--- a/src/device.c
+++ b/src/device.c
@@ -2735,7 +2735,7 @@ int btd_device_connect_services(struct btd_device *dev, GSList *services)
if (!dev->bredr_state.svc_resolved) {
int err;
- err = device_discover_services(dev);
+ err = device_discover_services(dev, BDADDR_BREDR, NULL);
if (err)
return err;
@@ -2812,10 +2812,7 @@ DBusMessage *device_connect_profiles(struct btd_device *dev,
resolve_services:
DBG("Resolving services for %s", dev->path);
- if (bdaddr_type == BDADDR_BREDR)
- err = device_browse_sdp(dev, msg);
- else
- err = device_browse_gatt(dev, msg);
+ err = device_discover_services(dev, bdaddr_type, msg);
if (err < 0) {
return btd_error_failed(msg, bdaddr_type == BDADDR_BREDR ?
ERR_BREDR_CONN_SDP_SEARCH : ERR_LE_CONN_GATT_BROWSE);
@@ -6834,14 +6831,15 @@ void device_cancel_browse(struct btd_device *device, uint8_t bdaddr_type)
browse_request_free(device->browse);
}
-int device_discover_services(struct btd_device *device)
+int device_discover_services(struct btd_device *device,
+ uint8_t bdaddr_type, DBusMessage *msg)
{
int err;
- if (device->bredr)
- err = device_browse_sdp(device, NULL);
+ if (bdaddr_type == BDADDR_BREDR)
+ err = device_browse_sdp(device, msg);
else
- err = device_browse_gatt(device, NULL);
+ err = device_browse_gatt(device, msg);
if (err == 0 && device->discov_timer) {
timeout_remove(device->discov_timer);
@@ -7354,15 +7352,7 @@ void device_bonding_complete(struct btd_device *device, uint8_t bdaddr_type,
DBG("Proceeding with service discovery");
/* If we are initiators remove any discovery timer and just
* start discovering services directly */
- if (device->discov_timer) {
- timeout_remove(device->discov_timer);
- device->discov_timer = 0;
- }
-
- if (bdaddr_type == BDADDR_BREDR)
- device_browse_sdp(device, bonding->msg);
- else
- device_browse_gatt(device, bonding->msg);
+ device_discover_services(device, bdaddr_type, bonding->msg);
bonding_request_free(bonding);
} else if (!state->svc_resolved) {
diff --git a/src/device.h b/src/device.h
index b36f9af66..b890f23d4 100644
--- a/src/device.h
+++ b/src/device.h
@@ -207,7 +207,8 @@ bool device_remove_svc_complete_callback(struct btd_device *dev,
struct btd_service *btd_device_get_service(struct btd_device *dev,
const char *remote_uuid);
-int device_discover_services(struct btd_device *device);
+int device_discover_services(struct btd_device *device,
+ uint8_t bdaddr_type, DBusMessage *msg);
int btd_device_connect_services(struct btd_device *dev, GSList *services);
bool btd_device_flags_enabled(struct btd_device *dev, uint32_t flags);
--
2.43.0
^ permalink raw reply related
* [PATCH BlueZ v3 2/3] device: Rename start_discovery function
From: Simon Mikuda @ 2026-06-08 11:07 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
In-Reply-To: <20260608110743.3683728-1-simon.mikuda@streamunlimited.com>
Rename it to start_discovery_cb to indicate that it is callback function
from timer.
---
src/device.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/device.c b/src/device.c
index 223e25102..b0c1960ff 100644
--- a/src/device.c
+++ b/src/device.c
@@ -7185,7 +7185,7 @@ bool device_is_connectable(struct btd_device *device)
return state->connectable;
}
-static bool start_discovery(gpointer user_data)
+static bool start_discovery_cb(gpointer user_data)
{
struct btd_device *device = user_data;
@@ -7364,7 +7364,7 @@ void device_bonding_complete(struct btd_device *device, uint8_t bdaddr_type,
DBG("setting timer for reverse service discovery");
device->discov_timer = timeout_add_seconds(
DISCOVERY_TIMER,
- start_discovery,
+ start_discovery_cb,
device, NULL);
}
}
@@ -7409,7 +7409,7 @@ unsigned int device_wait_for_svc_complete(struct btd_device *dev,
dev->discov_timer = timeout_add_seconds(
0,
- start_discovery,
+ start_discovery_cb,
dev, NULL);
}
--
2.43.0
^ permalink raw reply related
* [PATCH BlueZ v3 3/3] device: Fix returning discovery error for Device.Pair
From: Simon Mikuda @ 2026-06-08 11:07 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
In-Reply-To: <20260608110743.3683728-1-simon.mikuda@streamunlimited.com>
If discovery was requesed from pair request we will report successfull
pairing even if there was an error during discovery.
---
src/device.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/device.c b/src/device.c
index b0c1960ff..5f9f7ca99 100644
--- a/src/device.c
+++ b/src/device.c
@@ -7294,6 +7294,7 @@ void device_bonding_complete(struct btd_device *device, uint8_t bdaddr_type,
struct bonding_req *bonding = device->bonding;
struct authentication_req *auth = device->authr;
struct bearer_state *state = get_state(device, bdaddr_type);
+ int err;
DBG("bonding %p status 0x%02x", bonding, status);
@@ -7352,8 +7353,16 @@ void device_bonding_complete(struct btd_device *device, uint8_t bdaddr_type,
DBG("Proceeding with service discovery");
/* If we are initiators remove any discovery timer and just
* start discovering services directly */
- device_discover_services(device, bdaddr_type, bonding->msg);
-
+ err = device_discover_services(device, bdaddr_type, bonding->msg);
+ if (err) {
+ if (device->pending_paired) {
+ g_dbus_emit_property_changed(dbus_conn, device->path,
+ DEVICE_INTERFACE, "Paired");
+ device->pending_paired = false;
+ }
+ /* Disregard browse errors in case of Pair */
+ g_dbus_send_reply(dbus_conn, bonding->msg, DBUS_TYPE_INVALID);
+ }
bonding_request_free(bonding);
} else if (!state->svc_resolved) {
if (!device->browse && !device->discov_timer &&
--
2.43.0
^ permalink raw reply related
* [PATCH BlueZ] adapter: Fix failed bonding attempt after LE link disconnection
From: Simon Mikuda @ 2026-06-08 11:10 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
What happens when issue occurs:
- device is connected to both bearers BR/EDR and LE
- bonding is requested
- LE link disconnects
- pairing keys arrive
BlueZ would finish bonding request with error and mark device as
temporary. Then it would be disconnected+removed after default
temporary timeout (30 seconds).
---
src/adapter.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/adapter.c b/src/adapter.c
index 03593d962..a08847663 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -8622,7 +8622,9 @@ static void dev_disconnected(struct btd_adapter *adapter,
disconnect_notify(device, reason);
}
- bonding_attempt_complete(adapter, &addr->bdaddr, addr->type,
+ /* device could be still connected to different bearer */
+ if (!btd_device_is_connected(device))
+ bonding_attempt_complete(adapter, &addr->bdaddr, addr->type,
MGMT_STATUS_DISCONNECTED);
}
--
2.43.0
^ permalink raw reply related
* Re: [PATCH v3 4/7] block: implement NVMEM provider
From: Bartosz Golaszewski @ 2026-06-08 11:17 UTC (permalink / raw)
To: Loic Poulain
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, linux-block,
linux-wireless, ath10k, linux-bluetooth, netdev, daniel,
Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Jens Axboe, Johannes Berg,
Jeff Johnson, Bartosz Golaszewski, Marcel Holtmann,
Luiz Augusto von Dentz, Balakrishna Godavarthi, Rocky Liao,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Srinivas Kandagatla, Andrew Lunn, Heiner Kallweit,
Russell King, Saravana Kannan
In-Reply-To: <20260608-block-as-nvmem-v3-4-82681f50aa35@oss.qualcomm.com>
On Mon, 8 Jun 2026 12:50:41 +0200, Loic Poulain
<loic.poulain@oss.qualcomm.com> said:
> From: Daniel Golle <daniel@makrotopia.org>
>
> On embedded devices using an eMMC it is common that one or more partitions
> on the eMMC are used to store MAC addresses and Wi-Fi calibration EEPROM
> data. Allow referencing the partition in device tree for the kernel and
> Wi-Fi drivers accessing it via the NVMEM layer.
>
> To safely defer the freeing of the provider private data until all
> consumers have released their cells, a nvmem_dev() accessor is added to
> the NVMEM core to expose the struct device embedded in struct nvmem_device.
> This allows registering a devm action on the nvmem device itself, ensuring
> the private data outlives any active cell references.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> Co-developed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---
> block/Kconfig | 9 +++
> block/Makefile | 1 +
> block/blk-nvmem.c | 171 +++++++++++++++++++++++++++++++++++++++++
> drivers/nvmem/core.c | 13 ++++
> include/linux/nvmem-consumer.h | 6 ++
> 5 files changed, 200 insertions(+)
>
> diff --git a/block/Kconfig b/block/Kconfig
> index 15027963472d7b40e27b9097a5993c457b5b3054..0b33747e16dc33473683706f75c92bdf8b648f7c 100644
> --- a/block/Kconfig
> +++ b/block/Kconfig
> @@ -209,6 +209,15 @@ config BLK_INLINE_ENCRYPTION_FALLBACK
> by falling back to the kernel crypto API when inline
> encryption hardware is not present.
>
> +config BLK_NVMEM
> + bool "Block device NVMEM provider"
> + depends on OF
> + depends on NVMEM
> + help
> + Allow block devices (or partitions) to act as NVMEM providers,
> + typically used with eMMC to store MAC addresses or Wi-Fi
> + calibration data on embedded devices.
> +
> source "block/partitions/Kconfig"
>
> config BLK_PM
> diff --git a/block/Makefile b/block/Makefile
> index 7dce2e44276c4274c11a0a61121c83d9c43d6e0c..d7ac389e71902bc091a8800ea266190a43b3e63d 100644
> --- a/block/Makefile
> +++ b/block/Makefile
> @@ -36,3 +36,4 @@ obj-$(CONFIG_BLK_INLINE_ENCRYPTION) += blk-crypto.o blk-crypto-profile.o \
> blk-crypto-sysfs.o
> obj-$(CONFIG_BLK_INLINE_ENCRYPTION_FALLBACK) += blk-crypto-fallback.o
> obj-$(CONFIG_BLOCK_HOLDER_DEPRECATED) += holder.o
> +obj-$(CONFIG_BLK_NVMEM) += blk-nvmem.o
> diff --git a/block/blk-nvmem.c b/block/blk-nvmem.c
> new file mode 100644
> index 0000000000000000000000000000000000000000..99c7728fb7bccdc2216780a73a89a9210f925049
> --- /dev/null
> +++ b/block/blk-nvmem.c
> @@ -0,0 +1,171 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * block device NVMEM provider
> + *
> + * Copyright (c) 2024 Daniel Golle <daniel@makrotopia.org>
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + *
> + * Useful on devices using a partition on an eMMC for MAC addresses or
> + * Wi-Fi calibration EEPROM data.
> + */
> +
> +#include <linux/cleanup.h>
> +#include <linux/mutex.h>
> +#include <linux/nvmem-provider.h>
> +#include <linux/nvmem-consumer.h>
> +#include <linux/of.h>
> +#include <linux/pagemap.h>
> +#include <linux/property.h>
> +
> +#include "blk.h"
> +
> +
Stray newline?
> +/* List of all NVMEM devices */
> +static LIST_HEAD(nvmem_devices);
> +static DEFINE_MUTEX(devices_mutex);
> +
> +struct blk_nvmem {
> + struct nvmem_device *nvmem;
> + dev_t devt;
> + struct list_head list;
> +};
> +
> +static int blk_nvmem_reg_read(void *priv, unsigned int from,
> + void *val, size_t bytes)
> +{
> + blk_mode_t mode = BLK_OPEN_READ | BLK_OPEN_RESTRICT_WRITES;
> + struct blk_nvmem *bnv = priv;
> + size_t bytes_left = bytes;
> + struct file *bdev_file;
> + loff_t pos = from;
> + int ret = 0;
> +
> + bdev_file = bdev_file_open_by_dev(bnv->devt, mode, priv, NULL);
> + if (!bdev_file)
> + return -ENODEV;
> +
> + if (IS_ERR(bdev_file))
> + return PTR_ERR(bdev_file);
> +
> + while (bytes_left) {
> + pgoff_t f_index = pos >> PAGE_SHIFT;
> + struct folio *folio;
> + size_t folio_off;
> + size_t to_read;
> +
> + folio = read_mapping_folio(bdev_file->f_mapping, f_index, NULL);
> + if (IS_ERR(folio)) {
> + ret = PTR_ERR(folio);
> + goto err_release_bdev;
> + }
> +
> + folio_off = offset_in_folio(folio, pos);
> + to_read = min(bytes_left, folio_size(folio) - folio_off);
> + memcpy_from_folio(val, folio, folio_off, to_read);
> + pos += to_read;
> + bytes_left -= to_read;
> + val += to_read;
> + folio_put(folio);
> + }
> +
> +err_release_bdev:
> + fput(bdev_file);
There's a __free() action defined in linux/file.h so you can use:
struct file *bdev_file __free(fput) = ...
and avoid this label.
> +
> + return ret;
> +}
> +
> +static int blk_nvmem_register(struct device *dev)
> +{
> + struct device_node *child, *np = dev_of_node(dev);
> + struct block_device *bdev = dev_to_bdev(dev);
> + struct nvmem_config config = {};
> + struct blk_nvmem *bnv;
> +
> + /* skip devices which do not have a device tree node */
> + if (!np)
> + return 0;
> +
> + /* skip devices without an nvmem layout defined */
> + child = of_get_child_by_name(np, "nvmem-layout");
> + if (!child)
> + return 0;
> + of_node_put(child);
Same as above, can be:
struct device_node *child __free(device_node) == ...
> +
> + /*
> + * skip block device too large to be represented as NVMEM devices,
> + * the NVMEM reg_read callback uses an unsigned int offset
> + */
> + if (bdev_nr_bytes(bdev) > UINT_MAX)
> + return -EFBIG;
This will mean a failed probe. Wouldn't it be better to use -ENODEV?
> +
> + bnv = kzalloc_obj(*bnv);
> + if (!bnv)
> + return -ENOMEM;
> +
> + config.id = NVMEM_DEVID_NONE;
> + config.dev = &bdev->bd_device;
> + config.name = dev_name(&bdev->bd_device);
> + config.owner = THIS_MODULE;
> + config.priv = bnv;
> + config.reg_read = blk_nvmem_reg_read;
> + config.size = bdev_nr_bytes(bdev);
> + config.word_size = 1;
> + config.stride = 1;
> + config.read_only = true;
> + config.root_only = true;
> + config.ignore_wp = true;
> + config.of_node = to_of_node(dev->fwnode);
> +
> + bnv->devt = bdev->bd_device.devt;
> + bnv->nvmem = nvmem_register(&config);
> + if (IS_ERR(bnv->nvmem)) {
> + dev_err_probe(&bdev->bd_device, PTR_ERR(bnv->nvmem),
> + "Failed to register NVMEM device\n");
> + kfree(bnv);
> + return PTR_ERR(bnv->nvmem);
> + }
> +
> + scoped_guard(mutex, &devices_mutex)
> + list_add_tail(&bnv->list, &nvmem_devices);
I'm not sure I understand the need to store these? Whatever you need to do in
remove() can be scheduled in a devres action here.
> +
> + return 0;
> +}
> +
> +static void blk_nvmem_unregister(struct device *dev)
> +{
> + struct blk_nvmem *bnv_c, *bnv_t, *bnv = NULL;
> +
> + scoped_guard(mutex, &devices_mutex) {
> + list_for_each_entry_safe(bnv_c, bnv_t, &nvmem_devices, list) {
> + if (bnv_c->devt == dev_to_bdev(dev)->bd_device.devt) {
> + bnv = bnv_c;
> + list_del(&bnv->list);
> + break;
> + }
> + }
> +
> + if (!bnv)
> + return;
> + }
> +
> + nvmem_unregister(bnv->nvmem);
> + kfree(bnv);
> +}
> +
> +static struct class_interface blk_nvmem_bus_interface __refdata = {
> + .class = &block_class,
> + .add_dev = &blk_nvmem_register,
> + .remove_dev = &blk_nvmem_unregister,
> +};
> +
> +static int __init blk_nvmem_init(void)
> +{
> + int ret;
> +
> + ret = class_interface_register(&blk_nvmem_bus_interface);
> + if (ret)
> + return ret;
> +
> + return 0;
> +}
> +device_initcall(blk_nvmem_init);
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 311cb2e5a5c02d2c6979d7c9bbb7f94abdfbdad1..ee3481229c20b3063c86d0dd66aabbf6b5e29169 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -2154,6 +2154,19 @@ const char *nvmem_dev_name(struct nvmem_device *nvmem)
> }
> EXPORT_SYMBOL_GPL(nvmem_dev_name);
>
> +/**
> + * nvmem_dev() - Get the struct device of a given nvmem device.
> + *
> + * @nvmem: nvmem device.
> + *
> + * Return: pointer to the struct device of the nvmem device.
> + */
> +struct device *nvmem_dev(struct nvmem_device *nvmem)
> +{
> + return &nvmem->dev;
> +}
> +EXPORT_SYMBOL_GPL(nvmem_dev);
This should still be a separate patch.
> +
> /**
> * nvmem_dev_size() - Get the size of a given nvmem device.
> *
> diff --git a/include/linux/nvmem-consumer.h b/include/linux/nvmem-consumer.h
> index 34c0e58dfa26636d2804fcc7e0bc4a875ee73dae..ce387c89dc8e4bc1241f3b6f36be8c6c95e282ed 100644
> --- a/include/linux/nvmem-consumer.h
> +++ b/include/linux/nvmem-consumer.h
> @@ -82,6 +82,7 @@ int nvmem_device_cell_write(struct nvmem_device *nvmem,
>
> const char *nvmem_dev_name(struct nvmem_device *nvmem);
> size_t nvmem_dev_size(struct nvmem_device *nvmem);
> +struct device *nvmem_dev(struct nvmem_device *nvmem);
>
> void nvmem_add_cell_lookups(struct nvmem_cell_lookup *entries,
> size_t nentries);
> @@ -220,6 +221,11 @@ static inline const char *nvmem_dev_name(struct nvmem_device *nvmem)
> return NULL;
> }
>
> +static inline struct device *nvmem_dev(struct nvmem_device *nvmem)
> +{
> + return NULL;
> +}
> +
> static inline void
> nvmem_add_cell_lookups(struct nvmem_cell_lookup *entries, size_t nentries) {}
> static inline void
>
> --
> 2.34.1
>
>
Bart
^ permalink raw reply
* [PATCH BlueZ] a2dp: Add codec prioritization
From: Simon Mikuda @ 2026-06-08 11:16 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
This change will select best codec when connecting to A2DP:
LDAC > AptX HD > AptX > AAC > SBC
---
profiles/audio/avdtp.c | 51 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 50 insertions(+), 1 deletion(-)
diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
index d475a545e..a8733a7e1 100644
--- a/profiles/audio/avdtp.c
+++ b/profiles/audio/avdtp.c
@@ -42,6 +42,8 @@
#include "sink.h"
#include "source.h"
+#include "a2dp-codecs.h"
+
#define AVDTP_PSM 25
#define MAX_SEID 0x3E
@@ -1293,10 +1295,49 @@ static struct avdtp_stream *find_stream_by_lseid(struct avdtp *session,
return find_stream_by_lsep(session, sep);
}
+static unsigned int get_codec_priority(
+ struct avdtp_media_codec_capability *codec_cap)
+{
+ unsigned int priority = codec_cap->media_codec_type;
+
+ if (codec_cap->media_codec_type == A2DP_CODEC_VENDOR) {
+ a2dp_vendor_codec_t *vendor_codec = (void *) codec_cap->data;
+
+ switch (A2DP_GET_VENDOR_ID(*vendor_codec)) {
+ case APTX_VENDOR_ID:
+ return priority + 100;
+ case APTX_HD_VENDOR_ID:
+ return priority + 200;
+ case LDAC_VENDOR_ID:
+ return priority + 300;
+ }
+ }
+
+ return priority;
+}
+
+static int sep_codec_cmp(gconstpointer a, gconstpointer b)
+{
+ const struct avdtp_remote_sep *sep1 = a;
+ struct avdtp_service_capability *cap1 = sep1->codec;
+ unsigned int priority1 = get_codec_priority((void *) cap1->data);
+
+ const struct avdtp_remote_sep *sep2 = b;
+ struct avdtp_service_capability *cap2 = sep2->codec;
+ unsigned int priority2 = get_codec_priority((void *) cap2->data);
+
+ if (priority1 < priority2)
+ return 1;
+ if (priority1 > priority2)
+ return -1;
+ return 0;
+}
+
struct avdtp_remote_sep *avdtp_find_remote_sep(struct avdtp *session,
struct avdtp_local_sep *lsep)
{
GSList *l;
+ GSList *sorted = NULL;
for (l = session->seps; l != NULL; l = g_slist_next(l)) {
struct avdtp_remote_sep *sep = l->data;
@@ -1325,7 +1366,15 @@ struct avdtp_remote_sep *avdtp_find_remote_sep(struct avdtp *session,
continue;
if (sep->stream == NULL)
- return sep;
+ sorted = g_slist_insert_sorted(sorted, sep,
+ sep_codec_cmp);
+ }
+
+ if (sorted) {
+ struct avdtp_remote_sep *sep = sorted->data;
+
+ g_slist_free(sorted);
+ return sep;
}
return NULL;
--
2.43.0
^ permalink raw reply related
* Re: [PATCH v3 3/7] dt-bindings: bluetooth: qcom: Add NVMEM BD address cell
From: Bartosz Golaszewski @ 2026-06-08 11:17 UTC (permalink / raw)
To: Loic Poulain
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, linux-block,
linux-wireless, ath10k, linux-bluetooth, netdev, daniel,
Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Jens Axboe, Johannes Berg,
Jeff Johnson, Bartosz Golaszewski, Marcel Holtmann,
Luiz Augusto von Dentz, Balakrishna Godavarthi, Rocky Liao,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Srinivas Kandagatla, Andrew Lunn, Heiner Kallweit,
Russell King, Saravana Kannan
In-Reply-To: <20260608-block-as-nvmem-v3-3-82681f50aa35@oss.qualcomm.com>
On Mon, 8 Jun 2026 12:50:40 +0200, Loic Poulain
<loic.poulain@oss.qualcomm.com> said:
> Add support for an NVMEM cell provider for "local-bd-address",
> allowing the Bluetooth stack to retrieve controller's BD address
> from non-volatile storage such as an EEPROM or an eMMC partition.
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---
> .../devicetree/bindings/net/bluetooth/qcom,bluetooth-common.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qcom,bluetooth-common.yaml b/Documentation/devicetree/bindings/net/bluetooth/qcom,bluetooth-common.yaml
> index c8e9c55c1afb4c8e05ba2dae41ce2db4194b4a0f..7cb28f30c9af032082f23311f2fc89a32f266f17 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/qcom,bluetooth-common.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/qcom,bluetooth-common.yaml
> @@ -22,4 +22,13 @@ properties:
> description:
> boot firmware is incorrectly passing the address in big-endian order
>
> + nvmem-cells:
> + maxItems: 1
> + description:
> + Nvmem data cell that contains a 6 byte BD address with the most
> + significant byte first (big-endian).
> +
> + nvmem-cell-names:
> + const: local-bd-address
> +
> additionalProperties: true
>
> --
> 2.34.1
>
>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply
* Re: [PATCH v3 1/7] dt-bindings: mmc: Document support for nvmem-layout
From: Bartosz Golaszewski @ 2026-06-08 11:18 UTC (permalink / raw)
To: Loic Poulain
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, linux-block,
linux-wireless, ath10k, linux-bluetooth, netdev, daniel,
Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Jens Axboe, Johannes Berg,
Jeff Johnson, Bartosz Golaszewski, Marcel Holtmann,
Luiz Augusto von Dentz, Balakrishna Godavarthi, Rocky Liao,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Srinivas Kandagatla, Andrew Lunn, Heiner Kallweit,
Russell King, Saravana Kannan
In-Reply-To: <20260608-block-as-nvmem-v3-1-82681f50aa35@oss.qualcomm.com>
On Mon, 8 Jun 2026 12:50:38 +0200, Loic Poulain
<loic.poulain@oss.qualcomm.com> said:
> Add support for an nvmem-layout subnode under an eMMC hardware
> partition. This allows the partition to be exposed as an NVMEM
> provider and its internal layout to be described. For example,
> an eMMC boot partition can be used to store device-specific
> information such as a WiFi MAC address.
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply
* Re: [PATCH v3 2/7] dt-bindings: net: wireless: qcom,ath10k: Document NVMEM cells
From: Bartosz Golaszewski @ 2026-06-08 11:18 UTC (permalink / raw)
To: Loic Poulain
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, linux-block,
linux-wireless, ath10k, linux-bluetooth, netdev, daniel,
Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Jens Axboe, Johannes Berg,
Jeff Johnson, Bartosz Golaszewski, Marcel Holtmann,
Luiz Augusto von Dentz, Balakrishna Godavarthi, Rocky Liao,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Srinivas Kandagatla, Andrew Lunn, Heiner Kallweit,
Russell King, Saravana Kannan
In-Reply-To: <20260608-block-as-nvmem-v3-2-82681f50aa35@oss.qualcomm.com>
On Mon, 8 Jun 2026 12:50:39 +0200, Loic Poulain
<loic.poulain@oss.qualcomm.com> said:
> Document the NVMEM cells supported by the ath10k driver, the
> mac-address, pre-calibration data, and calibration data.
>
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply
* Re: [PATCH v3 6/7] Bluetooth: hci_sync: Add NVMEM-backed BD address retrieval
From: Bartosz Golaszewski @ 2026-06-08 11:19 UTC (permalink / raw)
To: Loic Poulain
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, linux-block,
linux-wireless, ath10k, linux-bluetooth, netdev, daniel,
Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Jens Axboe, Johannes Berg,
Jeff Johnson, Bartosz Golaszewski, Marcel Holtmann,
Luiz Augusto von Dentz, Balakrishna Godavarthi, Rocky Liao,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Srinivas Kandagatla, Andrew Lunn, Heiner Kallweit,
Russell King, Saravana Kannan
In-Reply-To: <20260608-block-as-nvmem-v3-6-82681f50aa35@oss.qualcomm.com>
On Mon, 8 Jun 2026 12:50:43 +0200, Loic Poulain
<loic.poulain@oss.qualcomm.com> said:
> Some devices store the Bluetooth BD address in non-volatile
> memory, which can be accessed through the NVMEM framework.
> Similar to Ethernet or WiFi MAC addresses, add support for
> reading the BD address from a 'local-bd-address' NVMEM cell.
>
> As with the device-tree provided BD address, add a quirk to
> indicate whether a device or platform should attempt to read
> the address from NVMEM when no valid in-chip address is present.
> Also add a quirk to indicate if the address is stored in
> big-endian byte order.
>
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply
* [PATCH BlueZ] bap: Fix CCC value for ASE control point
From: Simon Mikuda @ 2026-06-08 11:20 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
WriteWithoutResponse was missing
---
src/shared/bap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/shared/bap.c b/src/shared/bap.c
index 8fc2fb14d..968b85730 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -3776,6 +3776,7 @@ static struct bt_ascs *ascs_new(struct gatt_db *db)
&uuid,
BT_ATT_PERM_WRITE,
BT_GATT_CHRC_PROP_WRITE |
+ BT_GATT_CHRC_PROP_WRITE_WITHOUT_RESP |
BT_GATT_CHRC_PROP_NOTIFY,
NULL, ascs_ase_cp_write,
ascs);
--
2.43.0
^ permalink raw reply related
* [PATCH BlueZ] device: Fix auth_retry timeout not being removed on reconnect
From: Simon Mikuda @ 2026-06-08 11:24 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
timeout_remove() was called with 0 instead of the actual timer ID
because auth_retry_id was zeroed before the call.
---
src/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/device.c b/src/device.c
index bea893301..8f7ec5654 100644
--- a/src/device.c
+++ b/src/device.c
@@ -3810,8 +3810,8 @@ void device_add_connection(struct btd_device *dev, uint8_t bdaddr_type,
struct bearer_state *state = get_state(dev, bdaddr_type);
if (dev->auth_retry_id) {
- dev->auth_retry_id = 0;
timeout_remove(dev->auth_retry_id);
+ dev->auth_retry_id = 0;
dev->auth_failures = 0;
}
--
2.43.0
^ permalink raw reply related
* [bluez/bluez] 671363: hog: Fix starting encryption on some BLE remotes
From: Šimon Mikuda @ 2026-06-08 11:29 UTC (permalink / raw)
To: linux-bluetooth
Branch: refs/heads/1107612
Home: https://github.com/bluez/bluez
Commit: 671363a7c1e274bcbe475da9290f886a12229d61
https://github.com/bluez/bluez/commit/671363a7c1e274bcbe475da9290f886a12229d61
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M profiles/input/hog.c
Log Message:
-----------
hog: Fix starting encryption on some BLE remotes
When BLE remote doesn't reply with Insufficient Authentication Error
encryption is not started.
Good remote:
< ACL Data TX: Handle 64 flags 0x00 dlen 7
ATT: Read Request (0x0a) len 2
Handle: 0x0021 Type: HID Information (0x2a4a)
> ACL Data RX: Handle 64 flags 0x02 dlen 9
ATT: Error Response (0x01) len 4
Read Request (0x0a)
Handle: 0x0000
Error: Insufficient Authentication (0x05)
< HCI Command: LE Start Encryption (0x08|0x0019) plen 28
Handle: 64 Address: xx:xx:xx:xx:xx:xx (OUI xx-xx-xx)
Random number: ...
Encrypted diversifier: ...
Long term key: ...
Bad remote:
< ACL Data TX: Handle 64 flags 0x00 dlen 7
ATT: Read Request (0x0a) len 2
Handle: 0x001e Type: HID Information (0x2a4a)
> ACL Data RX: Handle 64 flags 0x02 dlen 9
ATT: Read Response (0x0b) len 4
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
^ permalink raw reply
* [bluez/bluez] a8832a: device: Refactor device_discover_services function
From: Šimon Mikuda @ 2026-06-08 11:29 UTC (permalink / raw)
To: linux-bluetooth
Branch: refs/heads/1107759
Home: https://github.com/bluez/bluez
Commit: a8832a9553fb3b9c4c41723a5498f84ae1f0e280
https://github.com/bluez/bluez/commit/a8832a9553fb3b9c4c41723a5498f84ae1f0e280
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M profiles/input/server.c
M src/adapter.c
M src/device.c
M src/device.h
Log Message:
-----------
device: Refactor device_discover_services function
After refactoring we can reuse function once more in function
void device_bonding_complete(...)
Commit: 04c3a58df0f657149e12565edc87174882fd22f5
https://github.com/bluez/bluez/commit/04c3a58df0f657149e12565edc87174882fd22f5
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/device.c
Log Message:
-----------
device: Rename start_discovery function
Rename it to start_discovery_cb to indicate that it is callback function
from timer.
Commit: 2c1a4f11da736bc4218d869fdaca7d5ac8cd1ec8
https://github.com/bluez/bluez/commit/2c1a4f11da736bc4218d869fdaca7d5ac8cd1ec8
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/device.c
Log Message:
-----------
device: Fix returning discovery error for Device.Pair
If discovery was requesed from pair request we will report successfull
pairing even if there was an error during discovery.
Compare: https://github.com/bluez/bluez/compare/a8832a9553fb%5E...2c1a4f11da73
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
^ permalink raw reply
* [bluez/bluez] f77e33: device: Refactor device_discover_services function
From: Šimon Mikuda @ 2026-06-08 11:29 UTC (permalink / raw)
To: linux-bluetooth
Branch: refs/heads/1107770
Home: https://github.com/bluez/bluez
Commit: f77e3342b063f9d0d24481b9c9072cf65715dbd6
https://github.com/bluez/bluez/commit/f77e3342b063f9d0d24481b9c9072cf65715dbd6
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M profiles/input/server.c
M src/adapter.c
M src/device.c
M src/device.h
Log Message:
-----------
device: Refactor device_discover_services function
After refactoring we can reuse function once more in function
void device_bonding_complete(...)
Commit: 5208e0e39be7f840cf6aac9843753ab01ebc96ad
https://github.com/bluez/bluez/commit/5208e0e39be7f840cf6aac9843753ab01ebc96ad
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/device.c
Log Message:
-----------
device: Rename start_discovery function
Rename it to start_discovery_cb to indicate that it is callback function
from timer.
Commit: 374f7c2ed37f7927205a770d66c5b9b1f0f890ad
https://github.com/bluez/bluez/commit/374f7c2ed37f7927205a770d66c5b9b1f0f890ad
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/device.c
Log Message:
-----------
device: Fix returning discovery error for Device.Pair
If discovery was requesed from pair request we will report successfull
pairing even if there was an error during discovery.
Compare: https://github.com/bluez/bluez/compare/f77e3342b063%5E...374f7c2ed37f
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
^ permalink raw reply
* [bluez/bluez] 51f28d: device: Refactor device_discover_services function
From: Šimon Mikuda @ 2026-06-08 11:29 UTC (permalink / raw)
To: linux-bluetooth
Branch: refs/heads/1107774
Home: https://github.com/bluez/bluez
Commit: 51f28d24f7c767616f5101050789e67a25789a5e
https://github.com/bluez/bluez/commit/51f28d24f7c767616f5101050789e67a25789a5e
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M profiles/input/server.c
M src/adapter.c
M src/device.c
M src/device.h
Log Message:
-----------
device: Refactor device_discover_services function
After refactoring we can reuse function once more in function
void device_bonding_complete(...)
Commit: 0967651164a2118729967a25d670eb3f249aa72f
https://github.com/bluez/bluez/commit/0967651164a2118729967a25d670eb3f249aa72f
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/device.c
Log Message:
-----------
device: Rename start_discovery function
Rename it to start_discovery_cb to indicate that it is callback function
from timer.
Commit: fa023bc6417933847b1fcea23cb0da75fcc31eed
https://github.com/bluez/bluez/commit/fa023bc6417933847b1fcea23cb0da75fcc31eed
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/device.c
Log Message:
-----------
device: Fix returning discovery error for Device.Pair
If discovery was requesed from pair request we will report successfull
pairing even if there was an error during discovery.
Compare: https://github.com/bluez/bluez/compare/51f28d24f7c7%5E...fa023bc64179
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
^ permalink raw reply
* Re: [PATCH v3 7/7] Bluetooth: qca: Set NVMEM BD address quirks when address is invalid
From: Konrad Dybcio @ 2026-06-08 11:29 UTC (permalink / raw)
To: Loic Poulain, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Jens Axboe,
Johannes Berg, Jeff Johnson, Bartosz Golaszewski, Marcel Holtmann,
Luiz Augusto von Dentz, Balakrishna Godavarthi, Rocky Liao,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Srinivas Kandagatla, Andrew Lunn, Heiner Kallweit,
Russell King, Saravana Kannan
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, linux-block,
linux-wireless, ath10k, linux-bluetooth, netdev, daniel,
Bartosz Golaszewski
In-Reply-To: <20260608-block-as-nvmem-v3-7-82681f50aa35@oss.qualcomm.com>
On 6/8/26 12:50 PM, Loic Poulain wrote:
> When the controller BD address is invalid (zero or default),
> set the NVMEM quirks to allow retrieving the address from a
> 'local-bd-address' NVMEM cell. The BD address is often stored
> alongside the WiFi MAC address in big-endian format, so also
> set the big-endian quirk.
>
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts | 39 ++++++++++++++++++++++
> drivers/bluetooth/btqca.c | 5 ++-
Squash mistake?
Konrad
^ permalink raw reply
* [bluez/bluez] 2a496e: adapter: Fix failed bonding attempt after LE link ...
From: Šimon Mikuda @ 2026-06-08 11:29 UTC (permalink / raw)
To: linux-bluetooth
Branch: refs/heads/1107775
Home: https://github.com/bluez/bluez
Commit: 2a496ed0fafa820b80e29d3747c22a241e6d5ade
https://github.com/bluez/bluez/commit/2a496ed0fafa820b80e29d3747c22a241e6d5ade
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/adapter.c
Log Message:
-----------
adapter: Fix failed bonding attempt after LE link disconnection
What happens when issue occurs:
- device is connected to both bearers BR/EDR and LE
- bonding is requested
- LE link disconnects
- pairing keys arrive
BlueZ would finish bonding request with error and mark device as
temporary. Then it would be disconnected+removed after default
temporary timeout (30 seconds).
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
^ permalink raw reply
* [bluez/bluez] 435c7a: a2dp: Add codec prioritization
From: Šimon Mikuda @ 2026-06-08 11:29 UTC (permalink / raw)
To: linux-bluetooth
Branch: refs/heads/1107778
Home: https://github.com/bluez/bluez
Commit: 435c7ae4f79cc3f616d76e7142b03dd2d5d343a4
https://github.com/bluez/bluez/commit/435c7ae4f79cc3f616d76e7142b03dd2d5d343a4
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M profiles/audio/avdtp.c
Log Message:
-----------
a2dp: Add codec prioritization
This change will select best codec when connecting to A2DP:
LDAC > AptX HD > AptX > AAC > SBC
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
^ permalink raw reply
* [PATCH BlueZ 1/2] avdtp: Fix GET_CONFIGURATION cmd
From: Simon Mikuda @ 2026-06-08 11:29 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
This fixes AVDTP/SNK/ACP/SIG/SMG/BV-12-C
---
profiles/audio/avdtp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
index d475a545e..7cfc9a80d 100644
--- a/profiles/audio/avdtp.c
+++ b/profiles/audio/avdtp.c
@@ -1641,7 +1641,6 @@ static gboolean avdtp_getconf_cmd(struct avdtp *session, uint8_t transaction,
struct seid_req *req, int size)
{
GSList *l;
- struct avdtp_local_sep *sep = NULL;
struct avdtp_stream *stream;
int rsp_size;
uint8_t err;
@@ -1656,7 +1655,7 @@ static gboolean avdtp_getconf_cmd(struct avdtp *session, uint8_t transaction,
memset(buf, 0, sizeof(buf));
stream = find_stream_by_lseid(session, req->acp_seid);
- if (!sep) {
+ if (!stream) {
err = AVDTP_BAD_ACP_SEID;
goto failed;
}
--
2.43.0
^ permalink raw reply related
* [bluez/bluez] 78a1c0: bap: Fix CCC value for ASE control point
From: Šimon Mikuda @ 2026-06-08 11:29 UTC (permalink / raw)
To: linux-bluetooth
Branch: refs/heads/1107783
Home: https://github.com/bluez/bluez
Commit: 78a1c0fc320e63b4da717c4aca293ddb0a44dafd
https://github.com/bluez/bluez/commit/78a1c0fc320e63b4da717c4aca293ddb0a44dafd
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/shared/bap.c
Log Message:
-----------
bap: Fix CCC value for ASE control point
WriteWithoutResponse was missing
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
^ permalink raw reply
* [PATCH BlueZ 2/2] avdtp: Fix error handling for AVDTP_OPEN cmd
From: Simon Mikuda @ 2026-06-08 11:29 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
In-Reply-To: <20260608112923.3722754-1-simon.mikuda@streamunlimited.com>
We have to return BAD_STATE when local SEP is available instead of
BAD_ACP_SEID.
This fixes: AVDTP/SNK/ACP/SIG/SMG/BI-26-C
---
profiles/audio/avdtp.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
index 7cfc9a80d..6be6e99b4 100644
--- a/profiles/audio/avdtp.c
+++ b/profiles/audio/avdtp.c
@@ -1771,13 +1771,14 @@ static gboolean avdtp_open_cmd(struct avdtp *session, uint8_t transaction,
return FALSE;
}
- stream = find_stream_by_lseid(session, req->acp_seid);
- if (!stream) {
+ sep = find_local_sep_by_seid(session, req->acp_seid);
+ if (!sep) {
err = AVDTP_BAD_ACP_SEID;
goto failed;
}
- if (stream->state != AVDTP_STATE_CONFIGURED) {
+ stream = find_stream_by_lsep(session, sep);
+ if (!stream || stream->state != AVDTP_STATE_CONFIGURED) {
err = AVDTP_BAD_STATE;
goto failed;
}
@@ -1790,7 +1791,6 @@ static gboolean avdtp_open_cmd(struct avdtp *session, uint8_t transaction,
AVDTP_OPEN, NULL, 0);
}
- sep = stream->lsep;
if (sep->ind && sep->ind->open && !session->pending_open) {
if (!sep->ind->open(session, sep, stream, &err,
sep->user_data))
--
2.43.0
^ permalink raw reply related
* [bluez/bluez] f254fc: device: Fix auth_retry timeout not being removed o...
From: Šimon Mikuda @ 2026-06-08 11:29 UTC (permalink / raw)
To: linux-bluetooth
Branch: refs/heads/1107787
Home: https://github.com/bluez/bluez
Commit: f254fcf4fb7340e4a2d14d3ca63b918dd7868dfe
https://github.com/bluez/bluez/commit/f254fcf4fb7340e4a2d14d3ca63b918dd7868dfe
Author: Simon Mikuda <simon.mikuda@streamunlimited.com>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/device.c
Log Message:
-----------
device: Fix auth_retry timeout not being removed on reconnect
timeout_remove() was called with 0 instead of the actual timer ID
because auth_retry_id was zeroed before the call.
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox