no client session close in obexd 0.23?

no client session close in obexd 0.23?

[Daniel Abraham]

I noticed that the client session close method is missing in obexd 0.23
(and also from the API document, so I guess it's intentional)

So how can I trigger it?

Thanks

Re: no client session close in obexd 0.23?

[Daniel Abraham]

Oops, didn't notice the (also new) client method "RemoveSession"

Out of curiosity, what's the benefit of moving close/remove from
session scope to client scope?


On Mon, Apr 26, 2010 at 12:29 PM, Daniel Abraham
<daniel.shrugged@gmail.com> wrote:
> I noticed that the client session close method is missing in obexd 0.23
> (and also from the API document, so I guess it's intentional)
>
> So how can I trigger it?
>
> Thanks
>

Re: no client session close in obexd 0.23?

[Luiz Augusto von Dentz]

Hi,

On Mon, Apr 26, 2010 at 1:39 PM, Daniel Abraham
<daniel.shrugged@gmail.com> wrote:
> Oops, didn't notice the (also new) client method "RemoveSession"
>
> Out of curiosity, what's the benefit of moving close/remove from
> session scope to client scope?

No self destruction, in general it is bad idea, but in this case it
even worse because the internally the session may be referred in many
places.


-- 
Luiz Augusto von Dentz
Computer Engineer

Re: no client session close in obexd 0.23?

[Daniel Abraham]

Thanks!

Followup question - I'm trying to use it, but it throws this exception:
dbus.exceptions.DBusException: org.openobex.Error.InvalidArguments:

What am I doing wrong? What is the right input?

Here's a sample Python script:

---

#!/usr/bin/env python

import dbus

bus = dbus.SessionBus()
proxy = bus.get_object('org.openobex.client', '/')
client = dbus.Interface(proxy, 'org.openobex.Client')

address = '00:1C:26:FC:15:AF'

print('Opening FTP session')
path = client.CreateSession({'Target': 'ftp', 'Destination': address})
print(path)
client.RemoveSession(path)
print('FTP session closed')

---

Output:

Opening FTP session
/org/openobex/session0
Traceback (most recent call last):
  File "./test-ftp.py", line 14, in <module>
    client.RemoveSession(path)
  File "/usr/lib/python2.6/site-packages/dbus/proxies.py", line 140, in __call__
    **keywords)
  File "/usr/lib/python2.6/site-packages/dbus/connection.py", line
630, in call_blocking
    message, timeout)
dbus.exceptions.DBusException: org.openobex.Error.InvalidArguments:

Re: no client session close in obexd 0.23?

[Luiz Augusto von Dentz]

Hi,

On Tue, Apr 27, 2010 at 2:37 AM, Daniel Abraham
<daniel.shrugged@gmail.com> wrote:
> Thanks!
>
> Followup question - I'm trying to use it, but it throws this exception:
> dbus.exceptions.DBusException: org.openobex.Error.InvalidArguments:
>
> What am I doing wrong? What is the right input?
>
> Here's a sample Python script:
>
> ---
>
> #!/usr/bin/env python
>
> import dbus
>
> bus = dbus.SessionBus()
> proxy = bus.get_object('org.openobex.client', '/')
> client = dbus.Interface(proxy, 'org.openobex.Client')
>
> address = '00:1C:26:FC:15:AF'
>
> print('Opening FTP session')
> path = client.CreateSession({'Target': 'ftp', 'Destination': address})
> print(path)
> client.RemoveSession(path)
> print('FTP session closed')
>
> ---
>
> Output:
>
> Opening FTP session
> /org/openobex/session0
> Traceback (most recent call last):
>  File "./test-ftp.py", line 14, in <module>
>    client.RemoveSession(path)
>  File "/usr/lib/python2.6/site-packages/dbus/proxies.py", line 140, in __call__
>    **keywords)
>  File "/usr/lib/python2.6/site-packages/dbus/connection.py", line
> 630, in call_blocking
>    message, timeout)
> dbus.exceptions.DBusException: org.openobex.Error.InvalidArguments:
>

It's a bug, could you please try this:

http://gitorious.org/~vudentz/obexd/vudentzs-clone/commit/fd4e8e2cef72542fb5bc924817f4b409415b3b54

I guess that should fix the problem.


-- 
Luiz Augusto von Dentz
Computer Engineer

Re: no client session close in obexd 0.23?

[Daniel Abraham]

On Tue, Apr 27, 2010 at 10:10 AM, Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> It's a bug, could you please try this:
>
> http://gitorious.org/~vudentz/obexd/vudentzs-clone/commit/fd4e8e2cef72542fb5bc924817f4b409415b3b54
>
> I guess that should fix the problem.

Confirmed, the fix works as intended.