From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.179 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795048436; b=KfBvCLPKkzbr1gnyIeWLGV+rIiPSJNbJYrXjamgTaxCGzj4gRGCcowNr1dWpn19ZNpwb PUkEHxjVjqUXLta1niaZ6qnsvP83hiD1sjlJfm4FNK4pUfQ2LEFAT+RTMbXjbeZcwwic4 PF77JnNnTdtYcKK9Yr4VYVyfxaWoOWSGeZJjHNWPNLRRgGQcpHuWVq1WVT0EFbSse0O1c BW8KgjrsIIzTMKrmsQHQbDRVYdE7Q5c8aabMcvNvTpomkFA0Qa5c895qfgvteN6Bibpk3 Dz2jDk7UT65dj15G/AQoR1gzBr+BJklCV2gEyDu6iZNHPj3ZvuEyTEKES8h14+vxoNg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795048436; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:To:Cc:Subject: Date:Message-Id:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=Mf+Ix0VT3XOHjiXS9UfFNqsbEszPgfXax3HGp3S/DI4=; b=EHKYY1juNW7R87x12AaCEJGocyStNEPk8Q3h4xCMUGSk0AhFarS3e30TqM/FkO34/mVG pWEIXW7qUDql2UxDTuMJTKi7mTG//4B1ReSWnBaqjAvmmWwBLV+rmr8o3/B+6eiszLnEz zX1wMaxckyj9HnxMYiSVbEJrRMpuwlUObt74hUPG87H6bHT67CVZPDqHZjUJL1TzopT8t z3Lr6lOUw0aCAnZvyn73zOZnrw02w75mAHknB3Y6iv33RuB0d924N5+q01H5kRY4+7lRe 3vlNyumrp6zF0LN/GYqz/88Ec/2yXERhEOrj2h8oc3ON1pQmg3CR2aNuX/vL0TdBz9Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Tk5Jh6Pu; arc=none smtp.remote-ip=209.85.210.179 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A74F9606A33A for ; Thu, 19 Nov 2026 00:33:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A74F9606A33A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Tk5Jh6Pu Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-8b58d6f67a5so962801b3a.2 for ; Wed, 18 Nov 2026 16:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795048435; x=1795653235; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Mf+Ix0VT3XOHjiXS9UfFNqsbEszPgfXax3HGp3S/DI4=; b=Tk5Jh6Pu6ato0ErmiuOsS2OlYR5mKEhOBP+WysRa6aXRoKx1e9EOnoAvndLM5Zpxh6 u68vPOYYcIXRSm2VHb0Rk9/KRaYlW612hULKbmkJbFMldRiYVjmNGpaPgky0wBFrz/UT IHEP9dEAKsEWR9X+Zg9yA6ZNlmZ7C+QmDePHEZXFxzzNNJYZttbR6BTghhJf+jdXcioj ARaL3KZr3KIDXehEaj4XZkHkzRrEyLkR/cLubhbZ4JKA/wfbaSAPr+NzxE6Eaa/4xS42 vEqXsq4zEXiUaakrsedZaDBgU1YeYMfzaM8oGSlQfZe8ZzgMy/xPmcvNS+dRxxASohn9 9DMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795048435; x=1795653235; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Mf+Ix0VT3XOHjiXS9UfFNqsbEszPgfXax3HGp3S/DI4=; b=QUxT4nax+aE73/UO3wvuj1cMFoQXuZg5Z2N2/YG4Y9f2/R5p568081RXK/m2e+eyOz xZX/GY+CfFP2K6S/jBIdRqt0rtsYktAsqU+PMery8CrUK+XnZTgR0LhPx3if9zsuKG+3 PTqrMt8f9ttEFxn30i3F0PPIGP6SDT83id2k0QyGAV5ANsu/TjgLbrW3C9ygchKX2Kb/ FGqF9v2PI8OO+Vy1znpiYOfMVCUSsbxFfDQ0gmr51W6JOPvMTRYGXW+jZBcdhDWD2X/T FPzWU+9K39TOv0uGO7vVFUYuXU5Bu3vfouz9olkofXgVb4ui7plukI32TX08yByJQD/T EDiQ== X-Gm-Message-State: APuU4Z9aLcb3KQy44JfclaWBQ8lgK21mdKVQgq7MJkCO5utFhQlH7675 3/5regSAzlMWkoY+O+3/j2lUOMRqSJflPUYecHDi3nNU6BlwjGvlZkgB X-Gm-Gg: AYBFou16GGmDjgnJH/nuUJdtLbIilKZ77JC1B+dIU2h2Up3X0AiESNIkQIfmWz+0xml It4Hu58HB0Cy4/OXr7t0ezqlhpIlk3bC1ZCHdZesIVaSGrgdGLlZv2+G382/7/ejyexcCIFbZXS CscAeWdHxnXhfuRl1Smsjx7YsAFSCNuKOQg4wf+ba003yLrBf9zj27NVxlGeAZEOd+8fxbJCbIs TsxkccMqzrks0Wezs1qXrfZ9yCEQ5sJ8c3GUVXe6gM/1xOseV5TvU6/rhBApYnHd8pp56NlXmZz qA+DAoczskID/CSrAEZpYclksmvJW9HghUsVqjpAgMCRu9UrZlT56jwjXsY2OwmEzI5bh8iAL/T JGlLU1TWPJBlxo9ZMQ+ZHsRyUT3twNsEft9Otmxtmi0grjW7JiVugeg7+VctuNvvA+tdK4kXyka kVsDi4Jz3kUYgl9BePcsJU9qpHENGp25QhIQff0Fk5Fi8453tGJ/mA2MVU8E60CScZk7sA/lk0d 0aTcIB6PhyhlCNhxJmR86IiifNCMpIFKoAoDl8CcHNfr6SCEfNaUtWmAv0oIS/J0UI1AplmRn1U VyPNTvFgdRPY0nI7l0oiWPxu X-Received: by 2002:a05:6a00:1794:b0:89e:43ee:6549 with SMTP id d2e1a72fcca58-8c5d0f248eemr3651410b3a.5.1795048434969; Wed, 18 Nov 2026 16:33:54 -0800 (PST) Received: from localhost ([111.228.63.84]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8c5c7f99f91sm1906491b3a.5.2026.11.18.16.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 16:33:54 -0800 (PST) From: Cen Zhang To: marcel@holtmann.org, luiz.dentz@gmail.com Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, jjzuming@gmail.com, zzzccc427@gmail.com Subject: [PATCH v5 2/4] Bluetooth: SMP: Serialize forced BR/EDR channel changes Date: Thu, 19 Nov 2026 08:33:41 +0800 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Debugfs disable Power-off load smp_bredr_data clear the same slot release the channel release the saved channel again Take hdev->lock around the debugfs writer to serialize slot changes with power-off. When HCI_UP is clear, change only the force flag and let the next power-on register the root. Otherwise enabling the flag can leave a listening channel that an already-down close never removes. Skip deletion when power-off already cleared the slot. The following registration change uses the same mutex to serialize this writer with power-on too. The preceding publication change protects lookups from another controller with the same address. Oops report as below: Oops: general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] SMP KASAN NOPTI KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f] Workqueue: hci1 hci_rx_work RIP: 0010:l2cap_new_connection+0x16c/0x320 Call Trace: l2cap_connect_cfm+0x46c/0xe60 hci_remote_ext_features_evt+0x67d/0xbd0 hci_event_packet+0x894/0xc70 hci_rx_work+0x367/0xf00 process_one_work+0x908/0x19c0 worker_thread+0x65c/0xe40 kthread+0x34f/0x460 ret_from_fork+0x659/0x940 ret_from_fork_asm+0x1a/0x30 KASAN report as below: ================================================================== BUG: KASAN: slab-use-after-free in smp_del_chan+0xd2/0xe0 Read of size 8 at addr ffff888112a2e4a0 by task sh/493 Call Trace: dump_stack_lvl+0x93/0xd0 print_report+0xce/0x630 kasan_report+0xe0/0x110 smp_del_chan+0xd2/0xe0 smp_force_bredr+0xda/0x200 force_bredr_smp_write+0xc9/0x130 full_proxy_write+0x11f/0x180 vfs_write+0x25a/0x1010 ksys_write+0x111/0x200 do_syscall_64+0x115/0x6a0 entry_SYSCALL_64_after_hwframe+0x77/0x7f Allocated by task 493: kasan_save_stack+0x33/0x60 kasan_save_track+0x14/0x30 __kasan_kmalloc+0xaa/0xb0 __kmalloc_cache_noprof+0x251/0x610 l2cap_chan_create+0x47/0x930 smp_add_cid+0x309/0x4f0 smp_force_bredr+0x17d/0x200 force_bredr_smp_write+0xc9/0x130 full_proxy_write+0x11f/0x180 vfs_write+0x25a/0x1010 ksys_write+0x111/0x200 do_syscall_64+0x115/0x6a0 entry_SYSCALL_64_after_hwframe+0x77/0x7f Freed by task 496: kasan_save_stack+0x33/0x60 kasan_save_track+0x14/0x30 kasan_save_free_info+0x3b/0x60 __kasan_slab_free+0x5f/0x80 kfree+0x307/0x580 l2cap_chan_put+0x273/0x3a0 smp_unregister+0x59/0xe0 hci_dev_close_sync+0x4c9/0x1150 hci_set_powered_sync+0x4a7/0x680 set_powered_sync+0xaa/0x150 hci_cmd_sync_work+0x1b3/0x450 process_one_work+0x908/0x19c0 worker_thread+0x65c/0xe40 kthread+0x34f/0x460 ret_from_fork+0x659/0x940 ret_from_fork_asm+0x1a/0x30 The buggy address belongs to the object at ffff888112a2e000 which belongs to the cache kmalloc-2k of size 2048 The buggy address is located 1184 bytes inside of freed 2048-byte region [ffff888112a2e000, ffff888112a2e800) ================================================================== Fixes: 300acfdec916 ("Bluetooth: Introduce force_bredr_smp debugfs option for testing") Signed-off-by: Cen Zhang --- net/bluetooth/hci_debugfs.c | 2 ++ net/bluetooth/smp.c | 7 ++++++- net/bluetooth/smp.h | 3 ++- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/net/bluetooth/hci_debugfs.c b/net/bluetooth/hci_debugfs.c index cd5ef398f2382..f513731053d28 100644 --- a/net/bluetooth/hci_debugfs.c +++ b/net/bluetooth/hci_debugfs.c @@ -525,7 +525,9 @@ static ssize_t force_bredr_smp_write(struct file *file, if (err) return err; + hci_dev_lock(hdev); err = smp_force_bredr(hdev, enable); + hci_dev_unlock(hdev); if (err) return err; diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c index 948a847c0dc23..e605ee8d20586 100644 --- a/net/bluetooth/smp.c +++ b/net/bluetooth/smp.c @@ -3433,6 +3433,10 @@ int smp_force_bredr(struct hci_dev *hdev, bool enable) if (enable == hci_dev_test_flag(hdev, HCI_FORCE_BREDR_SMP)) return -EALREADY; + /* A powered-off controller has no registered SMP roots. */ + if (!test_bit(HCI_UP, &hdev->flags)) + goto done; + if (enable) { struct l2cap_chan *chan; @@ -3441,7 +3445,7 @@ int smp_force_bredr(struct hci_dev *hdev, bool enable) return PTR_ERR(chan); hdev->smp_bredr_data = chan; - } else { + } else if (hdev->smp_bredr_data) { struct l2cap_chan *chan; chan = hdev->smp_bredr_data; @@ -3449,6 +3453,7 @@ int smp_force_bredr(struct hci_dev *hdev, bool enable) smp_del_chan(chan); } +done: hci_dev_change_flag(hdev, HCI_FORCE_BREDR_SMP); return 0; diff --git a/net/bluetooth/smp.h b/net/bluetooth/smp.h index 0537762e2775e..22eabda930ef4 100644 --- a/net/bluetooth/smp.h +++ b/net/bluetooth/smp.h @@ -195,7 +195,8 @@ bool smp_irk_matches(struct hci_dev *hdev, const u8 irk[16], int smp_generate_rpa(struct hci_dev *hdev, const u8 irk[16], bdaddr_t *rpa); int smp_generate_oob(struct hci_dev *hdev, u8 hash[16], u8 rand[16]); -int smp_force_bredr(struct hci_dev *hdev, bool enable); +int smp_force_bredr(struct hci_dev *hdev, bool enable) + __must_hold(&hdev->lock); int smp_register(struct hci_dev *hdev); void smp_unregister(struct hci_dev *hdev);