From: Keith Packard <keithp@keithp.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Waldemar.Rymarkiewicz@tieto.com, padovan@profusion.mobi,
marcel@holtmann.org, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Regression caused by "Bluetooth: Map sec_level to link key requirements"
Date: Sun, 19 Jun 2011 13:11:17 +0200 [thread overview]
Message-ID: <yun8vsynkiy.fsf@aiko.keithp.com> (raw)
In-Reply-To: <BANLkTim4F8ZvWPMHSXpcBj9Eb2uFThcz4w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 759 bytes --]
On Fri, 10 Jun 2011 14:58:50 +0900, Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote:
> diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> index 2f5ae53..b309f84 100644
> --- a/net/bluetooth/hci_conn.c
> +++ b/net/bluetooth/hci_conn.c
> @@ -673,8 +673,8 @@ auth:
> if (test_and_set_bit(HCI_CONN_ENCRYPT_PEND, &conn->pend))
> return 0;
>
> - hci_conn_auth(conn, sec_level, auth_type);
> - return 0;
> + if (!(hci_conn_auth(conn, sec_level, auth_type)))
> + return 0;
>
> encrypt:
> if (conn->link_mode & HCI_LM_ENCRYPT)
That makes the first connection afer boot succeed, but subsequent
connections fail in the same way.
--
keith.packard@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2011-06-19 11:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 7:20 Regression caused by "Bluetooth: Map sec_level to link key requirements" Keith Packard
2011-06-09 7:59 ` Waldemar.Rymarkiewicz
2011-06-09 8:33 ` Johan Hedberg
2011-06-09 17:01 ` Keith Packard
2011-06-09 17:11 ` Waldemar.Rymarkiewicz
2011-06-10 5:55 ` Johan Hedberg
2011-06-10 5:58 ` Luiz Augusto von Dentz
2011-06-19 11:11 ` Keith Packard [this message]
2011-06-19 17:59 ` Johan Hedberg
2011-06-19 19:01 ` Keith Packard
2011-06-25 5:45 ` Jeremy Fitzhardinge
2011-06-25 19:40 ` Gustavo F. Padovan
2011-06-09 8:02 ` Waldemar.Rymarkiewicz
2011-06-09 17:04 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yun8vsynkiy.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=Waldemar.Rymarkiewicz@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).