From: Ming Zhang <blackmagic02881@gmail.com>
To: linux-btrace@vger.kernel.org
Subject: Re: [BTT PATCH] Add back in combined seek output file
Date: Tue, 10 Apr 2007 17:26:50 +0000 [thread overview]
Message-ID: <1176226010.3696.41.camel@fs0004.ibrix.com> (raw)
In-Reply-To: <461BC38D.5040405@hp.com>
On Tue, 2007-04-10 at 13:18 -0400, Alan D. Brunelle wrote:
> Ming Zhang wrote:
> > On Tue, 2007-04-10 at 13:04 -0400, Alan D. Brunelle wrote:
> >
> >> @@ -149,9 +150,12 @@ void seeki_add(void *handle, struct io *iop)
> >> struct seeki *sip = handle;
> >> long long dist = seek_dist(sip, iop);
> >> FILE *fp = IOP_READ(iop) ? sip->rfp : sip->wfp;
> >> + double tstamp = BIT_TIME(iop->t.time);
> >>
> >> if (fp)
> >> - fprintf(fp, "%15.9lf %13lld\n", BIT_TIME(iop->t.time),
> >> dist);
> >> + fprintf(fp, "%15.9lf %13lld\n", tstamp, dist);
> >> + if (sip->cfp)
> >> + fprintf(sip->cfp, "%15.9lf %13lld\n", tstamp, dist);
> >>
> >>
> >
> > thx for adding this. it might be better if in combined file, print out
> > current io is read or write.
> >
> > Ming
> >
> >
> I could do this - very easily - but then the question is the format:
>
> - ASCII ("read" "write")
> - Binary (0 = write, 1 = read (or vice versa))
>
> It doesn't matter much to me...
r/w. easier for grep.
>
> Alan
> -
> To unsubscribe from this list: send the line "unsubscribe linux-btrace" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2007-04-10 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 16:59 [BTT PATCH] Add back in combined seek output file Alan D. Brunelle
2007-04-10 17:15 ` Ming Zhang
2007-04-10 17:18 ` Alan D. Brunelle
2007-04-10 17:26 ` Ming Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176226010.3696.41.camel@fs0004.ibrix.com \
--to=blackmagic02881@gmail.com \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox