From: Martin Peschke <mp3@de.ibm.com>
To: linux-s390@vger.kernel.org, linux-btrace@vger.kernel.org
Subject: Re: [Patch] include blktrace_api.h in headers_install
Date: Mon, 29 Sep 2008 15:30:34 +0000 [thread overview]
Message-ID: <1222702234.20048.26.camel@kitka.ibm.com> (raw)
In-Reply-To: <20080926193434.GA16003@wavehammer.waldi.eu.org>
On Fri, 2008-09-26 at 21:34 +0200, Bastian Blank wrote:
> On Wed, Jul 16, 2008 at 01:24:25PM +0200, Martin Peschke wrote:
> > +#ifdef __KERNEL__
> > + char name[BDEVNAME_SIZE]; /* output */
> > +#else
> > + char name[32]; /* output */
> > +#endif
>
> Bad idea. BDEVNAME_SIZE is not exported and therfor not part of the
> public API. As this defines a userspace API it must not change anyway.
So this should be simply char name[32] both for kernel and user space?
Martin
next prev parent reply other threads:[~2008-09-29 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 11:24 [Patch] include blktrace_api.h in headers_install Martin Peschke
2008-09-26 8:50 ` Jens Axboe
2008-09-26 19:34 ` Bastian Blank
2008-09-29 15:30 ` Martin Peschke [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-26 8:26 Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222702234.20048.26.camel@kitka.ibm.com \
--to=mp3@de.ibm.com \
--cc=linux-btrace@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).