From: Jens Axboe <jens.axboe@oracle.com>
To: linux-btrace@vger.kernel.org
Subject: Re: [PATCH] Fix crash with btreplay -v
Date: Wed, 10 Oct 2007 08:15:28 +0000 [thread overview]
Message-ID: <20071010081528.GH4984@kernel.dk> (raw)
In-Reply-To: <47086412.90601@gelato.unsw.edu.au>
On Sun, Oct 07 2007, Joshua Root wrote:
> tip->vfp is only initialised when verbose > 1, so we must only use it
> under the same circumstance.
Alan, I'll let you verify and commit btt/btreplay patches so we don't
step on each others feet.
> --
> Joshua Root, jmr AT gelato.unsw.edu.au
> http://www.gelato.unsw.edu.au
> btreplay/btreplay.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/btreplay/btreplay.c b/btreplay/btreplay.c
> index 89881cb..1808b35 100644
> --- a/btreplay/btreplay.c
> +++ b/btreplay/btreplay.c
> @@ -1327,7 +1327,7 @@ static void *replay_sub(void *arg)
> set_replay_ready();
> while (!is_send_done(tip) && tip->iterations--) {
> wait_iter_start();
> - if (verbose)
> + if (verbose > 1)
> fprintf(tip->vfp, "\n== %d ==\n", tip->iterations);
> while (!is_send_done(tip) && next_bunch(tip, &bunch))
> process_bunch(tip, &bunch);
--
Jens Axboe
prev parent reply other threads:[~2007-10-10 8:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-07 4:44 [PATCH] Fix crash with btreplay -v Joshua Root
2007-10-10 8:15 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071010081528.GH4984@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).