* [PATCH] Fix crash with btreplay -v
@ 2007-10-07 4:44 Joshua Root
2007-10-10 8:15 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Joshua Root @ 2007-10-07 4:44 UTC (permalink / raw)
To: linux-btrace
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
tip->vfp is only initialised when verbose > 1, so we must only use it
under the same circumstance.
--
Joshua Root, jmr AT gelato.unsw.edu.au
http://www.gelato.unsw.edu.au
[-- Attachment #2: 0001-Fix-crash-with-btreplay-v.patch --]
[-- Type: text/plain, Size: 659 bytes --]
btreplay/btreplay.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/btreplay/btreplay.c b/btreplay/btreplay.c
index 89881cb..1808b35 100644
--- a/btreplay/btreplay.c
+++ b/btreplay/btreplay.c
@@ -1327,7 +1327,7 @@ static void *replay_sub(void *arg)
set_replay_ready();
while (!is_send_done(tip) && tip->iterations--) {
wait_iter_start();
- if (verbose)
+ if (verbose > 1)
fprintf(tip->vfp, "\n=== %d ===\n", tip->iterations);
while (!is_send_done(tip) && next_bunch(tip, &bunch))
process_bunch(tip, &bunch);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Fix crash with btreplay -v
2007-10-07 4:44 [PATCH] Fix crash with btreplay -v Joshua Root
@ 2007-10-10 8:15 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2007-10-10 8:15 UTC (permalink / raw)
To: linux-btrace
On Sun, Oct 07 2007, Joshua Root wrote:
> tip->vfp is only initialised when verbose > 1, so we must only use it
> under the same circumstance.
Alan, I'll let you verify and commit btt/btreplay patches so we don't
step on each others feet.
> --
> Joshua Root, jmr AT gelato.unsw.edu.au
> http://www.gelato.unsw.edu.au
> btreplay/btreplay.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/btreplay/btreplay.c b/btreplay/btreplay.c
> index 89881cb..1808b35 100644
> --- a/btreplay/btreplay.c
> +++ b/btreplay/btreplay.c
> @@ -1327,7 +1327,7 @@ static void *replay_sub(void *arg)
> set_replay_ready();
> while (!is_send_done(tip) && tip->iterations--) {
> wait_iter_start();
> - if (verbose)
> + if (verbose > 1)
> fprintf(tip->vfp, "\n== %d ==\n", tip->iterations);
> while (!is_send_done(tip) && next_bunch(tip, &bunch))
> process_bunch(tip, &bunch);
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-10 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-07 4:44 [PATCH] Fix crash with btreplay -v Joshua Root
2007-10-10 8:15 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).