From: Jens Axboe <jens.axboe@oracle.com>
To: linux-btrace@vger.kernel.org
Subject: Re: [PATCH] blktrace: Make sure BLKTRACETEARDOWN does the full cleanup.
Date: Mon, 29 Oct 2007 19:48:53 +0000 [thread overview]
Message-ID: <20071029194852.GC7499@kernel.dk> (raw)
In-Reply-To: <1193572155-11126-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On Sun, Oct 28 2007, Aneesh Kumar K.V wrote:
> if blktrace program segfault it will not be able
> to call BLKTRACETEARDOWN. Now if we run the blktrace
> again that would result in a failure to create the
> block/<device> debugfs directory.This will result
> in blk_remove_root() to be called which will set
> blk_tree_root to NULL. But the debugfs block dir
> still exist because it contain subdirectory.
>
> Now if we try to fix it using BLKTRACETEARDOWN
> it won't work because blk_tree_root is NULL.
>
> Fix the same.
>
> Tested as below
Looks good, will apply tomorrow after some brief testing.
--
Jens Axboe
prev parent reply other threads:[~2007-10-29 19:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 11:49 [PATCH] blktrace: Make sure BLKTRACETEARDOWN does the full cleanup Aneesh Kumar K.V
2007-10-29 19:48 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071029194852.GC7499@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).