From: Jens Axboe <jens.axboe@oracle.com>
To: linux-btrace@vger.kernel.org
Subject: Re: [Patch 3/3] driver data: add support to blktrace user space code
Date: Thu, 16 Oct 2008 06:07:46 +0000 [thread overview]
Message-ID: <20081016060746.GR19428@kernel.dk> (raw)
In-Reply-To: <1216207574.26621.85.camel@kitka.ibm.com>
On Sun, Oct 05 2008, Martin Peschke wrote:
> From: Stefan Raspl <raspl@linux.vnet.ibm.com>
>
> Adds a new type of action 'drv_data' for blktrace to handle binary
> driver-specific data. Since the data is binary, blkparse will only put it in
> a binary file, not in the regular human-readable output.
I wonder if that should display some kind of informational message on
blkparse exit, if you are not dumping binary? Just to notify the user
that there was extra data available, but that it wasn't dumped.
Otherwise looks fine, I've applied 1-3.
--
Jens Axboe
next prev parent reply other threads:[~2008-10-16 6:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 11:26 [Patch 3/3] driver data: add support to blktrace user space code Martin Peschke
2008-10-05 13:07 ` Martin Peschke
2008-10-16 6:07 ` Jens Axboe [this message]
2008-10-16 8:35 ` [Patch 3/3] driver data: add support to blktrace user space Martin Peschke
2008-10-16 8:53 ` [Patch 3/3] driver data: add support to blktrace user space code Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081016060746.GR19428@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).