* [Patch] fix blktrace API (missing commit)
@ 2008-11-24 16:07 Martin Peschke
2009-01-21 13:58 ` Martin Peschke
2009-01-21 13:59 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Martin Peschke @ 2008-11-24 16:07 UTC (permalink / raw)
To: linux-btrace
From: Martin Peschke <mpeschke@linux.vnet.ibm.com>
The git commit 11914a53d2ec2974a565311af327b8983d8c820d added __BLK_TA_ABORT
to blktrace_api.h. A corresponding addition to the blktrace tools repository
has been missing, breaking the API. Blkparse complained:
"Bad fs action 40010011"
Signed-off-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>
---
blktrace_api.h | 2 ++
1 file changed, 2 insertions(+)
--- a/blktrace_api.h
+++ b/blktrace_api.h
@@ -48,6 +48,7 @@ enum {
__BLK_TA_SPLIT, /* bio was split */
__BLK_TA_BOUNCE, /* bio was bounced */
__BLK_TA_REMAP, /* bio was remapped */
+ __BLK_TA_ABORT, /* request aborted */
__BLK_TA_DRV_DATA, /* binary driver data */
};
@@ -78,6 +79,7 @@ enum blktrace_notify {
#define BLK_TA_SPLIT (__BLK_TA_SPLIT)
#define BLK_TA_BOUNCE (__BLK_TA_BOUNCE)
#define BLK_TA_REMAP (__BLK_TA_REMAP | BLK_TC_ACT(BLK_TC_QUEUE))
+#define BLK_TA_ABORT (__BLK_TA_ABORT | BLK_TC_ACT(BLK_TC_QUEUE))
#define BLK_TA_DRV_DATA (__BLK_TA_DRV_DATA | BLK_TC_ACT(BLK_TC_DRV_DATA))
#define BLK_TN_PROCESS (__BLK_TN_PROCESS | BLK_TC_ACT(BLK_TC_NOTIFY))
^ permalink raw reply [flat|nested] 3+ messages in thread* [Patch] fix blktrace API (missing commit)
2008-11-24 16:07 [Patch] fix blktrace API (missing commit) Martin Peschke
@ 2009-01-21 13:58 ` Martin Peschke
2009-01-21 13:59 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Martin Peschke @ 2009-01-21 13:58 UTC (permalink / raw)
To: linux-btrace
Hi Jens,
here is one of two fixes, which have not made it into blktrace yet.
I posted them end of last year
http://marc.info/?l=linux-btrace&m\x122754289122259&w=2
Please apply. Thanks,
Martin
From: Martin Peschke <mpeschke@linux.vnet.ibm.com>
The git commit 11914a53d2ec2974a565311af327b8983d8c820d added __BLK_TA_ABORT
to blktrace_api.h. A corresponding addition to the blktrace tools repository
has been missing, breaking the API. Blkparse complained:
"Bad fs action 40010011"
Signed-off-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>
---
blktrace_api.h | 2 ++
1 file changed, 2 insertions(+)
--- a/blktrace_api.h
+++ b/blktrace_api.h
@@ -48,6 +48,7 @@ enum {
__BLK_TA_SPLIT, /* bio was split */
__BLK_TA_BOUNCE, /* bio was bounced */
__BLK_TA_REMAP, /* bio was remapped */
+ __BLK_TA_ABORT, /* request aborted */
__BLK_TA_DRV_DATA, /* binary driver data */
};
@@ -78,6 +79,7 @@ enum blktrace_notify {
#define BLK_TA_SPLIT (__BLK_TA_SPLIT)
#define BLK_TA_BOUNCE (__BLK_TA_BOUNCE)
#define BLK_TA_REMAP (__BLK_TA_REMAP | BLK_TC_ACT(BLK_TC_QUEUE))
+#define BLK_TA_ABORT (__BLK_TA_ABORT | BLK_TC_ACT(BLK_TC_QUEUE))
#define BLK_TA_DRV_DATA (__BLK_TA_DRV_DATA | BLK_TC_ACT(BLK_TC_DRV_DATA))
#define BLK_TN_PROCESS (__BLK_TN_PROCESS | BLK_TC_ACT(BLK_TC_NOTIFY))
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Patch] fix blktrace API (missing commit)
2008-11-24 16:07 [Patch] fix blktrace API (missing commit) Martin Peschke
2009-01-21 13:58 ` Martin Peschke
@ 2009-01-21 13:59 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2009-01-21 13:59 UTC (permalink / raw)
To: linux-btrace
On Wed, Jan 21 2009, Martin Peschke wrote:
> Hi Jens,
> here is one of two fixes, which have not made it into blktrace yet.
> I posted them end of last year
> http://marc.info/?l=linux-btrace&m\x122754289122259&w=2
Applied both of them, thanks for reposting!
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-21 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-24 16:07 [Patch] fix blktrace API (missing commit) Martin Peschke
2009-01-21 13:58 ` Martin Peschke
2009-01-21 13:59 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).