From: Ingo Molnar <mingo@elte.hu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Theodore Ts'o <tytso@mit.edu>, Shawn Du <duyuyang@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-btrace@vger.kernel.org
Subject: Re: PATCH 1/3] blktrace: support per-partition tracing
Date: Tue, 14 Apr 2009 07:59:47 +0000 [thread overview]
Message-ID: <20090414075947.GA27003@elte.hu> (raw)
In-Reply-To: <49E42620.4050701@cn.fujitsu.com>
* Li Zefan <lizf@cn.fujitsu.com> wrote:
> --- a/include/linux/blktrace_api.h
> +++ b/include/linux/blktrace_api.h
> @@ -165,8 +165,9 @@ struct blk_trace {
>
> extern int blk_trace_ioctl(struct block_device *, unsigned, char __user *);
> extern void blk_trace_shutdown(struct request_queue *);
> -extern int do_blk_trace_setup(struct request_queue *q,
> - char *name, dev_t dev, struct blk_user_trace_setup *buts);
> +extern int do_blk_trace_setup(struct request_queue *q, char *name,
> + dev_t dev, struct block_device *bdev,
> + struct blk_user_trace_setup *buts);
> extern void __trace_note_message(struct blk_trace *, const char *fmt, ...);
>
> /**
> @@ -193,6 +194,7 @@ extern void __trace_note_message(struct blk_trace *, const char *fmt, ...);
> extern void blk_add_driver_data(struct request_queue *q, struct request *rq,
> void *data, size_t len);
> extern int blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
> + struct block_device *bdev,
> char __user *arg);
> extern int blk_trace_startstop(struct request_queue *q, int start);
> extern int blk_trace_remove(struct request_queue *q);
Small detail: you forgot about the !CONFIG_BLK_DEV_IO_TRACE case
here, the wrapper macros there need to be updated.
(no need to resend - i fixed this up in the 1/3 and 3/3 patches)
Ingo
next prev parent reply other threads:[~2009-04-14 7:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 5:58 PATCH 1/3] blktrace: support per-partition tracing Li Zefan
2009-04-14 5:59 ` [PATCH 2/3] blktrace: support per-partition tracing for ftrace plugin Li Zefan
2009-04-14 6:00 ` [PATCH 3/3] blktrace: add trace/ to /sys/block/sda Li Zefan
2009-04-14 7:59 ` Ingo Molnar [this message]
2009-04-14 8:14 ` PATCH 1/3] blktrace: support per-partition tracing Li Zefan
2009-04-14 8:34 ` Ingo Molnar
2009-04-14 8:09 ` Ingo Molnar
2009-04-14 8:27 ` Li Zefan
2009-04-14 8:38 ` Ingo Molnar
2009-04-14 8:53 ` Li Zefan
2009-04-14 9:43 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090414075947.GA27003@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=duyuyang@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-btrace@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).