From: Jens Axboe <axboe@kernel.dk>
To: linux-btrace@vger.kernel.org
Subject: Re: [PATCH] blktrace bno_plot.py: output comprehensive message when gnuplot not found
Date: Wed, 04 Dec 2013 02:25:35 +0000 [thread overview]
Message-ID: <20131204022535.GH5051@kernel.dk> (raw)
In-Reply-To: <1386072299-10149-1-git-send-email-devel@etsukata.com>
On Tue, Dec 03 2013, Eiichi Tsukata wrote:
> Currently, bno_plot.py uses os.execvp which does not show enough information
> when executed command is not found. For example, when gnuplot is not found
> bno_plot.py shows the following messages:
>
> Traceback (most recent call last):
> File "/usr/local/bin/bno_plot.py", line 123, in <module>
> os.execvp(cmd[0], cmd)
> File "/usr/lib64/python2.7/os.py", line 344, in execvp
> _execvpe(file, args)
> File "/usr/lib64/python2.7/os.py", line 368, in _execvpe
> func(file, *argrest)
> OSError: [Errno 2] No such file or directory
>
> Users can't understand what happend directly from the message.
>
> Instead of os.execvp, this patch uses os.system which shows the following
> messages when gnuplot not found:
>
> sh: gnuplot: command not found
Thanks, applied.
--
Jens Axboe
prev parent reply other threads:[~2013-12-04 2:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 12:04 [PATCH] blktrace bno_plot.py: output comprehensive message when gnuplot not found Eiichi Tsukata
2013-12-04 2:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204022535.GH5051@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).