linux-btrace.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alan D. Brunelle" <alan.brunelle@hp.com>
To: linux-btrace@vger.kernel.org
Subject: Re: [BTT PATCH] Clean up all memory leaks
Date: Tue, 10 Apr 2007 00:43:48 +0000	[thread overview]
Message-ID: <461ADDC4.8040103@hp.com> (raw)
In-Reply-To: <461A4CA0.10808@hp.com>

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Alan D. Brunelle wrote:
> This has a "small" bug in it - for some reason the .dat file 
> containing "ranges" now contains every IO.
>
> Looking into it...
>
> Alan


[-- Attachment #2: fix-ranges --]
[-- Type: text/plain, Size: 606 bytes --]

From: Alan D. Brunelle <Alan.Brunelle@hp.com>

Fix range check: use proper data type for comparison

Signed-off-by: Alan D. Brunelle <Alan.Brunelle@hp.com>
---

 btt/inlines.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/btt/inlines.h b/btt/inlines.h
index 3c8deac..edb2182 100644
--- a/btt/inlines.h
+++ b/btt/inlines.h
@@ -52,7 +52,7 @@ static inline void update_range(struct list_head *head_p, __u64 time)
 		if (time < rip->end)
 			return;
 
-		if ((time - rip->end) < range_delta) {
+		if (BIT_TIME(time - rip->end) < range_delta) {
 			rip->end = time;
 			return;
 		}

      parent reply	other threads:[~2007-04-10  0:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-09 14:24 [BTT PATCH] Clean up all memory leaks Alan D. Brunelle
2007-04-09 15:03 ` Ming Zhang
2007-04-10  0:33 ` Alan D. Brunelle
2007-04-10  0:43 ` Alan D. Brunelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=461ADDC4.8040103@hp.com \
    --to=alan.brunelle@hp.com \
    --cc=linux-btrace@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).