From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Du Date: Wed, 31 Dec 2008 02:21:43 +0000 Subject: Re: Re: Re: [PATCH] blktrace: fix to trace a partition, instead of Message-Id: <495AD737.1010503@gmail.com> List-Id: References: <494895E9.9030300@gmail.com> In-Reply-To: <494895E9.9030300@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-btrace@vger.kernel.org >Very nice! The only problem with this is that we have actions that are, >by definition, per device. So we probably want to include any sector >that is within the range of the partition, AND a zero sector. So that >means changing act_log_check() to something ala: > >- if (sector < bt->start_lba || sector > bt->end_lba) >+ if (!sector || sector < bt->start_lba || sector > bt->end_lba) > return 1; > >in pseudo patch form. Thank you sir. And perhaps, we change in __blk_add_trace(): - if (unlikely(act_log_check(bt, what, sector, pid))) + if (act_log_check(bt, what, sector, pid)) Sorry for the lateness. Happy New Year. Shawn