From: Eric Sandeen <sandeen@redhat.com>
To: linux-btrace@vger.kernel.org
Subject: [PATCH] fix max-pkts option inconsistencies
Date: Thu, 30 Apr 2009 15:56:04 +0000 [thread overview]
Message-ID: <49F9CA14.6060808@redhat.com> (raw)
This is for RH bug 498426,
btrecord doesn't recognize --max-pkts and --max-packets cmd line options
Usage text and some documentation references "--max-pkts" and
the man page references "--max-packets" but the getopts code
is looking for --max_pkts.
I'm not sure if it's best to make the code match the majority
of the docs, or fix the docs to match the code? This patch does
the former, but I'm not picky if you want to go the other way :)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/btreplay/btrecord.c b/btreplay/btrecord.c
index 09329f7..88ab806 100644
--- a/btreplay/btrecord.c
+++ b/btreplay/btrecord.c
@@ -152,7 +152,7 @@ static struct option l_opts[] = {
.val = 'm'
},
{
- .name = "max_pkts",
+ .name = "max-pkts",
.has_arg = required_argument,
.flag = NULL,
.val = 'M'
diff --git a/doc/btrecord.8 b/doc/btrecord.8
index f8477da..b4318ae 100644
--- a/doc/btrecord.8
+++ b/doc/btrecord.8
@@ -121,7 +121,7 @@ The default value is 10,000,000 nanoseconds (10 milliseconds).
\-M <\fInum\fR>
.br
-\-\-max\-packets=<\fInum\fR>
+\-\-max\-pkts=<\fInum\fR>
.RS
Set maximum number of packets per bunch.
The \fI\-M\fR option requires a single parameter which specifies the
reply other threads:[~2009-04-30 15:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F9CA14.6060808@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).