linux-btrace.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fix max-pkts option inconsistencies
@ 2009-04-30 15:56 Eric Sandeen
  0 siblings, 0 replies; only message in thread
From: Eric Sandeen @ 2009-04-30 15:56 UTC (permalink / raw)
  To: linux-btrace

This is for RH bug 498426,
btrecord doesn't recognize --max-pkts and --max-packets cmd line options

Usage text and some documentation references "--max-pkts" and
the man page references "--max-packets" but the getopts code
is looking for --max_pkts.

I'm not sure if it's best to make the code match the majority
of the docs, or fix the docs to match the code?  This patch does
the former, but I'm not picky if you want to go the other way :)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/btreplay/btrecord.c b/btreplay/btrecord.c
index 09329f7..88ab806 100644
--- a/btreplay/btrecord.c
+++ b/btreplay/btrecord.c
@@ -152,7 +152,7 @@ static struct option l_opts[] = {
 		.val = 'm'
 	},
 	{
-		.name = "max_pkts",
+		.name = "max-pkts",
 		.has_arg = required_argument,
 		.flag = NULL,
 		.val = 'M'
diff --git a/doc/btrecord.8 b/doc/btrecord.8
index f8477da..b4318ae 100644
--- a/doc/btrecord.8
+++ b/doc/btrecord.8
@@ -121,7 +121,7 @@ The default value is 10,000,000 nanoseconds (10 milliseconds).
 
 \-M <\fInum\fR>
 .br
-\-\-max\-packets=<\fInum\fR>
+\-\-max\-pkts=<\fInum\fR>
 .RS
 Set maximum number of packets per bunch.
 The \fI\-M\fR option requires a single parameter which specifies the


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-30 15:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-30 15:56 [PATCH] fix max-pkts option inconsistencies Eric Sandeen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).