linux-btrace.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: linux-btrace@vger.kernel.org
Subject: [PATCH] fix up btrace options & manpage
Date: Mon, 04 May 2009 20:40:53 +0000	[thread overview]
Message-ID: <49FF52D5.70607@redhat.com> (raw)

The btrace script & man page didn't quite match for options,
and the btrace script was missing a few options in the getopts
specification (b&n).  Also, there seems to be no such thing as
a "summarize" option anywhere, so remove it.

Reported-by: /Milos Malik <mmalik@redhat.com <mailto:mmalik@redhat.com>>/
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

(this goes after the general manpage cleanup I sent, sorry,
should have been a series in retrospect)


diff --git a/btrace b/btrace
index f902707..45c10cf 100644
--- a/btrace
+++ b/btrace
@@ -8,11 +8,10 @@
 
 TRACEOPTS=""
 PARSEOPTS="-b100000"
-SUMMARIZE=""
-USAGE="Usage: btrace [-s] [-t] [-S] [-w N] [-a <trace>...] [-r <dbg mnt]<dev>..."
+USAGE="Usage: btrace [-s] [-t] [-w N] [-n N] [-b N] [-a <trace>...] [-r <dbg mnt>] <dev>..."
 DIRNAME=`dirname $0`
 
-while getopts "a:r:stSw:hv" c
+while getopts "a:w:n:b:r:sthv" c
 do
 	case $c in
 	a)	TRACEOPTS=$TRACEOPTS" -a "$OPTARG" ";;
@@ -24,13 +23,11 @@ do
 	t)	PARSEOPTS=$PARSEOPTS" -t";;
 	h)	PARSEOPTS=$PARSEOPTS" -h";;
 	v)	PARSEOPTS=$PARSEOPTS" -v";;
-	S)	SUMMARIZE="";;
 	\?)	echo $USAGE 1>&2
 		exit 2
 		;;
 	esac
 done
-PARSEOPTS="${PARSEOPTS} ${SUMMARIZE}"
 
 shift `expr $OPTIND - 1`
 if [ $# -eq 0 ]; then
diff --git a/doc/btrace.8 b/doc/btrace.8
index 1e6c06d..a1f34c2 100644
--- a/doc/btrace.8
+++ b/doc/btrace.8
@@ -6,7 +6,7 @@ btrace \- perform live tracing for block devices
 
 
 .SH SYNOPSIS
-.B btrace [\-s] [\-t] [\-w \fIN\fN] [\-n \fIN\fR] [\-b \fIN\fR]  [\-a <\fItrace\fR>...] <\fIdev\fR>...
+.B btrace [\-s] [\-t] [\-w \fIN\fN] [\-n \fIN\fR] [\-b \fIN\fR] [\-r \fI<dbg mnt>\fR] [\-a <\fItrace\fR>...] <\fIdev\fR>...
 .br
 
 
@@ -41,6 +41,10 @@ Specifies buffer size for event extraction (scaled by 1024) (see
 \fIblktrace\fR (8)).
 
 .HP 4
+.B \-r \fI<dbg mnt>\fR
+Specifies the debugfs mountpoint.
+
+.HP 4
 .B \-a <\fItrace\fR>...
 Adds mask to current filter (see \fIblktrace\fR (8)).
 


                 reply	other threads:[~2009-05-04 20:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49FF52D5.70607@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-btrace@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).