linux-btrace.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: raspl@linux.vnet.ibm.com
Cc: linux-btrace@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>,
	linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com,
	heiko.carstens@de.ibm.com
Subject: Re: [Patch] Remove debugfs entries on bad path
Date: Tue, 19 May 2009 01:14:06 +0000	[thread overview]
Message-ID: <4A1207DE.4000409@cn.fujitsu.com> (raw)
In-Reply-To: <4A115BA5.6090905@linux.vnet.ibm.com>

A better title:
	[Patch] blktrace: remove debugfs entries on bad path

Stefan Raspl wrote:
> debugfs directory entries for devices are not removed on bad path.

Can you be more elaborate on how to reproduce this issue?

> If so, subsequent attempts to start blktrace on the respective
> devices will not succeed due to existing directories.
> 
> Signed-off-by: Stefan Raspl <stefan.raspl@linux.vnet.ibm.com>
> 
> ---
>  kernel/trace/blktrace.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -262,6 +262,7 @@ static void blk_trace_free(struct blk_tr
>  {
>  	debugfs_remove(bt->msg_file);
>  	debugfs_remove(bt->dropped_file);
> +	debugfs_remove(bt->dir);
>  	relay_close(bt->rchan);
>  	free_percpu(bt->sequence);
>  	free_percpu(bt->msg_data);
> 


  reply	other threads:[~2009-05-19  1:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 12:59 [Patch] Remove debugfs entries on bad path Stefan Raspl
2009-05-19  1:14 ` Li Zefan [this message]
2009-05-19  6:46   ` [Patch] blktrace: remove " Stefan Raspl
2009-05-19  7:07     ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1207DE.4000409@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-btrace@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raspl@linux.vnet.ibm.com \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).