From: "Alan D. Brunelle" <alan.brunelle@hp.com>
To: linux-btrace@vger.kernel.org
Subject: Re: [PATCH] blktrace: disallow -o when using multiple devices
Date: Mon, 20 Sep 2010 14:35:21 +0000 [thread overview]
Message-ID: <4C977129.2020904@hp.com> (raw)
In-Reply-To: <4C9227C3.7000404@netezza.com>
On 09/16/2010 05:17 PM, Brett Russ wrote:
> On 09/16/2010 10:20 AM, Brett Russ wrote:
>> -Wouldn't it be a good idea to just add<prefix> before the filename(s)
>> that would have been created in either the single or multiple device
>> case? I.e. in the multiple device case, how about
>> "<prefix>.<device>.blktrace.<cpu>"? That way the program always does
>> what the user wants, no special case documentation required.
>
> I just now read in full your second email on the original thread where
> you mentioned doing this solution, sorry for the redundancy. You
> expressed reservations about it, wondering what else it might break. I'd
> suggest we make the change and test it, rather than having a "-o" option
> with limited utility? I imagine the biggest question mark is how
> blkparse handles it.
>
> -Brett
I'm not so sure about this Brett - people may have scripts out there
that depend on the current semantics. I'd be OK with doing it if Jens
thought this was a minor concern...
Regards,
Alan
next prev parent reply other threads:[~2010-09-20 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 14:20 [PATCH] blktrace: disallow -o when using multiple devices Brett Russ
2010-09-16 21:17 ` Brett Russ
2010-09-20 14:35 ` Alan D. Brunelle [this message]
2010-09-20 14:39 ` Brett Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C977129.2020904@hp.com \
--to=alan.brunelle@hp.com \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).