From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brett Russ Date: Mon, 20 Sep 2010 14:39:36 +0000 Subject: Re: [PATCH] blktrace: disallow -o when using multiple devices Message-Id: <4C977228.7040304@netezza.com> List-Id: References: <4C9227C3.7000404@netezza.com> In-Reply-To: <4C9227C3.7000404@netezza.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-btrace@vger.kernel.org On 09/20/2010 10:35 AM, Alan D. Brunelle wrote: > On 09/16/2010 05:17 PM, Brett Russ wrote: >> On 09/16/2010 10:20 AM, Brett Russ wrote: >>> -Wouldn't it be a good idea to just add before the filename(s) >>> that would have been created in either the single or multiple device >>> case? I.e. in the multiple device case, how about >>> "..blktrace."? That way the program always does >>> what the user wants, no special case documentation required. >> >> I just now read in full your second email on the original thread where >> you mentioned doing this solution, sorry for the redundancy. You >> expressed reservations about it, wondering what else it might break. I'd >> suggest we make the change and test it, rather than having a "-o" option >> with limited utility? I imagine the biggest question mark is how >> blkparse handles it. >> >> -Brett > > I'm not so sure about this Brett - people may have scripts out there > that depend on the current semantics. I'd be OK with doing it if Jens > thought this was a minor concern... As long as the change only affected output of multiple devices with "-o", which doesn't work today, then I'd think no scripts could be affected. Thanks, Brett