linux-btrace.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] blktrace:  pass a valid pointer to realloc.
@ 2011-06-20 13:12 Matthew Boyle
  0 siblings, 0 replies; only message in thread
From: Matthew Boyle @ 2011-06-20 13:12 UTC (permalink / raw)
  To: linux-btrace

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

When blktrace is writing to stdout, and there's sufficient disk activity
to fill the trace buffer, tb_combine() tries to increase the buffer
size.  But the pointer it passes to realloc isn't to the head of the
block of memory.  glibc's realloc gets really quite upset at this, and
aborts the process.

This just passes in the pointer handed out by malloc.

Signed-off-by: Matt Boyle <mlb@corefiling.co.uk>
---
  blktrace.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)



[-- Attachment #2: 0001-blktrace-pass-a-valid-pointer-to-realloc.patch --]
[-- Type: text/x-patch, Size: 405 bytes --]

diff --git a/blktrace.c b/blktrace.c
index 72866e2..d4d5111 100644
--- a/blktrace.c
+++ b/blktrace.c
@@ -1330,7 +1330,7 @@ static struct trace_buf *tb_combine(struct trace_buf *prev,
 		 * the whole structures, as the other fields
 		 * are "static".
 		 */
-		prev = realloc(prev->buf, sizeof(*prev) + tot_len);
+		prev = realloc(prev, sizeof(*prev) + tot_len);
 		prev->buf = (void *)(prev + 1);
 	}
 


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-06-20 13:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-20 13:12 [PATCH] blktrace: pass a valid pointer to realloc Matthew Boyle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).