[PATCH] blktrace: document -k option

[PATCH] blktrace: document -k option

[Eric Sandeen]

The -k option was missing from the usage() output and was present
only in the man page synopsis.  Say a few more words about it.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/blktrace.c b/blktrace.c
index 89aaaac..4e96573 100644
--- a/blktrace.c
+++ b/blktrace.c
@@ -450,6 +450,7 @@ static char usage_str[] = "\n\n" \
         "[ -p <port number>   | --port=<port number>]\n" \
         "[ -s                 | --no-sendfile]\n" \
         "[ -I <devs file>     | --input-devs=<devs file>]\n" \
+        "[ -k                 | --kill]\n" \
         "[ -v <version>       | --version]\n" \
         "[ -V <version>       | --version]\n" \
 
@@ -467,6 +468,7 @@ static char usage_str[] = "\n\n" \
 	"\t-p Network port to use (default 8462)\n" \
 	"\t-s Make the network client NOT use sendfile() to transfer data\n" \
 	"\t-I Add devices found in <devs file>\n" \
+	"\t-k Kill a running trace\n" \
 	"\t-v Print program version info\n" \
 	"\t-V Print program version info\n\n";
 
diff --git a/doc/blktrace.8 b/doc/blktrace.8
index b5e69b7..7f13231 100644
--- a/doc/blktrace.8
+++ b/doc/blktrace.8
@@ -163,6 +163,13 @@ This only works when supplying a single device, or when piping the output
 via "-o -" with multiple devices.
 .RE
 
+\-k
+.br
+\-\-kill
+.RS
+Kill a running trace if blktrace dies
+.RE
+
 \-r \fIrel-path\fR
 .br
 \-\-relay=\fIrel-path\fR     

Re: [PATCH] blktrace: document -k option

[Jeff Moyer]

Eric Sandeen <sandeen@redhat.com> writes:

> The -k option was missing from the usage() output and was present
> only in the man page synopsis.  Say a few more words about it.
>

Hmm.  See:

commit fb7f86674a516ddff0d60bfab3bd284a4812075f
Author: Edward Shishkin <edward@redhat.com>
Date:   Tue Apr 20 15:41:14 2010 +0200

    blktrace: disable kill option - take 2

Re: [PATCH] blktrace: document -k option

[Eric Sandeen]

On 5/9/13 9:00 AM, Jeff Moyer wrote:
> Eric Sandeen <sandeen@redhat.com> writes:
> 
>> The -k option was missing from the usage() output and was present
>> only in the man page synopsis.  Say a few more words about it.
>>
> 
> Hmm.  See:
> 
> commit fb7f86674a516ddff0d60bfab3bd284a4812075f
> Author: Edward Shishkin <edward@redhat.com>
> Date:   Tue Apr 20 15:41:14 2010 +0200
> 
>     blktrace: disable kill option - take 2
> 

Gah.  That's clever.

Then I guess it should be removed from the synopsis too.

Shouldn't it have been removed from the actual code as well?

Thanks though :)

-Eric

Re: [PATCH] blktrace: document -k option

[Jens Axboe]

On Thu, May 09 2013, Eric Sandeen wrote:
> On 5/9/13 9:00 AM, Jeff Moyer wrote:
> > Eric Sandeen <sandeen@redhat.com> writes:
> > 
> >> The -k option was missing from the usage() output and was present
> >> only in the man page synopsis.  Say a few more words about it.
> >>
> > 
> > Hmm.  See:
> > 
> > commit fb7f86674a516ddff0d60bfab3bd284a4812075f
> > Author: Edward Shishkin <edward@redhat.com>
> > Date:   Tue Apr 20 15:41:14 2010 +0200
> > 
> >     blktrace: disable kill option - take 2
> > 
> 
> Gah.  That's clever.
> 
> Then I guess it should be removed from the synopsis too.
> 
> Shouldn't it have been removed from the actual code as well?
> 
> Thanks though :)

Kill away :-)

-- 
Jens Axboe