From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Mahoney Date: Thu, 20 Aug 2015 15:52:51 +0000 Subject: [PATCH] btreplay: Fix typo in scaling up the dynamic cpu set size. Message-Id: <55D5F7D3.7090005@suse.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-btrace@vger.kernel.org From: Josef Cejka In get_ncpus, we default to using 4096 CPUs if _SC_NPROCESSORS_CONF isn't enabled. If that is insufficient, sched_getaffinity will fail and we retry after doubling the size of the cpu_set_t allocation. There's a typo in there that means we don't actually double the size and will loop forever allocating the same sized cpu_set_t instead. Signed-off-by: Josef Cejka Signed-off-by: Jeff Mahoney --- btreplay/btreplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/btreplay/btreplay.c +++ b/btreplay/btreplay.c @@ -516,7 +516,7 @@ realloc: if (sched_getaffinity(getpid(), size, cpus)) { if( errno = EINVAL && nrcpus < (4096<<4) ) { CPU_FREE(cpus); - nrcpus <= 1; + nrcpus <<= 1; goto realloc; } fatal("sched_getaffinity", ERR_SYSCALL, "Can't get CPU info\n"); -- Jeff Mahoney SUSE Labs