From: Jens Axboe <axboe@fb.com>
To: linux-btrace@vger.kernel.org
Subject: Re: [PATCH 3/3] btreplay: make Ctrl-C work
Date: Mon, 25 Apr 2016 14:53:46 +0000 [thread overview]
Message-ID: <571E2F7A.4080703@fb.com> (raw)
In-Reply-To: <1461411850-25443-3-git-send-email-r.peniaev@gmail.com>
On 04/23/2016 05:44 AM, Roman Pen wrote:
> is_reap_done() must also check that SIGINT or SIGTERM have come, or
> we hang forever with such backtraces after Ctrl-C:
>
> (gdb) thr a a bt
>
> Thread 3 (Thread 0x7fbff8ff9700 (LWP 12607)):
> #0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
> #1 0x0000000000402698 in replay_rec () at btreplay.c:1035
> #2 0x00007fc001fe5454 in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0
> #3 0x00007fc001d1eecd in ?? () from /lib/x86_64-linux-gnu/libc.so.6
> #4 0x0000000000000000 in ?? ()
>
> Thread 2 (Thread 0x7fbfea7fc700 (LWP 12611)):
> #0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
> #1 0x0000000000402698 in replay_rec () at btreplay.c:1035
> #2 0x00007fc001fe5454 in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0
> #3 0x00007fc001d1eecd in ?? () from /lib/x86_64-linux-gnu/libc.so.6
> #4 0x0000000000000000 in ?? ()
>
> Thread 1 (Thread 0x7fc00282e700 (LWP 12597)):
> #0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
> #1 0x0000000000402303 in __wait_cv () at btreplay.c:413
> #2 0x0000000000401ae8 in main () at btreplay.c:426
Applied this, and the two other patches. Thanks!
--
Jens Axboe
prev parent reply other threads:[~2016-04-25 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-23 11:44 [PATCH 3/3] btreplay: make Ctrl-C work Roman Pen
2016-04-25 14:53 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571E2F7A.4080703@fb.com \
--to=axboe@fb.com \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).